mbox series

[V2,0/2,SRU,Mantic] Support mipi camera on Intel Meteor Lake platform

Message ID 20231025160642.4040394-1-vicamo.yang@canonical.com
Headers show
Series Support mipi camera on Intel Meteor Lake platform | expand

Message

You-Sheng Yang Oct. 25, 2023, 4:06 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2031412

[Impact]

Need kernel driver fixes for int3472/iommu for Intel IPU6 platform on MTL.

[Fix]

Two fixes in need. One, we need IOMMU passthrough for MTL platform. The other,
fix is for handshake pin support for Lattice MIPI aggregator.

The Intel IPU6 camera drivers are not yet all upstreamed yet. So far
Intel VSC, LJCA (the previous MIPI aggregator for ADL/RPL platforms) are
in v6.6 already, and IPU6 ISYS is under upstream review. More components
to come according to Intel.

These two fixes are therefore for related components for not-yet fully
upstreamed IPU6 as needed for out-of-tree dkms drivers.

[Test Case]

```
$ sudo dmesg | grep "Passthrough IOMMU for integrated Intel IPU"
$ sudo dmesg | grep int3472
# should have no "int3472-discrete INT3472:0c: GPIO type 0x12 unknown; the sensor may not work"
```

[Where problems could occur]

IOMMU Passthrough as necessary to enable IPU6 on Intel platforms, and it has
been patching a few generations e.g. Bug 1989041 for Raptor Lake, Bug 1958004
for TGL and ADL. As IPU is not an external facing device which is not risky.

For INT3472, the proposed patch might receive further updates per current
upstream reviewers' opinions.

[Other Info]

Nominated for linux/mantic and oem-6.5/jammy as they're for MTL.

--
V2: no change resubmit with additional details to the current
upstream status of Intel IPU6 drivers.
--
Hao Yao (1):
  UBUNTU: SAUCE: platform/x86: int3472: Add handshake GPIO function

You-Sheng Yang (1):
  UBUNTU: SAUCE: iommu: intel-ipu: use IOMMU passthrough mode for Intel
    IPUs on Meteor Lake

 drivers/iommu/intel/iommu.c                   | 1 +
 drivers/platform/x86/intel/int3472/common.h   | 1 +
 drivers/platform/x86/intel/int3472/discrete.c | 5 +++++
 3 files changed, 7 insertions(+)

Comments

Stefan Bader Oct. 26, 2023, 9:02 a.m. UTC | #1
On 25.10.23 18:06, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2031412
> 
> [Impact]
> 
> Need kernel driver fixes for int3472/iommu for Intel IPU6 platform on MTL.
> 
> [Fix]
> 
> Two fixes in need. One, we need IOMMU passthrough for MTL platform. The other,
> fix is for handshake pin support for Lattice MIPI aggregator.
> 
> The Intel IPU6 camera drivers are not yet all upstreamed yet. So far
> Intel VSC, LJCA (the previous MIPI aggregator for ADL/RPL platforms) are
> in v6.6 already, and IPU6 ISYS is under upstream review. More components
> to come according to Intel.
> 
> These two fixes are therefore for related components for not-yet fully
> upstreamed IPU6 as needed for out-of-tree dkms drivers.
> 
> [Test Case]
> 
> ```
> $ sudo dmesg | grep "Passthrough IOMMU for integrated Intel IPU"
> $ sudo dmesg | grep int3472
> # should have no "int3472-discrete INT3472:0c: GPIO type 0x12 unknown; the sensor may not work"
> ```
> 
> [Where problems could occur]
> 
> IOMMU Passthrough as necessary to enable IPU6 on Intel platforms, and it has
> been patching a few generations e.g. Bug 1989041 for Raptor Lake, Bug 1958004
> for TGL and ADL. As IPU is not an external facing device which is not risky.
> 
> For INT3472, the proposed patch might receive further updates per current
> upstream reviewers' opinions.
> 
> [Other Info]
> 
> Nominated for linux/mantic and oem-6.5/jammy as they're for MTL.
> 
> --
> V2: no change resubmit with additional details to the current
> upstream status of Intel IPU6 drivers.
> --
> Hao Yao (1):
>    UBUNTU: SAUCE: platform/x86: int3472: Add handshake GPIO function
> 
> You-Sheng Yang (1):
>    UBUNTU: SAUCE: iommu: intel-ipu: use IOMMU passthrough mode for Intel
>      IPUs on Meteor Lake
> 
>   drivers/iommu/intel/iommu.c                   | 1 +
>   drivers/platform/x86/intel/int3472/common.h   | 1 +
>   drivers/platform/x86/intel/int3472/discrete.c | 5 +++++
>   3 files changed, 7 insertions(+)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Roxana Nicolescu Oct. 26, 2023, 10:58 a.m. UTC | #2
On 25/10/2023 18:06, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2031412
>
> [Impact]
>
> Need kernel driver fixes for int3472/iommu for Intel IPU6 platform on MTL.
>
> [Fix]
>
> Two fixes in need. One, we need IOMMU passthrough for MTL platform. The other,
> fix is for handshake pin support for Lattice MIPI aggregator.
>
> The Intel IPU6 camera drivers are not yet all upstreamed yet. So far
> Intel VSC, LJCA (the previous MIPI aggregator for ADL/RPL platforms) are
> in v6.6 already, and IPU6 ISYS is under upstream review. More components
> to come according to Intel.
>
> These two fixes are therefore for related components for not-yet fully
> upstreamed IPU6 as needed for out-of-tree dkms drivers.
>
> [Test Case]
>
> ```
> $ sudo dmesg | grep "Passthrough IOMMU for integrated Intel IPU"
> $ sudo dmesg | grep int3472
> # should have no "int3472-discrete INT3472:0c: GPIO type 0x12 unknown; the sensor may not work"
> ```
>
> [Where problems could occur]
>
> IOMMU Passthrough as necessary to enable IPU6 on Intel platforms, and it has
> been patching a few generations e.g. Bug 1989041 for Raptor Lake, Bug 1958004
> for TGL and ADL. As IPU is not an external facing device which is not risky.
>
> For INT3472, the proposed patch might receive further updates per current
> upstream reviewers' opinions.
>
> [Other Info]
>
> Nominated for linux/mantic and oem-6.5/jammy as they're for MTL.
>
> --
> V2: no change resubmit with additional details to the current
> upstream status of Intel IPU6 drivers.
> --
> Hao Yao (1):
>    UBUNTU: SAUCE: platform/x86: int3472: Add handshake GPIO function
>
> You-Sheng Yang (1):
>    UBUNTU: SAUCE: iommu: intel-ipu: use IOMMU passthrough mode for Intel
>      IPUs on Meteor Lake
>
>   drivers/iommu/intel/iommu.c                   | 1 +
>   drivers/platform/x86/intel/int3472/common.h   | 1 +
>   drivers/platform/x86/intel/int3472/discrete.c | 5 +++++
>   3 files changed, 7 insertions(+)
>
Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
Roxana Nicolescu Oct. 27, 2023, 12:10 p.m. UTC | #3
On 25/10/2023 18:06, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2031412
>
> [Impact]
>
> Need kernel driver fixes for int3472/iommu for Intel IPU6 platform on MTL.
>
> [Fix]
>
> Two fixes in need. One, we need IOMMU passthrough for MTL platform. The other,
> fix is for handshake pin support for Lattice MIPI aggregator.
>
> The Intel IPU6 camera drivers are not yet all upstreamed yet. So far
> Intel VSC, LJCA (the previous MIPI aggregator for ADL/RPL platforms) are
> in v6.6 already, and IPU6 ISYS is under upstream review. More components
> to come according to Intel.
>
> These two fixes are therefore for related components for not-yet fully
> upstreamed IPU6 as needed for out-of-tree dkms drivers.
>
> [Test Case]
>
> ```
> $ sudo dmesg | grep "Passthrough IOMMU for integrated Intel IPU"
> $ sudo dmesg | grep int3472
> # should have no "int3472-discrete INT3472:0c: GPIO type 0x12 unknown; the sensor may not work"
> ```
>
> [Where problems could occur]
>
> IOMMU Passthrough as necessary to enable IPU6 on Intel platforms, and it has
> been patching a few generations e.g. Bug 1989041 for Raptor Lake, Bug 1958004
> for TGL and ADL. As IPU is not an external facing device which is not risky.
>
> For INT3472, the proposed patch might receive further updates per current
> upstream reviewers' opinions.
>
> [Other Info]
>
> Nominated for linux/mantic and oem-6.5/jammy as they're for MTL.
>
> --
> V2: no change resubmit with additional details to the current
> upstream status of Intel IPU6 drivers.
> --
> Hao Yao (1):
>    UBUNTU: SAUCE: platform/x86: int3472: Add handshake GPIO function
>
> You-Sheng Yang (1):
>    UBUNTU: SAUCE: iommu: intel-ipu: use IOMMU passthrough mode for Intel
>      IPUs on Meteor Lake
>
>   drivers/iommu/intel/iommu.c                   | 1 +
>   drivers/platform/x86/intel/int3472/common.h   | 1 +
>   drivers/platform/x86/intel/int3472/discrete.c | 5 +++++
>   3 files changed, 7 insertions(+)
>
Applied to mantic:master-next. Thanks!

Roxana