From patchwork Fri Sep 22 17:09:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Reed X-Patchwork-Id: 1838385 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Rsdzk3GCYz1yq5 for ; Sat, 23 Sep 2023 03:09:37 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qjjee-0005gB-6c; Fri, 22 Sep 2023 17:09:24 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qjjeX-0005fR-OR for kernel-team@lists.ubuntu.com; Fri, 22 Sep 2023 17:09:19 +0000 Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id BEEA53F1D9 for ; Fri, 22 Sep 2023 17:09:15 +0000 (UTC) Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-1bf2e81ce17so3717466fac.0 for ; Fri, 22 Sep 2023 10:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695402554; x=1696007354; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JCF+MMPEq24xb7iuyWvuspp5765y3uJ5jX9SW+/G3fU=; b=Wgbu7tQSk8mqBwHyweVUjggF4J3NPuzFa38ZqPPWe5uz/Na2tPaQKMa2825CtCAFRC q+e62SZ/LgTD6r6AlMC0/HkT6h0jfWvA6ovXlal2ci7DW5Q9TO4cs4aqpJxScP3bC+BA 4YqODic/w1IExSvlH5CnB8fAxr9H5pU9Zt0jBqUaoaTj7dxRhk7kQDB9SSP9J22vKdmf KPEeKNQmwmmHo67QZoGzXPrs6EECv/3SHJInfn7lnFCcf10dxMumZbZ/NV+r99jAr1s3 c1G4WRyyQRxFFgc3ixJJOWapRTX1h4Tb5JbR172wyO9uavyFH01A71Ix0xrZ2NQiM3+C zACw== X-Gm-Message-State: AOJu0YxkUYXOQdmEkKhFQxcYYK8hRv1J41GzJ0KbCKAPQIhEeMg8AOQK +mfPPmR3xxY/jM3HGV+7gHC/V9k+1Py40Y+8b0K5RGZqAjbYoCvaGAu6zyJ0QKJOZxQg+a/h/BY s0EKfI1ws4RxsudmeufRADm8fd5MgxoWIrdRgUqfgT4qsf6Wcjg== X-Received: by 2002:a05:6870:3329:b0:1bb:b13c:7fa4 with SMTP id x41-20020a056870332900b001bbb13c7fa4mr48649oae.26.1695402554524; Fri, 22 Sep 2023 10:09:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHKbAu18Rc/yQ2DyqL/TljF91bRsdCGJzOaeDfBmiAk2hPRI1qMeSeu/Jnk0IIl/XsvRDkXw== X-Received: by 2002:a05:6870:3329:b0:1bb:b13c:7fa4 with SMTP id x41-20020a056870332900b001bbb13c7fa4mr48636oae.26.1695402554294; Fri, 22 Sep 2023 10:09:14 -0700 (PDT) Received: from localhost ([2600:1700:1d0:5e50:10ea:d1bb:4a56:accb]) by smtp.gmail.com with ESMTPSA id dt44-20020a0568705aac00b001d695b678f9sm1111597oab.35.2023.09.22.10.09.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 10:09:14 -0700 (PDT) From: Michael Reed To: kernel-team@lists.ubuntu.com Subject: [SRU J][PATCH 0/2] Duplicate Device_dax ids Created and hence Probing is Failing Date: Fri, 22 Sep 2023 12:09:08 -0500 Message-Id: <20230922170910.12844-1-michael.reed@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Michael Reed [Impact] Description of problem: Observed device_dax related probe errors in dmesg when HBM CPU is set to flat mode. Duplicate device_dax ids were created and hence probing is failing. How reproducible: Frequently Version-Release Release: 22.04.2, 22.10 [Test Case] Steps to Reproduce: 1. Set HBM cpu to flat mode in memory settings in BIOS. 2. Boot to the OS. 3. Perform OS warm boot cycle test. 4. Observe the dax2.0/dax3.0/dax4.0/dax5.0 probe error. Actual results: Observed device_dax related errors in dmesg, device Dax is creating dummy/duplicate devices and probe failing. Expected results: Dummy/duplicate devices should not create. [Fix] Upstream Fix https://lore.kernel.org/linux-mm/166890823379.4183293.15333502171004313377.stgit@dwillia2-xfh.jf.intel.com/T/ By default this is enabled, but it is causing an issue reconfiguring device dax memory, thus it is being disabled. Disable CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE Set CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=N [Where problems could occur] [Other Info] Dan Williams (1): device-dax: Fix duplicate 'hmem' device registration Michael Reed (1): UBUNTU: [Config] CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE debian.master/config/annotations | 2 +- drivers/dax/hmem/device.c | 26 ++++++++++++++++---------- 2 files changed, 17 insertions(+), 11 deletions(-)