mbox series

[SRU,J/L/M,0/1] Fix unstable audio at low levels on Thinkpad P1G4

Message ID 20230922114314.215587-1-aaron.ma@canonical.com
Headers show
Series Fix unstable audio at low levels on Thinkpad P1G4 | expand

Message

Aaron Ma Sept. 22, 2023, 11:43 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2037077

[Impact]
The audio at low levels is not stable with fluctuating levels.

[Fix]
Forcibly assign NID 0x03 to HP while NID 0x02 to SPK.

[Test]
Tested on hardware, the audio output is OK at all levels.

[Where problems could occur]
It may break audio output on Thinkpad P1G4/5.

Kailang Yang (1):
  ALSA: hda/realtek - ALC287 I2S speaker platform support

 sound/pci/hda/patch_realtek.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Tim Gardner Sept. 22, 2023, 2:57 p.m. UTC | #1 
On 9/22/23 5:43 AM, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2037077
> 
> [Impact]
> The audio at low levels is not stable with fluctuating levels.
> 
> [Fix]
> Forcibly assign NID 0x03 to HP while NID 0x02 to SPK.
> 
> [Test]
> Tested on hardware, the audio output is OK at all levels.
> 
> [Where problems could occur]
> It may break audio output on Thinkpad P1G4/5.
> 
> Kailang Yang (1):
>    ALSA: hda/realtek - ALC287 I2S speaker platform support
> 
>   sound/pci/hda/patch_realtek.c | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Roxana Nicolescu Sept. 28, 2023, 8:16 a.m. UTC | #2 
On 22/09/2023 13:43, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2037077
>
> [Impact]
> The audio at low levels is not stable with fluctuating levels.
>
> [Fix]
> Forcibly assign NID 0x03 to HP while NID 0x02 to SPK.
>
> [Test]
> Tested on hardware, the audio output is OK at all levels.
>
> [Where problems could occur]
> It may break audio output on Thinkpad P1G4/5.
>
> Kailang Yang (1):
>    ALSA: hda/realtek - ALC287 I2S speaker platform support
>
>   sound/pci/hda/patch_realtek.c | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
>
Acked-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
Roxana Nicolescu Sept. 29, 2023, 9:10 a.m. UTC | #3 
On 22/09/2023 13:43, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/2037077
>
> [Impact]
> The audio at low levels is not stable with fluctuating levels.
>
> [Fix]
> Forcibly assign NID 0x03 to HP while NID 0x02 to SPK.
>
> [Test]
> Tested on hardware, the audio output is OK at all levels.
>
> [Where problems could occur]
> It may break audio output on Thinkpad P1G4/5.
>
> Kailang Yang (1):
>    ALSA: hda/realtek - ALC287 I2S speaker platform support
>
>   sound/pci/hda/patch_realtek.c | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
>
Applied to jammy,lunar,mantic:master-next. Thanks!

Roxana