mbox series

[0/1,jammy:linux-intel-iot-realtime] Revert: igc: Disable PTM sequences when interface goes down

Message ID 20230913164736.2684780-1-philip.cox@canonical.com
Headers show
Series Revert: igc: Disable PTM sequences when interface goes down | expand

Message

Philip Cox Sept. 13, 2023, 4:47 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2035361

SRU Justification:

[Impact]
The j:linux-intel-iot-realtime kernel is failing to sync the system clock and the PTP hardware clock.

[Fix]
The fix is reverting a patch that was reverted in the Intel upstream kernel.

[Test Plan]
Intel has provided the fix, which they have tested, and I have tested as well.

[Where problems could occur]
There should be limited impact as this is reverting a workaround that is no longer needed.  The scope of the actual change is fairly narrow as well, as it should only be executed when the hardware cross timestamping feature of TSN enabled NICs are used.

Philip Cox (1):
  Revert "igc: Disable PTM sequences when interface goes down"

 drivers/net/ethernet/intel/igc/igc_ptp.c | 50 ++++++++++--------------
 1 file changed, 21 insertions(+), 29 deletions(-)

Comments

Tim Gardner Sept. 13, 2023, 4:53 p.m. UTC | #1 
On 9/13/23 10:47 AM, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2035361
> 
> SRU Justification:
> 
> [Impact]
> The j:linux-intel-iot-realtime kernel is failing to sync the system clock and the PTP hardware clock.
> 
> [Fix]
> The fix is reverting a patch that was reverted in the Intel upstream kernel.
> 
> [Test Plan]
> Intel has provided the fix, which they have tested, and I have tested as well.
> 
> [Where problems could occur]
> There should be limited impact as this is reverting a workaround that is no longer needed.  The scope of the actual change is fairly narrow as well, as it should only be executed when the hardware cross timestamping feature of TSN enabled NICs are used.
> 
> Philip Cox (1):
>    Revert "igc: Disable PTM sequences when interface goes down"
> 
>   drivers/net/ethernet/intel/igc/igc_ptp.c | 50 ++++++++++--------------
>   1 file changed, 21 insertions(+), 29 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Philip Cox Sept. 20, 2023, 1:52 p.m. UTC | #2 
On Wed, Sep 13, 2023 at 12:50 PM Philip Cox <philip.cox@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2035361
>
> SRU Justification:
>
> [Impact]
> The j:linux-intel-iot-realtime kernel is failing to sync the system clock
> and the PTP hardware clock.
>
> [Fix]
> The fix is reverting a patch that was reverted in the Intel upstream
> kernel.
>
> [Test Plan]
> Intel has provided the fix, which they have tested, and I have tested as
> well.
>
> [Where problems could occur]
> There should be limited impact as this is reverting a workaround that is
> no longer needed.  The scope of the actual change is fairly narrow as well,
> as it should only be executed when the hardware cross timestamping feature
> of TSN enabled NICs are used.
>
> Philip Cox (1):
>   Revert "igc: Disable PTM sequences when interface goes down"
>
>  drivers/net/ethernet/intel/igc/igc_ptp.c | 50 ++++++++++--------------
>  1 file changed, 21 insertions(+), 29 deletions(-)
>
> --
> 2.34.1
>
>