From patchwork Wed Sep 13 10:03:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1833462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RlwyR5wCgz1yh6 for ; Wed, 13 Sep 2023 20:03:43 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qgMiQ-0002Ch-Vc; Wed, 13 Sep 2023 10:03:23 +0000 Received: from mail-pg1-f179.google.com ([209.85.215.179]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qgMiM-0002CN-GU for kernel-team@lists.ubuntu.com; Wed, 13 Sep 2023 10:03:18 +0000 Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-573c62b3cd2so4891888a12.3 for ; Wed, 13 Sep 2023 03:03:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694599396; x=1695204196; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8eWo4Ioy+JmFF/3SqyiQFAySlbrsusADhbncswbNH3M=; b=ehMOk9Gq0Thhcx5EuUxHsGQSIXNtQMyK1Il19D/PxISvPNYIj0WeaghKROv7N/lgnC midAV2VtkrcudNmISOuLdaKcsSnxxOOCEH/4a1cEbDc2kzXdBmS4YB/Xvdkh7YJKv5dW G5sqvSg98UCIcVquz7dXiHZj/NGj6qaVFvcYof9789feHLpI9D3f/ysyDqyID203ZzrJ O+UkBEguX4XpAcL82OlaifT5YpbFu0+5AMlTtCfISIA2nqMLPEA3hd4Ncshh2daUchDv i9KULLmnBtfIOSlVsh/EoCyqDNDPbZLRhBbkuwzjRt1gB22dquHfMtu0C1MUWP/T4qb7 R7qw== X-Gm-Message-State: AOJu0Yx796Ty/rI2xmqy3bLpFuMt+hGIVSEOJE+Z6s/ZzXT3jRwCFuQp x3120abjvyrIUpESEjT02C11MyhKEMZSiA== X-Google-Smtp-Source: AGHT+IFSWTOuXwlEwlMBDKNKjnS8kM6jHftpZc6sGYrRHQ9q7qzKnu3uySgFTOztuLuptP5jJsKN2g== X-Received: by 2002:a17:90b:4c11:b0:273:fa72:ba83 with SMTP id na17-20020a17090b4c1100b00273fa72ba83mr1751917pjb.47.1694599396248; Wed, 13 Sep 2023 03:03:16 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id x90-20020a17090a6c6300b002693505391csm1159131pjj.37.2023.09.13.03.03.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 03:03:15 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1][SRU][M] Make backlight module auto detect dell_uart_backlight Date: Wed, 13 Sep 2023 18:03:12 +0800 Message-Id: <20230913100313.200336-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.179; envelope-from=acelan@gmail.com; helo=mail-pg1-f179.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://bugs.launchpad.net/bugs/2008882 [Impact] There are acpi_video* sysfs backlight interface in the system which are not working. For Dell AIO platforms, we use dell_uart_backlight to control the display brightness. The old way to fix this is to unregister acpi backlight interfaces in the backlight driver, but it may lead to some issues and the unregister function has been removed since v6.1-rc1 77ab9d4d44cd ("ACPI: video: Remove acpi_video_set_dmi_backlight_type()") [Fix] The new way to do this is to collect all the quirk and auto detection method in video_detect.c I added an auto detection for the Dell AIO platoform to the driver which should do the same thing as the old way. [Test] Verified on the Dell AIO platform and confirmed there is only on dell_uart_backlight in the sysfs, and no acpi_video* interface. [Where problems could occur] There should be no regression potential, it uses different way to do the same thing, should be pretty safe. [Other Info] dell-uart-backlight is still a Ubuntu only driver, so submit the patch as UBUNTU: SAUCE: patch. Chia-Lin Kao (AceLan) (1): UBUNTU: SAUCE: ACPI: video: Dell AIO UART backlight detection drivers/acpi/video_detect.c | 5 +++++ 1 file changed, 5 insertions(+)