mbox series

[kernel-snaps-uc22/intel-iotg,0/1] missing firmware-sof package in kernel snap

Message ID 20230822083843.1401041-1-jianhui.lee@canonical.com
Headers show
Series missing firmware-sof package in kernel snap | expand

Message

Jian Hui Lee Aug. 22, 2023, 8:38 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2032607

[Impact]
missing firmware-sof binaries in intel-iotg kernel snap

[Fix]
the firmware binaries for soundwire are in another package(firmware-sof) in jammy, so it needs to be included while building kernel snap.

[Test]
1. snapcraft compile test
2. check the required firmware binaries are in the kernel snap

[Where problems could occur]
low. only the binary files are added.


----------------------------------------------------------------
Jian Hui Lee (1):
  snapcraft.yaml: add firmware-sof for stage package

 snapcraft.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dimitri John Ledkov Aug. 25, 2023, 1:14 p.m. UTC | #1 
Acked-by: Dimitri John Ledkov <dimitri.ledkov@canonical.com>

Please apply and retrigger snap build in launchpad. This is small
enough change, which is safe to land as is.

On Tue, 22 Aug 2023 at 09:39, Jian Hui Lee <jianhui.lee@canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2032607
>
> [Impact]
> missing firmware-sof binaries in intel-iotg kernel snap
>
> [Fix]
> the firmware binaries for soundwire are in another package(firmware-sof) in jammy, so it needs to be included while building kernel snap.
>
> [Test]
> 1. snapcraft compile test
> 2. check the required firmware binaries are in the kernel snap
>
> [Where problems could occur]
> low. only the binary files are added.
>
>
> ----------------------------------------------------------------
> Jian Hui Lee (1):
>   snapcraft.yaml: add firmware-sof for stage package
>
>  snapcraft.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.39.2
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Philip Cox Aug. 25, 2023, 7:53 p.m. UTC | #2 
On Tue, 2023-08-22 at 16:38 +0800, Jian Hui Lee wrote:
> BugLink: https://bugs.launchpad.net/bugs/2032607
> 
> [Impact]
> missing firmware-sof binaries in intel-iotg kernel snap
> 
> [Fix]
> the firmware binaries for soundwire are in another package(firmware-
> sof) in jammy, so it needs to be included while building kernel snap.
> 
> [Test]
> 1. snapcraft compile test
> 2. check the required firmware binaries are in the kernel snap
> 
> [Where problems could occur]
> low. only the binary files are added.
> 
> 
> ----------------------------------------------------------------
> Jian Hui Lee (1):
>   snapcraft.yaml: add firmware-sof for stage package
> 
>  snapcraft.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> -- 
> 2.39.2
> 
>
Stefan Bader Aug. 28, 2023, 9:29 a.m. UTC | #3 
On 22.08.23 10:38, Jian Hui Lee wrote:
> BugLink: https://bugs.launchpad.net/bugs/2032607
> 
> [Impact]
> missing firmware-sof binaries in intel-iotg kernel snap
> 
> [Fix]
> the firmware binaries for soundwire are in another package(firmware-sof) in jammy, so it needs to be included while building kernel snap.
> 
> [Test]
> 1. snapcraft compile test
> 2. check the required firmware binaries are in the kernel snap
> 
> [Where problems could occur]
> low. only the binary files are added.
> 
> 
> ----------------------------------------------------------------
> Jian Hui Lee (1):
>    snapcraft.yaml: add firmware-sof for stage package
> 
>   snapcraft.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 

Applied to kernel-snaps-uc22/intel-iotg (by Jian Hui). Thanks.

-Stefan