From patchwork Thu Jul 20 20:37:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 1810618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=W6E0C6ij; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R6Pdt2Dk6z20FK for ; Fri, 21 Jul 2023 06:38:09 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1qMaPQ-0005ED-4U; Thu, 20 Jul 2023 20:38:00 +0000 Received: from mail-sn1nam02on2083.outbound.protection.outlook.com ([40.107.96.83] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1qMaPO-0005E5-Qh for kernel-team@lists.ubuntu.com; Thu, 20 Jul 2023 20:37:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O162SnAAVJBxm+dq1cBayk4M9st2IWxv+7I1mCllqQTtJMEhDaA5YfhnfcXgOHaFyC7n1Squ/hOLNmA9oqprCW0/8XsOwI1AOOAQfr4yQt04QzZZ/C9GsTJ3Gt0kPdSjB89f1JNSu/LotM1sG/BdZMCzfnvfRDkMcqVx35GFkZSAd4vaCWOGXi4GsKQu1HESZpjuo9AUEqiK4hn9ADuF+TxccsEA/Y0I7G+0lgw83qbgzHFaOqxtYl9z61klj/C1Sre1SRCl3wOeCZvWym0+0dffI1CaCALe4CA7bkXQ/yWTs0DVAO1LnhtX2AwsSIHb/ySzyY/DZhBC6fpfkC9h0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3nD/OuAHP+a60uyVK3WhiAfszl6GRuZHUI11Ee6SN5A=; b=exL+sYBpA6yX9AlSubwfep/6Re59M5nic/+HznSDxnWHDD3bKFvOp/vT1wtn/UBriUjoS+GEnOz45IQ2l0EKO6uxftbXxXQeLHNPA1aHeOAOKoEsvVEyhPJKpahXI7jxamCIP0ep/60dpzXlrm1H6VBic9v92TMrEBwDbOHMbR0vVPGV6oTcxAzB+Te1FVkVrp6ErB6EuIMac9q8GFUL3Q7mNixrCjVMEKjMTTx+qoqyIJE6H6UPlaxjjIBKjYxVw/SaHJBclt/3fCrZEiVQrbtV+WXrmLSIuZ6DkqjxVVFQuZqQn2rHy6Ds1NEgELJPFvcwReiGcA6jf/Q+HCiNZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3nD/OuAHP+a60uyVK3WhiAfszl6GRuZHUI11Ee6SN5A=; b=W6E0C6ijey9+Xal+PSzy155wH6NKsN6R/qZfzj23ErvSUGKq8LgWIvYUe9VOOLwIxEs2wDV7zDP/UVYj3AYLDuPQQp7hSM0E4bG+vjtcCRjV0gsbNBw2n9oicZaj3boH0DLDncrzriMdo9m5MeL3mMV3HTRH+khTe7OIdZcU7zRuClSjT2NrOl0IWXjvx0W/qpi8+Rh90oXAoh2rCF2v80RwtHV30LVRD+1rgSctkXgH8a8xxDXgcrfx1Tjq02kgliJLkS0PEXHqBtrZ8NDpJpjz7b5qX/+uCsjR2Cme7xUnrF5Mp2Uho80ZjOOYVo2xl7fHHMS40a+4ohBOaGuGkg== Received: from MW3PR05CA0029.namprd05.prod.outlook.com (2603:10b6:303:2b::34) by CY5PR12MB6551.namprd12.prod.outlook.com (2603:10b6:930:41::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Thu, 20 Jul 2023 20:37:56 +0000 Received: from CO1NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::99) by MW3PR05CA0029.outlook.office365.com (2603:10b6:303:2b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.15 via Frontend Transport; Thu, 20 Jul 2023 20:37:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT027.mail.protection.outlook.com (10.13.174.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28 via Frontend Transport; Thu, 20 Jul 2023 20:37:55 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 20 Jul 2023 13:37:41 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 20 Jul 2023 13:37:40 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 20 Jul 2023 13:37:40 -0700 From: Asmaa Mnebhi To: Subject: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-bootctl: Fix kernel panic due to buffer overflow Date: Thu, 20 Jul 2023 16:37:36 -0400 Message-ID: <20230720203737.30469-1-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT027:EE_|CY5PR12MB6551:EE_ X-MS-Office365-Filtering-Correlation-Id: 27ce9139-53d5-47c1-83a1-08db896132bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P3L8jPEVpaL3XKsiRA+8gTRPGVDORN0IWqJ5xVavNi+39KG58q7MXRdlTgpM0AFwOR+EgjlbnRU5zgYvLYGBvsF/6hoDwV1dYwlmZtVinFiSkVvnKrI6Ka9I0rI/ztaeklsl9DSV+7P6OVZrwHpeatHFXffgyJ1LrhUMBiZHyjEmdPYFeKXTc9pdxWZLmJLeWV4mjHRtKejMLjXlvAa7ynzkmIZ/Z3GgdUbnedWhsyW+tPUAJELTIzZlrmPmikZQiwh9Y7p099LmH2DYt2d2nH4v/0Em9cx6O1g+dYnBdSa0dSFpsXqDOzxLtM7AiI/vd5vVU6JsDaOrCufFvj2NatamNF0sxnpr2KZCrEEnjj0DTV1G8c+0IAEZPhd3C0MaXhovsE4t9QQ1WRZQ4DPJSQDNSshf6V6EISlrQbjMO362+FYqPYjVNDAGPGt0a/8ISnKfjx/4dpgo71pG8Hym3OV236XcxeOGqXLyNc1lU8NP/Ghs+PEQkMgcdohTKnXaa9sKNZIeNIOsy7KxRLwneRtxTUKKyQhGxapyQlyWWloRkWHXxQGg5PGkbxBPC9zYF2vQVlioYlGrVou4oegsMTuUaiAz2FxWXZymX8aGzPBp5UhBgL8X08aMLiJMHr0MdZ1BelcrjFlmd/+D+XM7dOn+LRt3wyUw4rFZlcGfNJXa1IGW0qG6rheLBpOWyV9D+hTjucuRJf+0vOJoYXYEAhXM0aFByYBwKJrgGRl6JyI3ZS+5zNAABh4fqHKFXsUTn0dyIa6tDCbnNS+2jhSi7a7aZESOf8c2wJOZ1ZoCzDg= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(376002)(396003)(39860400002)(82310400008)(451199021)(36840700001)(46966006)(40470700004)(336012)(478600001)(7696005)(6666004)(54906003)(966005)(83380400001)(426003)(47076005)(36860700001)(36756003)(86362001)(40460700003)(40480700001)(2906002)(4744005)(186003)(1076003)(107886003)(26005)(82740400003)(356005)(7636003)(4326008)(70586007)(41300700001)(70206006)(316002)(6916009)(8936002)(8676002)(5660300002)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 20:37:55.7764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27ce9139-53d5-47c1-83a1-08db896132bd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6551 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: asmaa@nvidia.com, davthompson@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2028309 SRU Justification: [Impact] Running the following LTP (linux-test-project) script, causes a kernel panic and a reboot of the DPU: ltp/testcases/bin/read_all -d /sys -q -r 10 The above test reads all directory and files under /sys. Reading the sysfs entry "large_icm" causes the kernel panic due to a garbage value returned via i2c read. That garbage value causes a buffer overflow in sprintf. [Fix] * Replace sprintf with snprintf. And also add missing lock and increase the buffer size to PAGE_SIZE. [Test Case] * Run from linux: ltp/testcases/bin/read_all -d /sys -q -r 10 [Regression Potential] * no known regression Acked-by: Bartlomiej Zolnierkiewicz Acked-by: Tim Gardner