mbox series

[SRU,J/K,V2,0/2] Backport request for hpwdt from upstream 6.1 to Jammy

Message ID 20230405194419.13535-1-michael.reed@canonical.com
Headers show
Series Backport request for hpwdt from upstream 6.1 to Jammy | expand

Message

Michael Reed April 5, 2023, 7:44 p.m. UTC
From: Michael Reed <Michael.Reed@canonical.com>

SRU Justification:

BugLink: https://bugs.launchpad.net/bugs/2008751

[Impact]

Please pick up the latest hpwdt from the upstream 6.1 kernel for Jammy. This version enables hpwdt on RL300 aarch64.

[Fix]
ed835d8171fc watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING

891862d5ba11 watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.

[Test Plan]
Boot system with the hpwdt enabled on an arm64 system

[Where Problems Could Occur]

Regression Risk is Low

[Other Info]
Jammy
https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_2008751_hpwdt

Kinetic
https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/kinetic/+ref/lp_2008751_hpwdt_kinetic

Jerry Hoemann (2):
  watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.
  watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING

 debian.master/config/annotations | 2 +-
 drivers/watchdog/Kconfig         | 4 ++--
 drivers/watchdog/hpwdt.c         | 2 ++
 3 files changed, 5 insertions(+), 3 deletions(-)

Comments

Tim Gardner April 6, 2023, 1:55 p.m. UTC | #1
On 4/5/23 1:44 PM, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
> 
> SRU Justification:
> 
> BugLink: https://bugs.launchpad.net/bugs/2008751
> 
> [Impact]
> 
> Please pick up the latest hpwdt from the upstream 6.1 kernel for Jammy. This version enables hpwdt on RL300 aarch64.
> 
> [Fix]
> ed835d8171fc watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING
> 
> 891862d5ba11 watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.
> 
> [Test Plan]
> Boot system with the hpwdt enabled on an arm64 system
> 
> [Where Problems Could Occur]
> 
> Regression Risk is Low
> 
> [Other Info]
> Jammy
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_2008751_hpwdt
> 
> Kinetic
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/kinetic/+ref/lp_2008751_hpwdt_kinetic
> 
> Jerry Hoemann (2):
>    watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.
>    watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING
> 
>   debian.master/config/annotations | 2 +-
>   drivers/watchdog/Kconfig         | 4 ++--
>   drivers/watchdog/hpwdt.c         | 2 ++
>   3 files changed, 5 insertions(+), 3 deletions(-)
> 

Split patch 1 into 2 patches, i.e., separate the annotations change from 
the upstream commit 891862d5ba11da739ac796221ff64e4ccf5a275f. I realize 
that will make bisecting difficult, but it also makes for a cleaner history.
Roxana Nicolescu April 19, 2023, 8:55 a.m. UTC | #2
On 05/04/2023 21:44, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
>
> SRU Justification:
>
> BugLink: https://bugs.launchpad.net/bugs/2008751
>
> [Impact]
>
> Please pick up the latest hpwdt from the upstream 6.1 kernel for Jammy. This version enables hpwdt on RL300 aarch64.
>
> [Fix]
> ed835d8171fc watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING
>
> 891862d5ba11 watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.
>
> [Test Plan]
> Boot system with the hpwdt enabled on an arm64 system
>
> [Where Problems Could Occur]
>
> Regression Risk is Low
>
> [Other Info]
> Jammy
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_2008751_hpwdt
>
> Kinetic
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/kinetic/+ref/lp_2008751_hpwdt_kinetic
>
> Jerry Hoemann (2):
>    watchdog/hpwdt: Enable HP_WATCHDOG for ARM64 systems.
>    watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING
>
>   debian.master/config/annotations | 2 +-
>   drivers/watchdog/Kconfig         | 4 ++--
>   drivers/watchdog/hpwdt.c         | 2 ++
>   3 files changed, 5 insertions(+), 3 deletions(-)
>
Hi,

Both commits looks good, but I would split the first one as I suggested 
in the reply there.

Roxana