mbox series

[SRU,jammy,0/1] Kernel crash during Mellanox performance testing

Message ID 20230403150905.2211962-1-john.cabaj@canonical.com
Headers show
Series Kernel crash during Mellanox performance testing | expand

Message

John Cabaj April 3, 2023, 3:09 p.m. UTC 
[Impact]

* Fixing issue of early decrement in if condition rather than as a result of if condition. This caused a null pointer crash during performance testing.

[Fix]

* Clean cherry-pick from upstream

[Test Case]

* Compile tested
* Boot tested
* Performance tested over weekend

[Where things could go wrong]

* Regression risk is low, localized fix, purely fixes incorrect logic

Mark Bloch (1):
  net/mlx5: fs, refactor software deletion rule

 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Tim Gardner April 3, 2023, 5:43 p.m. UTC | #1 
On 4/3/23 9:09 AM, John Cabaj wrote:
> [Impact]
> 
> * Fixing issue of early decrement in if condition rather than as a result of if condition. This caused a null pointer crash during performance testing.
> 
> [Fix]
> 
> * Clean cherry-pick from upstream
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Performance tested over weekend
> 
> [Where things could go wrong]
> 
> * Regression risk is low, localized fix, purely fixes incorrect logic
> 
> Mark Bloch (1):
>    net/mlx5: fs, refactor software deletion rule
> 
>   drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader April 4, 2023, 8:45 a.m. UTC | #2 
On 03.04.23 17:09, John Cabaj wrote:
> [Impact]
> 
> * Fixing issue of early decrement in if condition rather than as a result of if condition. This caused a null pointer crash during performance testing.
> 
> [Fix]
> 
> * Clean cherry-pick from upstream
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Performance tested over weekend
> 
> [Where things could go wrong]
> 
> * Regression risk is low, localized fix, purely fixes incorrect logic
> 
> Mark Bloch (1):
>    net/mlx5: fs, refactor software deletion rule
> 
>   drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader April 6, 2023, 1:45 p.m. UTC | #3 
On 03.04.23 17:09, John Cabaj wrote:
> [Impact]
> 
> * Fixing issue of early decrement in if condition rather than as a result of if condition. This caused a null pointer crash during performance testing.
> 
> [Fix]
> 
> * Clean cherry-pick from upstream
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Performance tested over weekend
> 
> [Where things could go wrong]
> 
> * Regression risk is low, localized fix, purely fixes incorrect logic
> 
> Mark Bloch (1):
>    net/mlx5: fs, refactor software deletion rule
> 
>   drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan