mbox series

[SRU,v2,f:linux-restricted-modules-hwe-5.15/unstable:linux-restricted-modules,0/1] Add lrm autogenerated transitional independent of variants

Message ID 20230330125739.876314-1-tjaalton@ubuntu.com
Headers show
Series Add lrm autogenerated transitional independent of variants | expand

Message

Timo Aaltonen March 30, 2023, 12:57 p.m. UTC
From: Timo Aaltonen <timo.aaltonen@canonical.com>


BugLink: https://bugs.launchpad.net/bugs/1991130

Old Note: this patch is supposed to be applied to all lrm packages (or at
least to hwe and generic) but I'm proposing for f:lrm-hwe-5.15 only for
now to fix the transition from f:oem-5.14. If this works well I will
send it again to be applied to other lrm packages.

New Note: added unstable, patch rebased and amended

[Impact]

The kernel lrm packages have a mechanism to auto-generate transitional packages
by adding a line to 'debian/package.config' in the following format

transitional <from> <to> <archs>

Example:

transitional 450-oem-20.04 450-generic amd64

When being processed by 'debian/scripts/generate-rules' the autogenerated
contents are added to 'debian/control.d/transitionals-local'. However, this file
is not included in the final 'debian/control' for packages which does not
contain the default variant '--' (see debian/rules.in). This is intentional to
prevent unwanted transitionals.

However, there are some cases where we want to transition packages to kernels
which are not the default variant in a series (e.g. hwe kernels).

[Fix]

The proposed fix is to add a new command "migrate", which does exactly what
"transitional" does but adding the content to 'debian/control.d/migrate-local'
which would get added to the final 'debian/control' independently of the
source's variants.

[Test Case]

Add "migrate" entries to 'debian/package.config' and check whether they get
added to 'debian/control' even for non default variant packages.

[Where problems could occur]

If not used correctly, unwanted transitionals could be generated causing issues
to the archive. However, this is a new command and should not impact any of the
previously set transitionals and it needs to be explicitly used.


Kleber Sacilotto de Souza (1):
  UBUNTU: [Packaging] add a new migrate autogenerate option

 debian/scripts/generate-rules | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Stefan Bader April 5, 2023, 9:39 a.m. UTC | #1
On 30.03.23 14:57, Timo Aaltonen wrote:
> From: Timo Aaltonen <timo.aaltonen@canonical.com>
> 
> 
> BugLink: https://bugs.launchpad.net/bugs/1991130
> 
> Old Note: this patch is supposed to be applied to all lrm packages (or at
> least to hwe and generic) but I'm proposing for f:lrm-hwe-5.15 only for
> now to fix the transition from f:oem-5.14. If this works well I will
> send it again to be applied to other lrm packages.
> 
> New Note: added unstable, patch rebased and amended
> 
> [Impact]
> 
> The kernel lrm packages have a mechanism to auto-generate transitional packages
> by adding a line to 'debian/package.config' in the following format
> 
> transitional <from> <to> <archs>
> 
> Example:
> 
> transitional 450-oem-20.04 450-generic amd64
> 
> When being processed by 'debian/scripts/generate-rules' the autogenerated
> contents are added to 'debian/control.d/transitionals-local'. However, this file
> is not included in the final 'debian/control' for packages which does not
> contain the default variant '--' (see debian/rules.in). This is intentional to
> prevent unwanted transitionals.
> 
> However, there are some cases where we want to transition packages to kernels
> which are not the default variant in a series (e.g. hwe kernels).
> 
> [Fix]
> 
> The proposed fix is to add a new command "migrate", which does exactly what
> "transitional" does but adding the content to 'debian/control.d/migrate-local'
> which would get added to the final 'debian/control' independently of the
> source's variants.
> 
> [Test Case]
> 
> Add "migrate" entries to 'debian/package.config' and check whether they get
> added to 'debian/control' even for non default variant packages.
> 
> [Where problems could occur]
> 
> If not used correctly, unwanted transitionals could be generated causing issues
> to the archive. However, this is a new command and should not impact any of the
> previously set transitionals and it needs to be explicitly used.
> 
> 
> Kleber Sacilotto de Souza (1):
>    UBUNTU: [Packaging] add a new migrate autogenerate option
> 
>   debian/scripts/generate-rules | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 

Applied to focal:linux-restricted-modules-hwe-5.15/hwe-5.15 as part of 
current cycle crank. Thanks.

-Stefan
Timo Aaltonen May 11, 2023, 10:34 a.m. UTC | #2
Timo Aaltonen kirjoitti 30.3.2023 klo 15.57:
> From: Timo Aaltonen <timo.aaltonen@canonical.com>
> 
> 
> BugLink: https://bugs.launchpad.net/bugs/1991130
> 
> Old Note: this patch is supposed to be applied to all lrm packages (or at
> least to hwe and generic) but I'm proposing for f:lrm-hwe-5.15 only for
> now to fix the transition from f:oem-5.14. If this works well I will
> send it again to be applied to other lrm packages.
> 
> New Note: added unstable, patch rebased and amended
> 
> [Impact]
> 
> The kernel lrm packages have a mechanism to auto-generate transitional packages
> by adding a line to 'debian/package.config' in the following format
> 
> transitional <from> <to> <archs>
> 
> Example:
> 
> transitional 450-oem-20.04 450-generic amd64
> 
> When being processed by 'debian/scripts/generate-rules' the autogenerated
> contents are added to 'debian/control.d/transitionals-local'. However, this file
> is not included in the final 'debian/control' for packages which does not
> contain the default variant '--' (see debian/rules.in). This is intentional to
> prevent unwanted transitionals.
> 
> However, there are some cases where we want to transition packages to kernels
> which are not the default variant in a series (e.g. hwe kernels).
> 
> [Fix]
> 
> The proposed fix is to add a new command "migrate", which does exactly what
> "transitional" does but adding the content to 'debian/control.d/migrate-local'
> which would get added to the final 'debian/control' independently of the
> source's variants.
> 
> [Test Case]
> 
> Add "migrate" entries to 'debian/package.config' and check whether they get
> added to 'debian/control' even for non default variant packages.
> 
> [Where problems could occur]
> 
> If not used correctly, unwanted transitionals could be generated causing issues
> to the archive. However, this is a new command and should not impact any of the
> previously set transitionals and it needs to be explicitly used.
> 
> 
> Kleber Sacilotto de Souza (1):
>    UBUNTU: [Packaging] add a new migrate autogenerate option
> 
>   debian/scripts/generate-rules | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 

I'll send a new version for unstable/mantic that also supports 
NNN-server and -open.