mbox series

[0/9,SRU,L] Lost display on built-in monitor after suspend

Message ID 20230328083246.366669-1-acelan.kao@canonical.com
Headers show
Series Lost display on built-in monitor after suspend | expand

Message

AceLan Kao March 28, 2023, 8:32 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://launchpad.net/bugs/2001599

[Impact]
On some laptops, the eDP blinking slowly after resuming from S3

[Fix]
The series of patches which are in drp-tip(v6.3-rc1) fix the isue
https://patchwork.freedesktop.org/series/110693/

4c0eb35fc103 drm/i915: Improve PPS debugs
ed5509d1d451 drm/i915: Fix whitespace
1e47e035bb73 drm/i915: Print the PPS registers using consistent format
ba21bb24810f drm/i915: Reject unusable power sequencers
d83804f22d85 drm/i915: Extend dual PPS handlind for ICP+
bf38bba3e7d6 drm/i915: Try to use the correct power sequencer intiially on bxt/glk
209074fd5a82 drm/i915: Generalize the PPS vlv_pipe_check() stuff
3f9ffce5765d drm/i915: Do panel VBT init early if the VBT declares an explicit panel type
f70f8153e364 drm/i915: Introduce intel_panel_init_alloc()

[Test]
ODM and I confirmed the issue is fixed after the patches have been applied.

[Where problems may occur]
This series of patches fixes a dedicate issue and change the power
sequence for the eDP panel. eDP panel may stay blank if the rules are wrong.
OEM kernel has carried this series of patches since early Feb., we didn't
get any report about the panel issue.

Ville Syrjälä (9):
  drm/i915: Introduce intel_panel_init_alloc()
  drm/i915: Do panel VBT init early if the VBT declares an explicit
    panel type
  drm/i915: Generalize the PPS vlv_pipe_check() stuff
  drm/i915: Try to use the correct power sequencer intiially on bxt/glk
  drm/i915: Extend dual PPS handlind for ICP+
  drm/i915: Reject unusable power sequencers
  drm/i915: Print the PPS registers using consistent format
  drm/i915: Fix whitespace
  drm/i915: Improve PPS debugs

 drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
 drivers/gpu/drm/i915/display/intel_bios.c     |  56 ++-
 drivers/gpu/drm/i915/display/intel_bios.h     |  11 +-
 .../gpu/drm/i915/display/intel_connector.c    |   2 +-
 .../drm/i915/display/intel_display_types.h    |  24 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  19 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |   4 +-
 drivers/gpu/drm/i915/display/intel_panel.c    |   9 +
 drivers/gpu/drm/i915/display/intel_panel.h    |   1 +
 drivers/gpu/drm/i915/display/intel_pps.c      | 360 +++++++++++++-----
 drivers/gpu/drm/i915/display/intel_pps.h      |   2 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
 drivers/gpu/drm/i915/i915_reg.h               |   1 +
 14 files changed, 364 insertions(+), 131 deletions(-)

Comments

Tim Gardner March 28, 2023, 1:07 p.m. UTC | #1
On 3/28/23 2:32 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2001599
> 
> [Impact]
> On some laptops, the eDP blinking slowly after resuming from S3
> 
> [Fix]
> The series of patches which are in drp-tip(v6.3-rc1) fix the isue
> https://patchwork.freedesktop.org/series/110693/
> 
> 4c0eb35fc103 drm/i915: Improve PPS debugs
> ed5509d1d451 drm/i915: Fix whitespace
> 1e47e035bb73 drm/i915: Print the PPS registers using consistent format
> ba21bb24810f drm/i915: Reject unusable power sequencers
> d83804f22d85 drm/i915: Extend dual PPS handlind for ICP+
> bf38bba3e7d6 drm/i915: Try to use the correct power sequencer intiially on bxt/glk
> 209074fd5a82 drm/i915: Generalize the PPS vlv_pipe_check() stuff
> 3f9ffce5765d drm/i915: Do panel VBT init early if the VBT declares an explicit panel type
> f70f8153e364 drm/i915: Introduce intel_panel_init_alloc()
> 
> [Test]
> ODM and I confirmed the issue is fixed after the patches have been applied.
> 
> [Where problems may occur]
> This series of patches fixes a dedicate issue and change the power
> sequence for the eDP panel. eDP panel may stay blank if the rules are wrong.
> OEM kernel has carried this series of patches since early Feb., we didn't
> get any report about the panel issue.
> 
> Ville Syrjälä (9):
>    drm/i915: Introduce intel_panel_init_alloc()
>    drm/i915: Do panel VBT init early if the VBT declares an explicit
>      panel type
>    drm/i915: Generalize the PPS vlv_pipe_check() stuff
>    drm/i915: Try to use the correct power sequencer intiially on bxt/glk
>    drm/i915: Extend dual PPS handlind for ICP+
>    drm/i915: Reject unusable power sequencers
>    drm/i915: Print the PPS registers using consistent format
>    drm/i915: Fix whitespace
>    drm/i915: Improve PPS debugs
> 
>   drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
>   drivers/gpu/drm/i915/display/intel_bios.c     |  56 ++-
>   drivers/gpu/drm/i915/display/intel_bios.h     |  11 +-
>   .../gpu/drm/i915/display/intel_connector.c    |   2 +-
>   .../drm/i915/display/intel_display_types.h    |  24 +-
>   drivers/gpu/drm/i915/display/intel_dp.c       |  19 +-
>   drivers/gpu/drm/i915/display/intel_lvds.c     |   4 +-
>   drivers/gpu/drm/i915/display/intel_panel.c    |   9 +
>   drivers/gpu/drm/i915/display/intel_panel.h    |   1 +
>   drivers/gpu/drm/i915/display/intel_pps.c      | 360 +++++++++++++-----
>   drivers/gpu/drm/i915/display/intel_pps.h      |   2 +-
>   drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
>   drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
>   drivers/gpu/drm/i915/i915_reg.h               |   1 +
>   14 files changed, 364 insertions(+), 131 deletions(-)
> 


Acked-by: Tim Gardner <tim.gardner@canonical.com>

All clean cherry picks
Cory Todd April 3, 2023, 9:29 p.m. UTC | #2
On Tue, Mar 28, 2023 at 04:32:37PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2001599
> 
> [Impact]
> On some laptops, the eDP blinking slowly after resuming from S3
> 
> [Fix]
> The series of patches which are in drp-tip(v6.3-rc1) fix the isue
> https://patchwork.freedesktop.org/series/110693/
> 
> 4c0eb35fc103 drm/i915: Improve PPS debugs
> ed5509d1d451 drm/i915: Fix whitespace
> 1e47e035bb73 drm/i915: Print the PPS registers using consistent format
> ba21bb24810f drm/i915: Reject unusable power sequencers
> d83804f22d85 drm/i915: Extend dual PPS handlind for ICP+
> bf38bba3e7d6 drm/i915: Try to use the correct power sequencer intiially on bxt/glk
> 209074fd5a82 drm/i915: Generalize the PPS vlv_pipe_check() stuff
> 3f9ffce5765d drm/i915: Do panel VBT init early if the VBT declares an explicit panel type
> f70f8153e364 drm/i915: Introduce intel_panel_init_alloc()
> 
> [Test]
> ODM and I confirmed the issue is fixed after the patches have been applied.
> 
> [Where problems may occur]
> This series of patches fixes a dedicate issue and change the power
> sequence for the eDP panel. eDP panel may stay blank if the rules are wrong.
> OEM kernel has carried this series of patches since early Feb., we didn't
> get any report about the panel issue.
> 
> Ville Syrjälä (9):
>   drm/i915: Introduce intel_panel_init_alloc()
>   drm/i915: Do panel VBT init early if the VBT declares an explicit
>     panel type
>   drm/i915: Generalize the PPS vlv_pipe_check() stuff
>   drm/i915: Try to use the correct power sequencer intiially on bxt/glk
>   drm/i915: Extend dual PPS handlind for ICP+
>   drm/i915: Reject unusable power sequencers
>   drm/i915: Print the PPS registers using consistent format
>   drm/i915: Fix whitespace
>   drm/i915: Improve PPS debugs
> 
>  drivers/gpu/drm/i915/display/icl_dsi.c        |   2 +-
>  drivers/gpu/drm/i915/display/intel_bios.c     |  56 ++-
>  drivers/gpu/drm/i915/display/intel_bios.h     |  11 +-
>  .../gpu/drm/i915/display/intel_connector.c    |   2 +-
>  .../drm/i915/display/intel_display_types.h    |  24 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  19 +-
>  drivers/gpu/drm/i915/display/intel_lvds.c     |   4 +-
>  drivers/gpu/drm/i915/display/intel_panel.c    |   9 +
>  drivers/gpu/drm/i915/display/intel_panel.h    |   1 +
>  drivers/gpu/drm/i915/display/intel_pps.c      | 360 +++++++++++++-----
>  drivers/gpu/drm/i915/display/intel_pps.h      |   2 +-
>  drivers/gpu/drm/i915/display/intel_sdvo.c     |   2 +-
>  drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
>  drivers/gpu/drm/i915/i915_reg.h               |   1 +
>  14 files changed, 364 insertions(+), 131 deletions(-)
> 
> -- 
> 2.34.1
> 
Acked-by: Cory Todd <cory.todd@canonical.com>
Paolo Pisati April 19, 2023, 9:26 a.m. UTC | #3
On Tue, Mar 28, 2023 at 04:32:37PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2001599

Patch 1 and 2 were already applied as part of upstream stable v6.2.7.