mbox series

[0/1,SRU,L,OEM-6.1] Built-in camera device dies after runtime suspended

Message ID 20230216085606.86587-1-acelan.kao@canonical.com
Headers show
Series Built-in camera device dies after runtime suspended | expand

Message

AceLan Kao Feb. 16, 2023, 8:56 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://launchpad.net/bugs/2007530

[Impact]
When the xHC host controller[1022:1505] is runtime suspended, it can't be
waken up and the devices connect to it will be lost.

[Fix]
Add the xHC ID to an existing quirk fixes the issue
https://www.spinics.net/lists/kernel/msg4689370.html

[Test]
Verified by me and QA.

[Where problems could occur]
It disables disable a bit which is enable in sparse controller and do
reset on resume. The impact should be minimun.

Chia-Lin Kao (AceLan) (1):
  UBUNTU: SAUCE: usb: xhci: Workaround for runpm issue on AMD xHC

 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Tim Gardner Feb. 17, 2023, 1:42 p.m. UTC | #1
On 2/16/23 1:56 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2007530
> 
> [Impact]
> When the xHC host controller[1022:1505] is runtime suspended, it can't be
> waken up and the devices connect to it will be lost.
> 
> [Fix]
> Add the xHC ID to an existing quirk fixes the issue
> https://www.spinics.net/lists/kernel/msg4689370.html
> 
> [Test]
> Verified by me and QA.
> 
> [Where problems could occur]
> It disables disable a bit which is enable in sparse controller and do
> reset on resume. The impact should be minimun.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: SAUCE: usb: xhci: Workaround for runpm issue on AMD xHC
> 
>   drivers/usb/host/xhci-pci.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Andrea Righi Feb. 20, 2023, 11:14 a.m. UTC | #2
On Thu, Feb 16, 2023 at 04:56:05PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2007530
> 
> [Impact]
> When the xHC host controller[1022:1505] is runtime suspended, it can't be
> waken up and the devices connect to it will be lost.
> 
> [Fix]
> Add the xHC ID to an existing quirk fixes the issue
> https://www.spinics.net/lists/kernel/msg4689370.html
> 
> [Test]
> Verified by me and QA.
> 
> [Where problems could occur]
> It disables disable a bit which is enable in sparse controller and do
> reset on resume. The impact should be minimun.

Applied to lunar/linux-unstable.

Thanks,
-Andrea
AceLan Kao Feb. 22, 2023, 5:54 a.m. UTC | #3
AMD thinks it's a BIOS issue, and we should fix this in the BIOS.
We're still working on this issue with AMD and ODM BIOS to see if we can
fix this, and I'll submit v2 if we need this quirk later.
Andrea Righi Feb. 22, 2023, 6:35 a.m. UTC | #4
On Wed, Feb 22, 2023 at 01:54:34PM +0800, AceLan Kao wrote:
> AMD thinks it's a BIOS issue, and we should fix this in the BIOS.
> We're still working on this issue with AMD and ODM BIOS to see if we can
> fix this, and I'll submit v2 if we need this quirk later.

Thanks for the update, in the meantime: UNAPPLIED from
lunar/linux-unstable.

-Andrea