From patchwork Thu Feb 9 05:54:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1739797 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YqIEwGEE; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PC5g83gLrz23hX for ; Thu, 9 Feb 2023 16:54:59 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pPztJ-0002hc-K3; Thu, 09 Feb 2023 05:54:41 +0000 Received: from mail-pj1-f52.google.com ([209.85.216.52]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pPztH-0002hK-4O for kernel-team@lists.ubuntu.com; Thu, 09 Feb 2023 05:54:39 +0000 Received: by mail-pj1-f52.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so1261514pjb.5 for ; Wed, 08 Feb 2023 21:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=edd2m3TlcpBy/bNzBvjM4A3Bbe8BD4pOKIzErEH+Wxc=; b=YqIEwGEEFX3lmzSVGV7gIdGLS2Gq30yFnt3xk6vhwvy3yiqLBQXc2NEE9Oe7ulR8+z gW5Mh/Md62k0mQCjT7QRUjVHzvoHi4t+cJYk2jzK2XlQBZOU7tUfe8CYyp3dEDlXGOe8 kIpIrJu/Ja5YG+aq4bbazsNESfdTNTzE1DjKZlH+vbajXYdL29dRHUUHIZyQTiStAnyf uvEm8ZF6+WgePHSWm9cXDyMap5kD5dPCzr/3JTaHv4nXQMvnKML2oe8eKWDGlBVDisu/ MJj/0RgL+6ZrtQnYq3ta5rreaOG0ZqlHSiNSoo2d7v6lEcXC2hxwIclF/qtBcYwy29al v5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=edd2m3TlcpBy/bNzBvjM4A3Bbe8BD4pOKIzErEH+Wxc=; b=20twGYuQLFrKLb/kSbctgIOxigmpzmvLtOjR//d881+VQJzShHLaLl+X81BT3IzFaa OdLmATfZoeMRXY4O11isH++Azaee1Npp+P4En5qv/Gc/PQ5v2a5HTp19Hdf063r/pjhK UTiYL4G46xPUIzvQBu8LrAK0Nu0ymTOVOUjxhRVCEVJ62yAg6cIrlrWOHNeOsp3YspVY ymxbNu7Y4azNzwJTr4ruplgOi8bq2ejPcD4O3erk3Z5c8h5xOcWxo3ZAdp0lyDMsi1Wv vCRXq3SAseOqGXvnDy7kEI51rAXU6dKbWVBP5xdskniE4/K/dTxb9fdV3HAEM8GBnvc1 QbXA== X-Gm-Message-State: AO0yUKWaVCVipvD2ym0zaJYJ8adjCchWpRL9CqVdVabAQDx4Nm8+E/8g nyF2xKc1KihBs3oRRQkNsJtYa6dqqnLD9A== X-Google-Smtp-Source: AK7set9Vej52cZ4J//m4Vpzf+1wlV15yXjnxd3aLkPpeWQYhJosGcc9YWZIghK7saCVxGpC/GNBQbQ== X-Received: by 2002:a17:902:ced0:b0:194:62d9:9a86 with SMTP id d16-20020a170902ced000b0019462d99a86mr11708930plg.59.1675922076538; Wed, 08 Feb 2023 21:54:36 -0800 (PST) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id d2-20020a170902728200b00194ab9a4febsm484523pll.74.2023.02.08.21.54.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 21:54:35 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH v2 0/4][SRU][OEM-5.17] Keeps rebooting with AMD W6400, W6600, and W6800 graphic cards Date: Thu, 9 Feb 2023 13:54:29 +0800 Message-Id: <20230209055433.229851-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.52; envelope-from=acelan@gmail.com; helo=mail-pj1-f52.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://launchpad.net/bugs/2000110 [Impact] With AMD W6400, W6600, or W6800 graphic cards the system keeps rebooting while entering graphics mode. [Fix] These 3 commits fix the issue a8671493d207 drm/amdgpu: make sure to init common IP before gmc e3163bc8ffdf drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega dc1d85cb790f drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega cherry picked one moew commit as it fixes e3163bc8ffdfdb ("drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega") 50b0e4d4da09 drm/amdgpu: fix sdma doorbell init ordering on APUs [Test] Verified on the machine with AMD graphic card, and confirmed the issue is gone. [Where problems could occur] The real fix for this issue is to make sure to init the common IP before gmc, and this commit introduce an regression which need another commit(e3163bc8ffdf) to fix it, and this commit has been partial reverted by dc1d85cb790f. The result is still good, no regression and the issue is fixed. The final code changes are simple and straight forward, should be pretty safe and have minimal impact to the existing systems. Alex Deucher (4): drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega drm/amdgpu: make sure to init common IP before gmc drm/amdgpu: fix sdma doorbell init ordering on APUs drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 +++++++++++--- drivers/gpu/drm/amd/amdgpu/soc15.c | 18 +++++++----------- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 4 ++++ 4 files changed, 26 insertions(+), 14 deletions(-)