| Message ID | 20230209055433.229851-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | Keeps rebooting with AMD W6400, W6600, and W6800 graphic cards | expand |
AceLan Kao kirjoitti 9.2.2023 klo 7.54: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://launchpad.net/bugs/2000110 > > [Impact] > With AMD W6400, W6600, or W6800 graphic cards the system keeps rebooting > while entering graphics mode. > > [Fix] > These 3 commits fix the issue > a8671493d207 drm/amdgpu: make sure to init common IP before gmc > e3163bc8ffdf drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega > dc1d85cb790f drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega > > cherry picked one moew commit as it fixes e3163bc8ffdfdb ("drm/amdgpu: move > nbio sdma_doorbell_range() into sdma code for vega") > 50b0e4d4da09 drm/amdgpu: fix sdma doorbell init ordering on APUs > > [Test] > Verified on the machine with AMD graphic card, and confirmed the issue is > gone. > > [Where problems could occur] > The real fix for this issue is to make sure to init the common IP before > gmc, and this commit introduce an regression which need another > commit(e3163bc8ffdf) to fix it, and this commit has been partial > reverted by dc1d85cb790f. The result is still good, no regression and > the issue is fixed. The final code changes are simple and straight > forward, should be pretty safe and have minimal impact to the existing > systems. > > Alex Deucher (4): > drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega > drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega > drm/amdgpu: make sure to init common IP before gmc > drm/amdgpu: fix sdma doorbell init ordering on APUs > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 +++++++++++--- > drivers/gpu/drm/amd/amdgpu/soc15.c | 18 +++++++----------- > drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 4 ++++ > drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 4 ++++ > 4 files changed, 26 insertions(+), 14 deletions(-) > I see this is all in kinetic already, which is nice. Applied to oem-5.17, thanks
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> BugLink: https://launchpad.net/bugs/2000110 [Impact] With AMD W6400, W6600, or W6800 graphic cards the system keeps rebooting while entering graphics mode. [Fix] These 3 commits fix the issue a8671493d207 drm/amdgpu: make sure to init common IP before gmc e3163bc8ffdf drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega dc1d85cb790f drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega cherry picked one moew commit as it fixes e3163bc8ffdfdb ("drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega") 50b0e4d4da09 drm/amdgpu: fix sdma doorbell init ordering on APUs [Test] Verified on the machine with AMD graphic card, and confirmed the issue is gone. [Where problems could occur] The real fix for this issue is to make sure to init the common IP before gmc, and this commit introduce an regression which need another commit(e3163bc8ffdf) to fix it, and this commit has been partial reverted by dc1d85cb790f. The result is still good, no regression and the issue is fixed. The final code changes are simple and straight forward, should be pretty safe and have minimal impact to the existing systems. Alex Deucher (4): drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega drm/amdgpu: move nbio sdma_doorbell_range() into sdma code for vega drm/amdgpu: make sure to init common IP before gmc drm/amdgpu: fix sdma doorbell init ordering on APUs drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 +++++++++++--- drivers/gpu/drm/amd/amdgpu/soc15.c | 18 +++++++----------- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 4 ++++ 4 files changed, 26 insertions(+), 14 deletions(-)