mbox series

[Unstable/Lunar,0/5] Misc debian rules cleanups

Message ID 20230111085839.96754-1-juerg.haefliger@canonical.com
Headers show
Series Misc debian rules cleanups | expand

Message

Juerg Haefliger Jan. 11, 2023, 8:58 a.m. UTC 
A couple of patches that clean up our build rules:
 - Remove unused/obsolete env variables
 - Clean up the 'skip check' feature and extend it to modules signature
   checks

Juerg Haefliger (5):
  UBUNTU: [Packaging] debian/rules: Drop AUTOBUILD
  UBUNTU: [Packaging] debian/rules: Drop NOKERNLOG and PRINTSHAS env
    variables
  UBUNTU: [Packaging] debian/rules: Replace skip<foo> variables with
    skip_checks
  UBUNTU: [Packaging] checks/retpoline-check: Make 'skipretpoline'
    argument optional
  UBUNTU: [Packaging] checks/module-signature-check: Add 'skip_checks'
    argument

 debian/rules                                 |  4 +--
 debian/rules.d/0-common-vars.mk              | 34 ++------------------
 debian/rules.d/1-maintainer.mk               |  9 ++----
 debian/rules.d/2-binary-arch.mk              |  4 ---
 debian/rules.d/3-binary-indep.mk             | 14 ++++----
 debian/rules.d/4-checks.mk                   |  9 +++---
 debian/scripts/checks/module-signature-check | 27 ++++++++++++----
 debian/scripts/checks/retpoline-check        |  7 +++-
 8 files changed, 44 insertions(+), 64 deletions(-)

Comments

Tim Gardner Jan. 11, 2023, 1:13 p.m. UTC | #1 
On 1/11/23 1:58 AM, Juerg Haefliger wrote:
> A couple of patches that clean up our build rules:
>   - Remove unused/obsolete env variables
>   - Clean up the 'skip check' feature and extend it to modules signature
>     checks
> 
> Juerg Haefliger (5):
>    UBUNTU: [Packaging] debian/rules: Drop AUTOBUILD
>    UBUNTU: [Packaging] debian/rules: Drop NOKERNLOG and PRINTSHAS env
>      variables
>    UBUNTU: [Packaging] debian/rules: Replace skip<foo> variables with
>      skip_checks
>    UBUNTU: [Packaging] checks/retpoline-check: Make 'skipretpoline'
>      argument optional
>    UBUNTU: [Packaging] checks/module-signature-check: Add 'skip_checks'
>      argument
> 
>   debian/rules                                 |  4 +--
>   debian/rules.d/0-common-vars.mk              | 34 ++------------------
>   debian/rules.d/1-maintainer.mk               |  9 ++----
>   debian/rules.d/2-binary-arch.mk              |  4 ---
>   debian/rules.d/3-binary-indep.mk             | 14 ++++----
>   debian/rules.d/4-checks.mk                   |  9 +++---
>   debian/scripts/checks/module-signature-check | 27 ++++++++++++----
>   debian/scripts/checks/retpoline-check        |  7 +++-
>   8 files changed, 44 insertions(+), 64 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Seems reasonable. I kinda remember the AUTOBUILD stuff.
Andrea Righi Jan. 16, 2023, 9:42 a.m. UTC | #2 
On Wed, Jan 11, 2023 at 09:58:34AM +0100, Juerg Haefliger wrote:
> A couple of patches that clean up our build rules:
>  - Remove unused/obsolete env variables
>  - Clean up the 'skip check' feature and extend it to modules signature
>    checks

Already applied via pull request.

-Andrea
Juerg Haefliger Jan. 16, 2023, 12:36 p.m. UTC | #3 
Superseded by a PR.

...juerg


> A couple of patches that clean up our build rules:
>  - Remove unused/obsolete env variables
>  - Clean up the 'skip check' feature and extend it to modules signature
>    checks
> 
> Juerg Haefliger (5):
>   UBUNTU: [Packaging] debian/rules: Drop AUTOBUILD
>   UBUNTU: [Packaging] debian/rules: Drop NOKERNLOG and PRINTSHAS env
>     variables
>   UBUNTU: [Packaging] debian/rules: Replace skip<foo> variables with
>     skip_checks
>   UBUNTU: [Packaging] checks/retpoline-check: Make 'skipretpoline'
>     argument optional
>   UBUNTU: [Packaging] checks/module-signature-check: Add 'skip_checks'
>     argument
> 
>  debian/rules                                 |  4 +--
>  debian/rules.d/0-common-vars.mk              | 34 ++------------------
>  debian/rules.d/1-maintainer.mk               |  9 ++----
>  debian/rules.d/2-binary-arch.mk              |  4 ---
>  debian/rules.d/3-binary-indep.mk             | 14 ++++----
>  debian/rules.d/4-checks.mk                   |  9 +++---
>  debian/scripts/checks/module-signature-check | 27 ++++++++++++----
>  debian/scripts/checks/retpoline-check        |  7 +++-
>  8 files changed, 44 insertions(+), 64 deletions(-)
>