mbox series

[Unstable,0/4] Rewrite abi-check in Python plus cleanups

Message ID 20221208071728.193067-1-juerg.haefliger@canonical.com
Headers show
Series Rewrite abi-check in Python plus cleanups | expand

Message

Juerg Haefliger Dec. 8, 2022, 7:17 a.m. UTC 
Long overdue, abi-check rewritten in Python as agreed upon some time
ago at one of our sprints. While at it, clean up module-check to match
the new abi-check both in coding style and script output. Finally, move
all checker scripts to a new subdirectory to put some order into our
scripts.

Note that the new abi-check script does no longer check for symbol
hash changes since we seem to ignore this anyways. Shout if that's not
the case.

Juerg Haefliger (4):
  UBUNTU: [Packaging] Rewrite debian/scripts/abi-check in Python
  UBUNTU: [Packaging] Simplify debian/scripts/module-check
  UBUNTU: [Packaging] Clean up debian/scripts/module-check
  UBUNTU: [Packaging] Move checker scripts to debian/scripts/checks

 debian/rules.d/4-checks.mk                    |  13 +-
 debian/scripts/abi-check                      | 210 ------------------
 debian/scripts/checks/abi-check               | 139 ++++++++++++
 debian/scripts/{ => checks}/config-check      |   0
 debian/scripts/{ => checks}/module-check      | 106 +++++----
 .../{ => checks}/module-signature-check       |   2 +-
 debian/scripts/{ => checks}/retpoline-check   |   0
 7 files changed, 208 insertions(+), 262 deletions(-)
 delete mode 100755 debian/scripts/abi-check
 create mode 100755 debian/scripts/checks/abi-check
 rename debian/scripts/{ => checks}/config-check (100%)
 rename debian/scripts/{ => checks}/module-check (51%)
 rename debian/scripts/{ => checks}/module-signature-check (97%)
 rename debian/scripts/{ => checks}/retpoline-check (100%)

Comments

Andrea Righi Dec. 9, 2022, 7:21 a.m. UTC | #1 
On Thu, Dec 08, 2022 at 08:17:24AM +0100, Juerg Haefliger wrote:
> Long overdue, abi-check rewritten in Python as agreed upon some time
> ago at one of our sprints. While at it, clean up module-check to match
> the new abi-check both in coding style and script output. Finally, move
> all checker scripts to a new subdirectory to put some order into our
> scripts.
> 
> Note that the new abi-check script does no longer check for symbol
> hash changes since we seem to ignore this anyways. Shout if that's not
> the case.

Everything looks good to me, time for big cleanups! Applied to
lunar/linux-unstable.

Thanks,
-Andrea


> 
> Juerg Haefliger (4):
>   UBUNTU: [Packaging] Rewrite debian/scripts/abi-check in Python
>   UBUNTU: [Packaging] Simplify debian/scripts/module-check
>   UBUNTU: [Packaging] Clean up debian/scripts/module-check
>   UBUNTU: [Packaging] Move checker scripts to debian/scripts/checks
> 
>  debian/rules.d/4-checks.mk                    |  13 +-
>  debian/scripts/abi-check                      | 210 ------------------
>  debian/scripts/checks/abi-check               | 139 ++++++++++++
>  debian/scripts/{ => checks}/config-check      |   0
>  debian/scripts/{ => checks}/module-check      | 106 +++++----
>  .../{ => checks}/module-signature-check       |   2 +-
>  debian/scripts/{ => checks}/retpoline-check   |   0
>  7 files changed, 208 insertions(+), 262 deletions(-)
>  delete mode 100755 debian/scripts/abi-check
>  create mode 100755 debian/scripts/checks/abi-check
>  rename debian/scripts/{ => checks}/config-check (100%)
>  rename debian/scripts/{ => checks}/module-check (51%)
>  rename debian/scripts/{ => checks}/module-signature-check (97%)
>  rename debian/scripts/{ => checks}/retpoline-check (100%)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team