From patchwork Wed Oct 26 04:12:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1694753 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MxwRC6W7Pz20S2 for ; Wed, 26 Oct 2022 15:13:42 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1onXnE-0006Bi-V8; Wed, 26 Oct 2022 04:13:28 +0000 Received: from mail-pj1-f47.google.com ([209.85.216.47]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1onXnD-0006BM-2q for kernel-team@lists.ubuntu.com; Wed, 26 Oct 2022 04:13:27 +0000 Received: by mail-pj1-f47.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so1088299pji.0 for ; Tue, 25 Oct 2022 21:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vRZPHIMA+jrUTD9KuFa6h8JxvfAtCH/lNBXprazsf5w=; b=j7qyN7OR1HgrrzYGyHXj/u1F2H9y7qgcctiWK+GoGtojAPjoC0h0xktrjrf+Qbts18 /WNvz8UbWDAi7im8uXn8OzRszr8t5wLpQVS9esBb1bEfyTljqUk1DiNMcV8K4Ib38DMj EoRADM1q83PeDMpBOKapyp7Z63pZzrjV71pRfoLz2jT5egN9Lu0PFhYGogT5s2JBUwLX xfKJk1nVgmTjLZ0EWJ+ZlCIz0y55hBjRvkJn1qbgDvn8KQKj84PLCp3u1qHu1tgAwwr/ UVAV7tvBdCyjrII3qjyPdoqKqcA5Qput/wZVTHWe7mC+exyKaaqXWZ5idObbKExj9WI8 nfRw== X-Gm-Message-State: ACrzQf1mT/tHkzlSOg1kukxhdA45PAdDBNxLjJ31RZH8gwtLQo88+48X G5ENSN9n1vhZof7934PluJ+YIsLy6jlhEQ== X-Google-Smtp-Source: AMsMyM4AJCGyEmgYyZicN/QYBDjt21ZyBnAr1k8p72eR67LNGckTj72ZbydXRcc5deK4NE2XqHdw+w== X-Received: by 2002:a17:90a:1b44:b0:213:1035:f913 with SMTP id q62-20020a17090a1b4400b002131035f913mr1918042pjq.133.1666757604789; Tue, 25 Oct 2022 21:13:24 -0700 (PDT) Received: from localhost.localdomain (61-227-102-1.dynamic-ip.hinet.net. [61.227.102.1]) by smtp.gmail.com with ESMTPSA id t17-20020a17090340d100b001869e17baf4sm1923215pld.127.2022.10.25.21.13.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 21:13:24 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/2][SRU][OEM-6.0] amd_sfh modprobe fails when no sensor reported from AMD MP2 Date: Wed, 26 Oct 2022 12:12:40 +0800 Message-Id: <20221026041242.657921-1-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.216.47; envelope-from=vicamo@gmail.com; helo=mail-pj1-f47.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "You-Sheng Yang (vicamo)" BugLink: https://bugs.launchpad.net/bugs/1993240 [Impact] Some AMD platforms might not have sensor reported from MP2 controller, and that fails device init. [Fix] Two commits targeting v6.1 release in mainline kernel. [Test Case] On such platforms, driver loading should be bailed out with: $ sudo dmesg | grep amd_sfh1_1_hid_client_init [ 1.204896] pcie_mp2_amd 0000:62:00.7: amd_sfh1_1_hid_client_init failed [Where problems could occur] This skips driver loading against ineffective hardware only. [Other Info] While this targets oem-6.0 and above, and is already in mainline v6.1-rc1, only oem-6.0 is nominated for fix. Basavaraj Natikar (2): HID: amd_sfh: Change dev_err to dev_dbg for additional debug info HID: amd_sfh: Handle condition of "no sensors" for SFH1.1 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Acked-by: Tim Gardner