| Message ID | 20221026041242.657921-1-vicamo.yang@canonical.com |
|---|---|
| Headers | show |
| Series | amd_sfh modprobe fails when no sensor reported from AMD MP2 | expand |
On 10/25/22 10:12 PM, You-Sheng Yang wrote: > From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1993240 > > [Impact] > > Some AMD platforms might not have sensor reported from MP2 controller, > and that fails device init. > > [Fix] > > Two commits targeting v6.1 release in mainline kernel. > > [Test Case] > > On such platforms, driver loading should be bailed out with: > > $ sudo dmesg | grep amd_sfh1_1_hid_client_init > [ 1.204896] pcie_mp2_amd 0000:62:00.7: amd_sfh1_1_hid_client_init failed > > [Where problems could occur] > > This skips driver loading against ineffective hardware only. > > [Other Info] > > While this targets oem-6.0 and above, and is already in mainline > v6.1-rc1, only oem-6.0 is nominated for fix. > > Basavaraj Natikar (2): > HID: amd_sfh: Change dev_err to dev_dbg for additional debug info > HID: amd_sfh: Handle condition of "no sensors" for SFH1.1 > > drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
You-Sheng Yang kirjoitti 26.10.2022 klo 7.12: > From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1993240 > > [Impact] > > Some AMD platforms might not have sensor reported from MP2 controller, > and that fails device init. > > [Fix] > > Two commits targeting v6.1 release in mainline kernel. > > [Test Case] > > On such platforms, driver loading should be bailed out with: > > $ sudo dmesg | grep amd_sfh1_1_hid_client_init > [ 1.204896] pcie_mp2_amd 0000:62:00.7: amd_sfh1_1_hid_client_init failed > > [Where problems could occur] > > This skips driver loading against ineffective hardware only. > > [Other Info] > > While this targets oem-6.0 and above, and is already in mainline > v6.1-rc1, only oem-6.0 is nominated for fix. > > Basavaraj Natikar (2): > HID: amd_sfh: Change dev_err to dev_dbg for additional debug info > HID: amd_sfh: Handle condition of "no sensors" for SFH1.1 > > drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > the second commit came already via stable, but the other one applied to oem-6.0, thanks
From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com> BugLink: https://bugs.launchpad.net/bugs/1993240 [Impact] Some AMD platforms might not have sensor reported from MP2 controller, and that fails device init. [Fix] Two commits targeting v6.1 release in mainline kernel. [Test Case] On such platforms, driver loading should be bailed out with: $ sudo dmesg | grep amd_sfh1_1_hid_client_init [ 1.204896] pcie_mp2_amd 0000:62:00.7: amd_sfh1_1_hid_client_init failed [Where problems could occur] This skips driver loading against ineffective hardware only. [Other Info] While this targets oem-6.0 and above, and is already in mainline v6.1-rc1, only oem-6.0 is nominated for fix. Basavaraj Natikar (2): HID: amd_sfh: Change dev_err to dev_dbg for additional debug info HID: amd_sfh: Handle condition of "no sensors" for SFH1.1 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)