From patchwork Wed Aug 24 11:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Renner Berthing X-Patchwork-Id: 1669738 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=KH89m6bu; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MCNYP64K2z1yhL for ; Wed, 24 Aug 2022 21:05:28 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oQoC7-0002zI-9Q; Wed, 24 Aug 2022 11:05:11 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oQoC6-0002yr-1E for kernel-team@lists.ubuntu.com; Wed, 24 Aug 2022 11:05:10 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AD54540AC4 for ; Wed, 24 Aug 2022 11:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1661339109; bh=DlG5y+iulCCNsjWbSXPI5WgBE5j8VBqCOLjZuYFjVjc=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=KH89m6buv6FxXKoXsy7hqaBVJTQj9r6BD20xgiCFMpl9n53WI7FX1MWzg6gHg1Bh/ ScxLuImlLaSCBH2sXK3qfO3DWmdyZMnA/oNJ/gLogQVV86FgjSTQ7SawrKRYC1NrGL QIpMsqL/eWsJBvj5M6RoaC5TRgd+4cd6qWzRtAuc7/HH0jOxxFYezA7J/MIw7U6xY2 diceJl+UoDEUBWqaj5tfUuCmvc92vc9diDhXj+KaCCybzA5LT6wK3pOI3TDQlM/S9A dvxEyiZBQgIf9Dt+XE8uOGu6HV+rN6066hjFlxcq2tXsOD+9q64Y5ot7P89G8vhQSD DzqmWiD8Dg4aw== Received: by mail-ed1-f71.google.com with SMTP id y10-20020a056402358a00b00446da94e669so4936508edc.3 for ; Wed, 24 Aug 2022 04:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc; bh=DlG5y+iulCCNsjWbSXPI5WgBE5j8VBqCOLjZuYFjVjc=; b=qeta4dq136Ciber43iapbUK2O7NzKISpXR2narR/IWFQDLb6fsobtKHQQ63wZnj66z kQTgjz8+RTBj9ewfSUU1yyZfO34O5nTme4eq5NaR2935iM7++svARhciBFdhW9dx+JPF OyfoNUEorFFFlfsuvCwXOd+/IeI+p8bkOk8RZXKpg8LdrX9bJrQ5NOnjLAdW+CYawwm5 6EvitG37xDo+m9SqTKJ9x3EorbWlhJbOJu8PHwnA4G+J2r9NOzJ3Pj898AxnueuNM9iT rd+/6J/sxzjRUJ4JMgwUYX9AFsXl44zMPuVyXduyVyk1uT4KEO/Ke6cARlPTuJPRV71k FfMA== X-Gm-Message-State: ACgBeo0cR9it7JMuOHtpYNd1BIsiGvEm3RQ9pK2DMMnQdnfeuS9ZhGz8 x6UCcJxW4ykCxC1Vp8Nl2KNX4NpAHR9l14vK0h89oJL30InLss6n2sJk2ad8rRUpTyxr/1GSTiN ERi0MnCZ2uIUFiHkAEXS+nWvdZ/p7ZoCmk73lgfnGlw== X-Received: by 2002:a17:907:2bc3:b0:73d:afd8:260e with SMTP id gv3-20020a1709072bc300b0073dafd8260emr2522569ejc.436.1661339109146; Wed, 24 Aug 2022 04:05:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR636mv3c2rspXl59ofsTCGEFLyuswhYVGwJH3Ywwd6OYCBWDbPIVeZaEvb1ih3EjFvDYy7vzA== X-Received: by 2002:a17:907:2bc3:b0:73d:afd8:260e with SMTP id gv3-20020a1709072bc300b0073dafd8260emr2522551ejc.436.1661339108858; Wed, 24 Aug 2022 04:05:08 -0700 (PDT) Received: from stitch.. (80.71.140.73.ipv4.parknet.dk. [80.71.140.73]) by smtp.gmail.com with ESMTPSA id q10-20020aa7d44a000000b00447990ba835sm55248edr.25.2022.08.24.04.05.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 04:05:08 -0700 (PDT) From: Emil Renner Berthing To: kernel-team@lists.ubuntu.com Subject: [SRU][K][PATCH 0/3] Support LEDs on the SiFive Unmatched Date: Wed, 24 Aug 2022 13:05:04 +0200 Message-Id: <20220824110507.1114445-1-emil.renner.berthing@canonical.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" [Impact] * The Ubuntu RISC-V kernel carries out-of-tree patches to enable the two LEDs on the SiFive Unmatched board. * There is now an upstream solution to enable the LEDs that appears a little different from userspace. With the out-of-tree patches the three colours in the RGB LED appears as 3 different LEDs, but upstream models them as 1 RGB LED. * Replacing the out-of-tree patches with the upstream solution will make Ubuntu kernels behave like the upstream kernel going forward. [Test Plan] * Boot Ubuntu on the Unmatched board and look at how the LEDs show up in /sys/class/leds * Check that both the green D12 and all three colours of D2 can still be controlled from userspace. [Where problems could occur] * Users may have scripts setting up LEDs that will no longer work when updating to Kinetic with this change. Emil Renner Berthing (3): dt-bindings: leds: pwm-multicolor: Add active-low property leds: pwm-multicolor: Support active-low LEDs riscv: dts: sifive unmatched: Add PWM controlled LEDs .../bindings/leds/leds-pwm-multicolor.yaml | 4 ++ .../boot/dts/sifive/hifive-unmatched-a00.dts | 42 +++++++++++++++++++ drivers/leds/rgb/leds-pwm-multicolor.c | 5 +++ 3 files changed, 51 insertions(+) Acked-by: Tim Gardner Acked-by: Kleber Sacilotto de Souza