From patchwork Tue Aug 16 14:20:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip Cox X-Patchwork-Id: 1666882 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Yc0Y4WHy; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4M6YHk1DGfz1yfd for ; Wed, 17 Aug 2022 00:21:52 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1oNxRr-0000ke-1g; Tue, 16 Aug 2022 14:21:39 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1oNxRp-0000kQ-Is for kernel-team@lists.ubuntu.com; Tue, 16 Aug 2022 14:21:37 +0000 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 34DCB3F1A1 for ; Tue, 16 Aug 2022 14:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1660659696; bh=0hJ6sz5/mxqM/Nr1qOzThZ11LcAi4W911ApTzO42CoA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Yc0Y4WHy5CV4A52rIgs9oetV59ET9VX/Jv2zfrVcvDhYjE8+EW7GQ2yiVyd4PIuL2 IgVFBgF5qgshUJHArDX7z20Kh0eKCE0PsVrJHkjkbgtr4ZoS7LeRLFN9CwmENTBZIY cNZtDSyzNK+wp0Rrk4k7IIaUdKg06qZhlcJg2xsNf/FywX6bJhNhvLT2dhiuPRHxE5 3Desy7frlgfNx9Dt9ZeVZuKN7bNhQPWgzz5XE2oKr7wUv3T7MRcqgYdqtRSF6wyKB3 pvYAWk7U1EZqPyvx5HXPia27fhutA2wAmyWw4qW1zsgaUMvewDuHmvfWmVvhbqOp+1 eBlzQYf5xatSg== Received: by mail-qv1-f72.google.com with SMTP id nm18-20020a0562143b1200b0047b33c1e57eso4425813qvb.10 for ; Tue, 16 Aug 2022 07:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=0hJ6sz5/mxqM/Nr1qOzThZ11LcAi4W911ApTzO42CoA=; b=lb1P8JNJjiHi2dgBV4gG9jOTVixTwmF9PKDtV819aQEaGiH7vR1o/QzzsarCVDUCCi dsUKSKgJuXkdf7u7IGzP763B5qh7io67+pZpDysRa8q4QKBKuOiYx8PrhC6O+v65ijlO f542DK6M7X3vWOruwrHXIYirtDtl4THMxGc4Br/Gh/5UW3Ga4Cn1jKzLr4MTjCDQ1d8I vB1QMfXowf0EvuPwLKuwv/qrzfQmQpgkFNdejVnPnlyJlTCuIxwQrhHThqofPnUyV69q 88ZFqWs5b+/L4PMgUXq6BECPrF9CpgDw7LZa9l5o6Pf8fBXjqZLz6jREEa2dkVjYTjLf fdsg== X-Gm-Message-State: ACgBeo2o9mKjY8gExNLuJYIYR2JBWl2hiiQD/oyjFhgAhP9+2SIxZsAU bckkjnkf6ay9ZdhMy0a9QJBTbMoiH5ikk3ip0F5iBA9zKhlqw4C1uPs6iu2QXHFHuDguaHp2xZA 18VQNytpuqu1RR/JVZ0osf0xovnSXKdOs9Ktz61MI8Q== X-Received: by 2002:ac8:7d81:0:b0:343:657c:53fb with SMTP id c1-20020ac87d81000000b00343657c53fbmr18707785qtd.468.1660659694892; Tue, 16 Aug 2022 07:21:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR5UPJr6RFyXmYg98wOvo/rLUoUEZoInFxMK7x3y9xAC6LRtnmSTtnE+qLfu6XqLFz9duHHhmw== X-Received: by 2002:ac8:7d81:0:b0:343:657c:53fb with SMTP id c1-20020ac87d81000000b00343657c53fbmr18707764qtd.468.1660659694602; Tue, 16 Aug 2022 07:21:34 -0700 (PDT) Received: from localhost.localdomain ([104.247.231.135]) by smtp.gmail.com with ESMTPSA id c75-20020a379a4e000000b006bae6f73e41sm9782754qke.5.2022.08.16.07.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 07:21:33 -0700 (PDT) From: Philip Cox To: kernel-team@lists.ubuntu.com Subject: [SRU][Jammy:linux-intel-iotg][PATCH v3 0/2] i915: Enable HuC authentication for EHL, ICL, and ADL-S Date: Tue, 16 Aug 2022 10:20:54 -0400 Message-Id: <20220816142056.1222020-1-philip.cox@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1981971 v2: removed magic number in patch 0002, and clean up commit message in commit 0001. v3: added version history to cover letter, and to patch commit messages. [Impact] * In the i915 Intel gfx driver, we need to explicitly enable HuC authentication. * This fixes an issue with the Gstreamer media pipeline. * This only applies to the ICL, ADL-S, and EHL platforms. * This patch is only for the linux-intel-iotg kernel. We have pulled in patches from upstream, so the state of this driver is in between the upstream 5.15 driver, and the upstream tip-of-tree driver. [Test Plan] * Intel has tested this patch. * I have tested the patch as well. * To test, the system is booted, and issuing the command: sudo cat /sys/kernel/debug/dri/0/gt/uc/huc_info will either return the huc info, or it will display "HuC disabled" [Where problems could occur] * If the installed firmware has been trimmed so that only blobs that were in use were retained, when the kernel tried to load the HuC blob, it would fail. This scenario should not happen unless someone is mucking about with the installed firmware. If that is the case, other things will likely start failing as well. Acked-by: Tim Gardner Acked-by: Marcelo Henrique Cerri