mbox series

[0/1,SRU,J/OEM-5.17/U] Fix invalid MAC address after hotplug tbt dock

Message ID 20220803075553.884839-1-aaron.ma@canonical.com
Headers show
Series Fix invalid MAC address after hotplug tbt dock | expand

Message

Aaron Ma Aug. 3, 2022, 7:55 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1942999

[Impact]
igc driver can not connect to network after re-plugin thunderbolt dock
when
MAC passthrough enabled in BIOS.

[Fix]
Wait for the MAC copy of BIOS when enabled MAC passthrough.
Intel engineer wants a different solution and promise to discuss with
firmware engineer.
Due to the schedule, made this as a short term solution to fix the
issue, and wait for the other
fix from Intel.

[Test]
Verified on hardware, after hotplug the thunderbolt cable,
Ethernet works fine.

[Where problems could occur]
It may break the igc driver.

Intel still doesn't provide any solution about their approach.
In the meantime, this patch is still the only fix.
Re-submit it to Jammy, oem-5.17 and Unstable kernel.

Aaron Ma (1):
  UBUNTU: SAUCE: igc: wait for the MAC copy when enabled MAC passthrough

 drivers/net/ethernet/intel/igc/igc_main.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stefan Bader Aug. 5, 2022, 9:31 a.m. UTC | #1 
On 03.08.22 09:55, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1942999
> 
> [Impact]
> igc driver can not connect to network after re-plugin thunderbolt dock
> when
> MAC passthrough enabled in BIOS.
> 
> [Fix]
> Wait for the MAC copy of BIOS when enabled MAC passthrough.
> Intel engineer wants a different solution and promise to discuss with
> firmware engineer.
> Due to the schedule, made this as a short term solution to fix the
> issue, and wait for the other
> fix from Intel.
> 
> [Test]
> Verified on hardware, after hotplug the thunderbolt cable,
> Ethernet works fine.
> 
> [Where problems could occur]
> It may break the igc driver.
> 
> Intel still doesn't provide any solution about their approach.
> In the meantime, this patch is still the only fix.
> Re-submit it to Jammy, oem-5.17 and Unstable kernel.
> 
> Aaron Ma (1):
>    UBUNTU: SAUCE: igc: wait for the MAC copy when enabled MAC passthrough
> 
>   drivers/net/ethernet/intel/igc/igc_main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner Aug. 5, 2022, 2:18 p.m. UTC | #2 
On 8/3/22 01:55, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1942999
> 
> [Impact]
> igc driver can not connect to network after re-plugin thunderbolt dock
> when
> MAC passthrough enabled in BIOS.
> 
> [Fix]
> Wait for the MAC copy of BIOS when enabled MAC passthrough.
> Intel engineer wants a different solution and promise to discuss with
> firmware engineer.
> Due to the schedule, made this as a short term solution to fix the
> issue, and wait for the other
> fix from Intel.
> 
> [Test]
> Verified on hardware, after hotplug the thunderbolt cable,
> Ethernet works fine.
> 
> [Where problems could occur]
> It may break the igc driver.
> 
> Intel still doesn't provide any solution about their approach.
> In the meantime, this patch is still the only fix.
> Re-submit it to Jammy, oem-5.17 and Unstable kernel.
> 
> Aaron Ma (1):
>    UBUNTU: SAUCE: igc: wait for the MAC copy when enabled MAC passthrough
> 
>   drivers/net/ethernet/intel/igc/igc_main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Timo Aaltonen Aug. 12, 2022, 6:44 a.m. UTC | #3 
Aaron Ma kirjoitti 3.8.2022 klo 10.55:
> BugLink: https://bugs.launchpad.net/bugs/1942999
> 
> [Impact]
> igc driver can not connect to network after re-plugin thunderbolt dock
> when
> MAC passthrough enabled in BIOS.
> 
> [Fix]
> Wait for the MAC copy of BIOS when enabled MAC passthrough.
> Intel engineer wants a different solution and promise to discuss with
> firmware engineer.
> Due to the schedule, made this as a short term solution to fix the
> issue, and wait for the other
> fix from Intel.
> 
> [Test]
> Verified on hardware, after hotplug the thunderbolt cable,
> Ethernet works fine.
> 
> [Where problems could occur]
> It may break the igc driver.
> 
> Intel still doesn't provide any solution about their approach.
> In the meantime, this patch is still the only fix.
> Re-submit it to Jammy, oem-5.17 and Unstable kernel.
> 
> Aaron Ma (1):
>    UBUNTU: SAUCE: igc: wait for the MAC copy when enabled MAC passthrough
> 
>   drivers/net/ethernet/intel/igc/igc_main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 

applied to oem-5.17, thanks