mbox series

[SRU,F:linux-bluefield,v2,0/3] : UBUNTU: SAUCE: pwr-mlxbf.c: Improve driver dependencies and fix zero allocating memory size

Message ID 20220729130701.30269-1-asmaa@nvidia.com
Headers show
Series : UBUNTU: SAUCE: pwr-mlxbf.c: Improve driver dependencies and fix zero allocating memory size | expand

Message

Asmaa Mnebhi July 29, 2022, 1:06 p.m. UTC
Buglink: https://bugs.launchpad.net/bugs/1980750

SRU Justification:

[Impact]

Improve the driver dependency on the gpio driver. Move that dependency to the probe as instructed by maintainers.
Flush if there is remaining work while the driver is removed. fix size for zero allocating memory.

[Fix]

* Instead of using SOFTDEP, return -EPROBE_DEFER if the gpio-mlxbf2.c driver is not loaded yet.
* Flush work when driver is removed.
* fix size for zero allocating memory.
* Upgrade the driver version to 1.1 due to all above changes

[Test Case]

* Test case only valid on Board with BMC on it:
* Make sure driver is loaded and no errors in dmesg.
* issue a power reset from the BMC via IPMI.

[Regression Potential]

Any of the test cases above could be impacted due to these changes.

Comments

Tim Gardner July 29, 2022, 2:10 p.m. UTC | #1
On 7/29/22 07:06, Asmaa Mnebhi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1980750
> 
> SRU Justification:
> 
> [Impact]
> 
> Improve the driver dependency on the gpio driver. Move that dependency to the probe as instructed by maintainers.
> Flush if there is remaining work while the driver is removed. fix size for zero allocating memory.
> 
> [Fix]
> 
> * Instead of using SOFTDEP, return -EPROBE_DEFER if the gpio-mlxbf2.c driver is not loaded yet.
> * Flush work when driver is removed.
> * fix size for zero allocating memory.
> * Upgrade the driver version to 1.1 due to all above changes
> 
> [Test Case]
> 
> * Test case only valid on Board with BMC on it:
> * Make sure driver is loaded and no errors in dmesg.
> * issue a power reset from the BMC via IPMI.
> 
> [Regression Potential]
> 
> Any of the test cases above could be impacted due to these changes.
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Zachary Tahenakos Aug. 1, 2022, 1:21 p.m. UTC | #2
Acked-by: Zachary Tahenakos <zachary.tahenakos@canonical.com>

On Fri, Jul 29, 2022 at 9:07 AM Asmaa Mnebhi <asmaa@nvidia.com> wrote:

> Buglink: https://bugs.launchpad.net/bugs/1980750
>
> SRU Justification:
>
> [Impact]
>
> Improve the driver dependency on the gpio driver. Move that dependency to
> the probe as instructed by maintainers.
> Flush if there is remaining work while the driver is removed. fix size for
> zero allocating memory.
>
> [Fix]
>
> * Instead of using SOFTDEP, return -EPROBE_DEFER if the gpio-mlxbf2.c
> driver is not loaded yet.
> * Flush work when driver is removed.
> * fix size for zero allocating memory.
> * Upgrade the driver version to 1.1 due to all above changes
>
> [Test Case]
>
> * Test case only valid on Board with BMC on it:
> * Make sure driver is loaded and no errors in dmesg.
> * issue a power reset from the BMC via IPMI.
>
> [Regression Potential]
>
> Any of the test cases above could be impacted due to these changes.
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Zachary Tahenakos Aug. 11, 2022, 4:37 p.m. UTC | #3
Applied to focal:linux-bluefield.

Thanks,
Zack

On Fri, Jul 29, 2022 at 9:07 AM Asmaa Mnebhi <asmaa@nvidia.com> wrote:

> Buglink: https://bugs.launchpad.net/bugs/1980750
>
> SRU Justification:
>
> [Impact]
>
> Improve the driver dependency on the gpio driver. Move that dependency to
> the probe as instructed by maintainers.
> Flush if there is remaining work while the driver is removed. fix size for
> zero allocating memory.
>
> [Fix]
>
> * Instead of using SOFTDEP, return -EPROBE_DEFER if the gpio-mlxbf2.c
> driver is not loaded yet.
> * Flush work when driver is removed.
> * fix size for zero allocating memory.
> * Upgrade the driver version to 1.1 due to all above changes
>
> [Test Case]
>
> * Test case only valid on Board with BMC on it:
> * Make sure driver is loaded and no errors in dmesg.
> * issue a power reset from the BMC via IPMI.
>
> [Regression Potential]
>
> Any of the test cases above could be impacted due to these changes.
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>