mbox series

[SRU,J/HWE-5.17/OEM-5.17/HWE-5.15,0/1] Audio mute key (f5) LED and Mic mute key (f8) LED are no function on HP 440/450/640/650 G9

Message ID 20220725065056.27853-1-jeremy.szu@canonical.com
Headers show
Series Audio mute key (f5) LED and Mic mute key (f8) LED are no function on HP 440/450/640/650 G9 | expand

Message

Jeremy Szu July 25, 2022, 6:50 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1982716

[Impact]
The audio mute key (F5) and mic-mute LED (F8) don't work on some HP 440/450/640/650 G9 laptops.

[Fix]
The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple
motherboard design and they are using different subsystem ID of audio
codec. Add the same quirk for other MBs.

[Test]
After applying the fix, the mute LEDs are working.

[Where problems could occur]
It's low risk as it's specific ID for HP new machines. If the HP ships other machines using same SSID, then the LED may not work on those machines.

Jeremy Szu (1):
  ALSA: hda/realtek: fix mute/micmute LEDs for HP machines

 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Cengiz Can July 25, 2022, 8:44 a.m. UTC | #1
On 25/07/2022 09:50, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1982716
> 
> [Impact]
> The audio mute key (F5) and mic-mute LED (F8) don't work on some HP 440/450/640/650 G9 laptops.
> 
> [Fix]
> The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple
> motherboard design and they are using different subsystem ID of audio
> codec. Add the same quirk for other MBs.
> 
> [Test]
> After applying the fix, the mute LEDs are working.
> 
> [Where problems could occur]
> It's low risk as it's specific ID for HP new machines. If the HP ships other machines using same SSID, then the LED may not work on those machines.
> 
> Jeremy Szu (1):
>   ALSA: hda/realtek: fix mute/micmute LEDs for HP machines

Acked-by: Cengiz Can <cengiz.can@canonical.com>

Thanks!
> 
>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
Stefan Bader July 25, 2022, 9:15 a.m. UTC | #2
On 25.07.22 08:50, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1982716
> 
> [Impact]
> The audio mute key (F5) and mic-mute LED (F8) don't work on some HP 440/450/640/650 G9 laptops.
> 
> [Fix]
> The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple
> motherboard design and they are using different subsystem ID of audio
> codec. Add the same quirk for other MBs.
> 
> [Test]
> After applying the fix, the mute LEDs are working.
> 
> [Where problems could occur]
> It's low risk as it's specific ID for HP new machines. If the HP ships other machines using same SSID, then the LED may not work on those machines.
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP machines
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 

The hwe-5.15 kernel does not need individual care, it is backported from the 
jammy kernel. For the oem-5.17 it is the hwe-5.17 kernel which would be 
sufficient (but there timing might be a reason to include it separately as it 
likely picks up the change quicker.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner July 26, 2022, 1:22 p.m. UTC | #3
On 7/25/22 00:50, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1982716
> 
> [Impact]
> The audio mute key (F5) and mic-mute LED (F8) don't work on some HP 440/450/640/650 G9 laptops.
> 
> [Fix]
> The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple
> motherboard design and they are using different subsystem ID of audio
> codec. Add the same quirk for other MBs.
> 
> [Test]
> After applying the fix, the mute LEDs are working.
> 
> [Where problems could occur]
> It's low risk as it's specific ID for HP new machines. If the HP ships other machines using same SSID, then the LED may not work on those machines.
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP machines
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Timo Aaltonen Aug. 4, 2022, 8:11 a.m. UTC | #4
Jeremy Szu kirjoitti 25.7.2022 klo 9.50:
> BugLink: https://bugs.launchpad.net/bugs/1982716
> 
> [Impact]
> The audio mute key (F5) and mic-mute LED (F8) don't work on some HP 440/450/640/650 G9 laptops.
> 
> [Fix]
> The HP ProBook 440/450 G9 and EliteBook 640/650 G9 have multiple
> motherboard design and they are using different subsystem ID of audio
> codec. Add the same quirk for other MBs.
> 
> [Test]
> After applying the fix, the mute LEDs are working.
> 
> [Where problems could occur]
> It's low risk as it's specific ID for HP new machines. If the HP ships other machines using same SSID, then the LED may not work on those machines.
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP machines
> 
>   sound/pci/hda/patch_realtek.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 

applied to oem-5.17, thanks