| Message ID | 20220712160812.435824-1-emil.renner.berthing@canonical.com |
|---|---|
| Headers | show |
| Series | Align more RISC-V config with other archs | expand |
Heya, This applied, but see comments below. On Tue, 12 Jul 2022 at 17:09, Emil Renner Berthing <emil.renner.berthing@canonical.com> wrote: > > @Dimitri All of these options except CONFIG_KEXEC_FILE were annotated in the > old linux-riscv tree, so let me know if you remember if there is a > reason these should be different on RISC-V. > > Emil Renner Berthing (7): > UBUNTU: [Config] Enable CONFIG_EFIVAR_FS on riscv64 Agree, originally when we started riscv there was no EFI boot (neither u-boot, nor edk2 one). Now that we do have and use uboot efi by default pretty much this should be built in now. > UBUNTU: [Config] Enable CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES on > riscv64 > UBUNTU: [Config] Enable CONFIG_STRICT_DEVMEM on riscv64 > UBUNTU: [Config] Enable CONFIG_VMAP_STACK on riscv64 I think in the past that would cause sifive boards or VMs fail at runtime. But all of that should have been fixed up upstream by now. And we will quickly find out if it is broken. > UBUNTU: [Config] Enable CONFIG_KEXEC_FILE on riscv64 Also, since this is now available on s390x, we should also enable it on s390x. As signed kernels are supported there too. Will enable it on s390x. > UBUNTU: [Config] Set CONFIG_MTD_PSTORE=m on riscv64 > UBUNTU: [Config] Set CONFIG_KFENCE_SAMPLE_INTERVAL=0 on riscv64 >
[Impact] * Some drivers are available on other architectures but not on RISC-V. * Some things might work or look differently in RISC-V. Eg. RISC-V has an additional terminal font enabled. * The RISC-V kernel benefits less from testing done on other architectures. [Test Plan] * Install the kernel on RISC-V and see what modules and features are enabled. * After aligning the RISC-V kernel config there should be fewer differences to other architectures. [Where problems could occur] * Some options that are disabled on other architectures may be needed on RISC-V. * Some modules or features may be broken on RISC-V. [Other Info] * When RISC-V config and annotations were added to the generic kernel the config was copied from the linux-riscv tree without modifications. This revealed a lot of differences to the other architectures and many of them were not annotated, so presumably the configs had just drifted apart over time. @Dimitri All of these options except CONFIG_KEXEC_FILE were annotated in the old linux-riscv tree, so let me know if you remember if there is a reason these should be different on RISC-V. Emil Renner Berthing (7): UBUNTU: [Config] Enable CONFIG_EFIVAR_FS on riscv64 UBUNTU: [Config] Enable CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES on riscv64 UBUNTU: [Config] Enable CONFIG_STRICT_DEVMEM on riscv64 UBUNTU: [Config] Enable CONFIG_VMAP_STACK on riscv64 UBUNTU: [Config] Enable CONFIG_KEXEC_FILE on riscv64 UBUNTU: [Config] Set CONFIG_MTD_PSTORE=m on riscv64 UBUNTU: [Config] Set CONFIG_KFENCE_SAMPLE_INTERVAL=0 on riscv64 debian.master/config/amd64/config.common.amd64 | 6 ------ debian.master/config/annotations | 18 +++++++++--------- debian.master/config/arm64/config.common.arm64 | 6 ------ debian.master/config/armhf/config.common.armhf | 6 ------ debian.master/config/config.common.ubuntu | 6 ++++++ .../config/ppc64el/config.common.ppc64el | 3 --- .../config/riscv64/config.common.riscv64 | 8 +------- debian.master/config/s390x/config.common.s390x | 4 ---- 8 files changed, 16 insertions(+), 41 deletions(-)