| Message ID | 20220705020901.11868-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa: asoc: amd: the internal mic can't be dedected on yellow carp machines | expand |
Hui Wang kirjoitti 5.7.2022 klo 5.08: > BugLink: https://bugs.launchpad.net/bugs/1980700 > > The fix is already in the upstream kernel v5.19-rc1, no need to > send the patches to unstable kernel. And our Jammy kernel (5.15.0) has > not merged the patchset of #1949245, this SRU is not applied to jammy > kernel too. > > [Impact] > On the AMD YC platforms, the internal mic can't be detected > and there is no internal mic for users to use. > > [Fix] > Backport 2 patches from mainline kernel to fix this problem. > > [Test] > boot the patched kernel on the machine which has updated BIOS, after > loging into the desktop, open the gnome-sound-setting, there is > internal mic, and could record sound via internal mic. > > > [Where problems could occur] > This only impacts intenal mic detection on AMD yc machines, it will > check the acpi variable first, if not detected, it will check the acpi > dmi table as before, so the regression possibility is very low, and we > already tested these patches on a couple of Lenovo YC machines, all > worked well. > > > Mario Limonciello (2): > ASoC: amd: Add driver data to acp6x machine driver > ASoC: amd: Add support for enabling DMIC on acp6x via _DSD > > sound/soc/amd/yc/acp6x-mach.c | 42 +++++++++++++++++++++++++++++++---- > 1 file changed, 38 insertions(+), 4 deletions(-) > oem-5.14 is about to EOL and get replaced by hwe-5.15, and you didn't send this for jammy?
On 7/5/22 15:08, Timo Aaltonen wrote: > Hui Wang kirjoitti 5.7.2022 klo 5.08: >> BugLink: https://bugs.launchpad.net/bugs/1980700 >> >> The fix is already in the upstream kernel v5.19-rc1, no need to >> send the patches to unstable kernel. And our Jammy kernel (5.15.0) has >> not merged the patchset of #1949245, this SRU is not applied to jammy >> kernel too. >> >> [Impact] >> On the AMD YC platforms, the internal mic can't be detected >> and there is no internal mic for users to use. >> >> [Fix] >> Backport 2 patches from mainline kernel to fix this problem. >> >> [Test] >> boot the patched kernel on the machine which has updated BIOS, after >> loging into the desktop, open the gnome-sound-setting, there is >> internal mic, and could record sound via internal mic. >> >> >> [Where problems could occur] >> This only impacts intenal mic detection on AMD yc machines, it will >> check the acpi variable first, if not detected, it will check the acpi >> dmi table as before, so the regression possibility is very low, and we >> already tested these patches on a couple of Lenovo YC machines, all >> worked well. >> >> >> Mario Limonciello (2): >> ASoC: amd: Add driver data to acp6x machine driver >> ASoC: amd: Add support for enabling DMIC on acp6x via _DSD >> >> sound/soc/amd/yc/acp6x-mach.c | 42 +++++++++++++++++++++++++++++++---- >> 1 file changed, 38 insertions(+), 4 deletions(-) >> > > oem-5.14 is about to EOL and get replaced by hwe-5.15, and you didn't > send this for jammy? The patchset can't be applied to jammy since #1949245 is not merged to jammy. > >
Hui Wang kirjoitti 5.7.2022 klo 10.23: > > On 7/5/22 15:08, Timo Aaltonen wrote: >> Hui Wang kirjoitti 5.7.2022 klo 5.08: >>> BugLink: https://bugs.launchpad.net/bugs/1980700 >>> >>> The fix is already in the upstream kernel v5.19-rc1, no need to >>> send the patches to unstable kernel. And our Jammy kernel (5.15.0) has >>> not merged the patchset of #1949245, this SRU is not applied to jammy >>> kernel too. >>> >>> [Impact] >>> On the AMD YC platforms, the internal mic can't be detected >>> and there is no internal mic for users to use. >>> >>> [Fix] >>> Backport 2 patches from mainline kernel to fix this problem. >>> >>> [Test] >>> boot the patched kernel on the machine which has updated BIOS, after >>> loging into the desktop, open the gnome-sound-setting, there is >>> internal mic, and could record sound via internal mic. >>> >>> >>> [Where problems could occur] >>> This only impacts intenal mic detection on AMD yc machines, it will >>> check the acpi variable first, if not detected, it will check the acpi >>> dmi table as before, so the regression possibility is very low, and we >>> already tested these patches on a couple of Lenovo YC machines, all >>> worked well. >>> >>> >>> Mario Limonciello (2): >>> ASoC: amd: Add driver data to acp6x machine driver >>> ASoC: amd: Add support for enabling DMIC on acp6x via _DSD >>> >>> sound/soc/amd/yc/acp6x-mach.c | 42 +++++++++++++++++++++++++++++++---- >>> 1 file changed, 38 insertions(+), 4 deletions(-) >>> >> >> oem-5.14 is about to EOL and get replaced by hwe-5.15, and you didn't >> send this for jammy? > The patchset can't be applied to jammy since #1949245 is not merged to > jammy. Well that's not a reason to not send for jammy, you already mentioned (which I didn't spot) on the header about the other bug not merged yet which should be enough.
On 7/5/22 15:29, Timo Aaltonen wrote: > Hui Wang kirjoitti 5.7.2022 klo 10.23: >> >> On 7/5/22 15:08, Timo Aaltonen wrote: >>> Hui Wang kirjoitti 5.7.2022 klo 5.08: >>>> BugLink: https://bugs.launchpad.net/bugs/1980700 >>>> >>>> The fix is already in the upstream kernel v5.19-rc1, no need to >>>> send the patches to unstable kernel. And our Jammy kernel (5.15.0) has >>>> not merged the patchset of #1949245, this SRU is not applied to jammy >>>> kernel too. >>>> >>>> [Impact] >>>> On the AMD YC platforms, the internal mic can't be detected >>>> and there is no internal mic for users to use. >>>> >>>> [Fix] >>>> Backport 2 patches from mainline kernel to fix this problem. >>>> >>>> [Test] >>>> boot the patched kernel on the machine which has updated BIOS, after >>>> loging into the desktop, open the gnome-sound-setting, there is >>>> internal mic, and could record sound via internal mic. >>>> >>>> >>>> [Where problems could occur] >>>> This only impacts intenal mic detection on AMD yc machines, it will >>>> check the acpi variable first, if not detected, it will check the acpi >>>> dmi table as before, so the regression possibility is very low, and we >>>> already tested these patches on a couple of Lenovo YC machines, all >>>> worked well. >>>> >>>> >>>> Mario Limonciello (2): >>>> ASoC: amd: Add driver data to acp6x machine driver >>>> ASoC: amd: Add support for enabling DMIC on acp6x via _DSD >>>> >>>> sound/soc/amd/yc/acp6x-mach.c | 42 >>>> +++++++++++++++++++++++++++++++---- >>>> 1 file changed, 38 insertions(+), 4 deletions(-) >>>> >>> >>> oem-5.14 is about to EOL and get replaced by hwe-5.15, and you >>> didn't send this for jammy? >> The patchset can't be applied to jammy since #1949245 is not merged >> to jammy. > > Well that's not a reason to not send for jammy, you already mentioned > (which I didn't spot) on the header about the other bug not merged yet > which should be enough. OK, will send v2 to include Jammy. thx. > >
Will send the v2 to include jammy and remove oem-5.14. On 7/5/22 10:08, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1980700 > > The fix is already in the upstream kernel v5.19-rc1, no need to > send the patches to unstable kernel. And our Jammy kernel (5.15.0) has > not merged the patchset of #1949245, this SRU is not applied to jammy > kernel too. > > [Impact] > On the AMD YC platforms, the internal mic can't be detected > and there is no internal mic for users to use. > > [Fix] > Backport 2 patches from mainline kernel to fix this problem. > > [Test] > boot the patched kernel on the machine which has updated BIOS, after > loging into the desktop, open the gnome-sound-setting, there is > internal mic, and could record sound via internal mic. > > > [Where problems could occur] > This only impacts intenal mic detection on AMD yc machines, it will > check the acpi variable first, if not detected, it will check the acpi > dmi table as before, so the regression possibility is very low, and we > already tested these patches on a couple of Lenovo YC machines, all > worked well. > > > Mario Limonciello (2): > ASoC: amd: Add driver data to acp6x machine driver > ASoC: amd: Add support for enabling DMIC on acp6x via _DSD > > sound/soc/amd/yc/acp6x-mach.c | 42 +++++++++++++++++++++++++++++++---- > 1 file changed, 38 insertions(+), 4 deletions(-) >