mbox series

[SRU,OEM-5.14/OEM-5.17,0/1] Fix oled brightness set above frame-average luminance on AMD

Message ID 20220616171854.3179-1-aaron.ma@canonical.com
Headers show
Series Fix oled brightness set above frame-average luminance on AMD | expand

Message

Aaron Ma June 16, 2022, 5:18 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1978986

[Impact]
The brightness is not changed obviously during 200 to 255.

[Fix]
max_cll defines the content light luminance for individual pixel.
max_fall defines frame-average level luminance.
Use max_fall value instead of max_cll as a limit for brightness control.

[Test]
Verified on AMD Cezanne, Barcelo and Rembrandt, also on LCD panel and
OLED panel. The brightness is changed more obivously on OLED panel, and
no affect on LCD panel.

[Where problems could occur]
Low risk, It may cause the max brightness can't be set.

Due to the schedule of OEM project, SRU this patch as SAUCE in OEM
kernels only.

Roman Li (1):
  drm/amd/display: Cap OLED brightness per max frame-average luminance

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

AceLan Kao June 17, 2022, 3:38 a.m. UTC | #1 
applied to oem-5.14 and oem-5.17, thanks
Timo Aaltonen July 5, 2022, 10:54 a.m. UTC | #2 
Aaron Ma kirjoitti 16.6.2022 klo 20.18:
> BugLink: https://bugs.launchpad.net/bugs/1978986
> 
> [Impact]
> The brightness is not changed obviously during 200 to 255.
> 
> [Fix]
> max_cll defines the content light luminance for individual pixel.
> max_fall defines frame-average level luminance.
> Use max_fall value instead of max_cll as a limit for brightness control.
> 
> [Test]
> Verified on AMD Cezanne, Barcelo and Rembrandt, also on LCD panel and
> OLED panel. The brightness is changed more obivously on OLED panel, and
> no affect on LCD panel.
> 
> [Where problems could occur]
> Low risk, It may cause the max brightness can't be set.
> 
> Due to the schedule of OEM project, SRU this patch as SAUCE in OEM
> kernels only.
> 
> Roman Li (1):
>    drm/amd/display: Cap OLED brightness per max frame-average luminance
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

I don't see this sent for jammy, we need it there for oem-5.14->hwe-5.15 
migration, so please send it.