| Message ID | 20220616063648.7443-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa/hda: mute led can't work on the lenovo machine with cs35l41 s-codec | expand |
applied to oem-5.14, thanks
On 6/16/22 00:36, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1978915 > > The fix is already in the upstream kernel stable-v5.17, no need to > send this patch to oem-5.17 and unstable kernels. > > [Impact] > After we apply the cs35l41 s-codec patchset to the oem-5.14 and jammy > kernels, the mute led can't work anymore. > > [Fix] > Backport a patch from mainline kernel to fix this regression > > [Test] > boot the patched kernel, press mute hotkey, the speaker is muted > and the mute led is on, press the mute hotkey again, the speaker > is unmuted and the mute led is off. > > > [Where problems could occur] > After merging this patch, it is possible to affect the machines which > apply the ALC287_FIXUP_CS35L41_I2C_2, but the regression possibility > is very low since hda_fixup_thinkpad_acpi() could check if the quirk > is suitable for the running machine. And we did test, all machines > could work well. > > > > Hui Wang (1): > ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec > > sound/pci/hda/patch_realtek.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> On Wed, Jun 15, 2022 at 11:39 PM Hui Wang <hui.wang@canonical.com> wrote: > BugLink: https://bugs.launchpad.net/bugs/1978915 > > The fix is already in the upstream kernel stable-v5.17, no need to > send this patch to oem-5.17 and unstable kernels. > > [Impact] > After we apply the cs35l41 s-codec patchset to the oem-5.14 and jammy > kernels, the mute led can't work anymore. > > [Fix] > Backport a patch from mainline kernel to fix this regression > > [Test] > boot the patched kernel, press mute hotkey, the speaker is muted > and the mute led is on, press the mute hotkey again, the speaker > is unmuted and the mute led is off. > > > [Where problems could occur] > After merging this patch, it is possible to affect the machines which > apply the ALC287_FIXUP_CS35L41_I2C_2, but the regression possibility > is very low since hda_fixup_thinkpad_acpi() could check if the quirk > is suitable for the running machine. And we did test, all machines > could work well. > > > > Hui Wang (1): > ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec > > sound/pci/hda/patch_realtek.c | 2 ++ > 1 file changed, 2 insertions(+) > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
On 16.06.22 08:36, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1978915 > > The fix is already in the upstream kernel stable-v5.17, no need to > send this patch to oem-5.17 and unstable kernels. > > [Impact] > After we apply the cs35l41 s-codec patchset to the oem-5.14 and jammy > kernels, the mute led can't work anymore. > > [Fix] > Backport a patch from mainline kernel to fix this regression > > [Test] > boot the patched kernel, press mute hotkey, the speaker is muted > and the mute led is on, press the mute hotkey again, the speaker > is unmuted and the mute led is off. > > > [Where problems could occur] > After merging this patch, it is possible to affect the machines which > apply the ALC287_FIXUP_CS35L41_I2C_2, but the regression possibility > is very low since hda_fixup_thinkpad_acpi() could check if the quirk > is suitable for the running machine. And we did test, all machines > could work well. > > > > Hui Wang (1): > ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec > > sound/pci/hda/patch_realtek.c | 2 ++ > 1 file changed, 2 insertions(+) > Applied to jammy:linux/master-next. Thanks. -Stefan