From patchwork Tue Apr 12 07:17:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Bader X-Patchwork-Id: 1616091 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=NJl/6NNT; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KcxrX264wz9sGG for ; Tue, 12 Apr 2022 17:17:47 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1neAmO-0006dE-7h; Tue, 12 Apr 2022 07:17:36 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1neAmN-0006d6-9M for kernel-team@lists.ubuntu.com; Tue, 12 Apr 2022 07:17:35 +0000 Received: from canonical.com (1.general.smb.uk.vpn [10.172.193.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 034E73F637 for ; Tue, 12 Apr 2022 07:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1649747855; bh=35rcOXKg04eglRZspp1BgkJjrTgnq8p5KCBUNXWi3iM=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=NJl/6NNT4d/UkILf9YrZUamldkwnxMlobx8f/ef7WRz1I6J4T5wXrzYv/67OHeu+A Px9XT+QAKk1a80QzcbsB+XjK85UH5MZ4GaravAgE/gIL6Z4EEdtmr0vykxUIEDASSR uTWjew0pA5By8KLNhIjpRezZnK2ZKP0+62Gn6VKcthr/wDVrSErpRj/A1X21/BxiGn 7l1yRy4NMlgKJZ/s1MjomB72GlyuMPHyPVfNlv1AKjcfvwDYkw+agHsf1VnIGlLdvT 8miGEiJig9lqe7eSweocVCD34CmvURLQCGDYjmvA7r1/UklhtKCwtW9cE6YAB5VGOa EHiD/DWBn7FMw== From: Stefan Bader To: kernel-team@lists.ubuntu.com Subject: [SRU I/F 0/1] Fix xfrm interface no longer changeable Date: Tue, 12 Apr 2022 09:17:33 +0200 Message-Id: <20220412071734.11252-1-stefan.bader@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1968591 [Impact] An xfrm interface cannot be changed any more since Ubuntu-hwe-5.4-5.4.0-105 (also Impish, see additional notes). In fact, the regression has been introduced by this backport: https://kernel.ubuntu.com/git/ubuntu/ubuntu-focal.git/commit/?id=13a02539b135 It has been fixed upstream by this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6d0d95a1c2b0 [Test Case] root@dut-vm:~# ip link add foo type xfrm if_id 1234 dev lo root@dut-vm:~# ip link change foo type xfrm if_id 1234 dev ntfp1 Error: if_id must be non zero. root@dut-vm:~# uname -a Linux dut-vm 5.4.0-107-generic #121~18.04.1-Ubuntu SMP Thu Mar 24 17:21:33 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux root@dut-vm:~# [Regression Potential] The patch is trivial, the potential regressions are low. Additional notes: The change which introduces the issue also exists in Impish(5.13.0-40.45) and would need the same fix. For Focal the fix would be included in upstream stable v5.4.183 but that would not make it into next cycle. Acked-by: Tim Gardner