| Message ID | 20220224070236.178340-1-vicamo.yang@canonical.com |
|---|---|
| Headers | show |
| Series | Fix wakeup interrupts handling | expand |
You-Sheng Yang kirjoitti 24.2.2022 klo 9.02: > BugLink: https://bugs.launchpad.net/bugs/1961739 > > [Impact] > > On some platforms, PS/2 keyboard cannot wake system up from s2idle. > > [Fix] > > Mainline commit cb1f65c1e142 ("PM: s2idle: ACPI: Fix wakeup interrupts > handling") picks up the missed wakeup interrupt. > > [Test Case] > > Use button press on PS/2 keyboard to wake suspended system. > > [Where problems could occur] > > It may still discard irqs under some very rare corner cases that are not > yet identified, but the implementation can be extended easily when > necessary. > > [Other Info] > > This affects 5.4+ kernels and has been proposed for linux-stable. While > this is merged in v5.17-rc4, linux-unstable will have this soon so > nomination is skipped. > > Rafael J. Wysocki (1): > PM: s2idle: ACPI: Fix wakeup interrupts handling > > drivers/acpi/sleep.c | 1 + > drivers/base/power/wakeup.c | 41 ++++++++++++++++++++++++++++++------- > include/linux/suspend.h | 4 ++-- > kernel/power/main.c | 5 ++++- > kernel/power/process.c | 2 +- > kernel/power/suspend.c | 2 -- > 6 files changed, 42 insertions(+), 13 deletions(-) > this got applied via stable backports, likely for other kernels too
On Thu, Feb 24, 2022 at 03:02:35PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1961739
Already got this patch via stable v5.15.24.
On 24.02.22 08:02, You-Sheng Yang wrote: > BugLink: https://bugs.launchpad.net/bugs/1961739 > > [Impact] > > On some platforms, PS/2 keyboard cannot wake system up from s2idle. > > [Fix] > > Mainline commit cb1f65c1e142 ("PM: s2idle: ACPI: Fix wakeup interrupts > handling") picks up the missed wakeup interrupt. > > [Test Case] > > Use button press on PS/2 keyboard to wake suspended system. > > [Where problems could occur] > > It may still discard irqs under some very rare corner cases that are not > yet identified, but the implementation can be extended easily when > necessary. > > [Other Info] > > This affects 5.4+ kernels and has been proposed for linux-stable. While > this is merged in v5.17-rc4, linux-unstable will have this soon so > nomination is skipped. > > Rafael J. Wysocki (1): > PM: s2idle: ACPI: Fix wakeup interrupts handling > > drivers/acpi/sleep.c | 1 + > drivers/base/power/wakeup.c | 41 ++++++++++++++++++++++++++++++------- > include/linux/suspend.h | 4 ++-- > kernel/power/main.c | 5 ++++- > kernel/power/process.c | 2 +- > kernel/power/suspend.c | 2 -- > 6 files changed, 42 insertions(+), 13 deletions(-) > Applied to impish:linux/master-next. Thanks. -Stefan
BugLink: https://bugs.launchpad.net/bugs/1961739 [Impact] On some platforms, PS/2 keyboard cannot wake system up from s2idle. [Fix] Mainline commit cb1f65c1e142 ("PM: s2idle: ACPI: Fix wakeup interrupts handling") picks up the missed wakeup interrupt. [Test Case] Use button press on PS/2 keyboard to wake suspended system. [Where problems could occur] It may still discard irqs under some very rare corner cases that are not yet identified, but the implementation can be extended easily when necessary. [Other Info] This affects 5.4+ kernels and has been proposed for linux-stable. While this is merged in v5.17-rc4, linux-unstable will have this soon so nomination is skipped. Rafael J. Wysocki (1): PM: s2idle: ACPI: Fix wakeup interrupts handling drivers/acpi/sleep.c | 1 + drivers/base/power/wakeup.c | 41 ++++++++++++++++++++++++++++++------- include/linux/suspend.h | 4 ++-- kernel/power/main.c | 5 ++++- kernel/power/process.c | 2 +- kernel/power/suspend.c | 2 -- 6 files changed, 42 insertions(+), 13 deletions(-)