mbox series

[J,v2,0/2] Long kernel command line on s390x (LP: 1960580)

Message ID 20220217190247.1003163-1-frank.heimes@canonical.com
Headers show
Series Long kernel command line on s390x (LP: 1960580) | expand

Message

Frank Heimes Feb. 17, 2022, 7:02 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1960580

Allow to handle command lines with a length of up to 4096 bytes by kernel.
It happened in the past that our supported command line size of 896 bytes
was sometimes too short - while x86, powerpc, and arm each support 2048 bytes.

This requires:
 - an ABI interface to the kernel image, so that tools can figure out if the
   kernel supports large command lines (might be a feature bitmap at a fixed
   location)
 - zipl, genprotimg, qemu, kexec-tools and changes (depending on the kernel
   side implementation)
 - in-kernel ipl support changes (IPL from reader)

v2: converted 277c8389386e ("390/kexec_file: move kernel image size check")
    into a backport, due to required context adjustments

Sven Schnelle (2):
  s390/kexec_file: move kernel image size check
  s390: support command lines longer than 896 bytes

 arch/s390/boot/head.S                 | 37 +++++++++------------------
 arch/s390/boot/ipl_parm.c             |  4 +--
 arch/s390/include/asm/setup.h         |  8 +++---
 arch/s390/include/uapi/asm/setup.h    |  2 --
 arch/s390/kernel/asm-offsets.c        |  1 +
 arch/s390/kernel/early.c              |  2 +-
 arch/s390/kernel/machine_kexec_file.c | 35 +++++++++++++------------
 7 files changed, 39 insertions(+), 50 deletions(-)

Comments

Krzysztof Kozlowski Feb. 18, 2022, 7:47 a.m. UTC | #1
On 17/02/2022 20:02, frank.heimes@canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1960580
> 
> Allow to handle command lines with a length of up to 4096 bytes by kernel.
> It happened in the past that our supported command line size of 896 bytes
> was sometimes too short - while x86, powerpc, and arm each support 2048 bytes.
> 
> This requires:
>  - an ABI interface to the kernel image, so that tools can figure out if the
>    kernel supports large command lines (might be a feature bitmap at a fixed
>    location)
>  - zipl, genprotimg, qemu, kexec-tools and changes (depending on the kernel
>    side implementation)
>  - in-kernel ipl support changes (IPL from reader)
> 
> v2: converted 277c8389386e ("390/kexec_file: move kernel image size check")
>     into a backport, due to required context adjustments
> 
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof
Tim Gardner Feb. 21, 2022, 3:51 p.m. UTC | #2
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 2/17/22 12:02 PM, frank.heimes@canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1960580
> 
> Allow to handle command lines with a length of up to 4096 bytes by kernel.
> It happened in the past that our supported command line size of 896 bytes
> was sometimes too short - while x86, powerpc, and arm each support 2048 bytes.
> 
> This requires:
>   - an ABI interface to the kernel image, so that tools can figure out if the
>     kernel supports large command lines (might be a feature bitmap at a fixed
>     location)
>   - zipl, genprotimg, qemu, kexec-tools and changes (depending on the kernel
>     side implementation)
>   - in-kernel ipl support changes (IPL from reader)
> 
> v2: converted 277c8389386e ("390/kexec_file: move kernel image size check")
>      into a backport, due to required context adjustments
> 
> Sven Schnelle (2):
>    s390/kexec_file: move kernel image size check
>    s390: support command lines longer than 896 bytes
> 
>   arch/s390/boot/head.S                 | 37 +++++++++------------------
>   arch/s390/boot/ipl_parm.c             |  4 +--
>   arch/s390/include/asm/setup.h         |  8 +++---
>   arch/s390/include/uapi/asm/setup.h    |  2 --
>   arch/s390/kernel/asm-offsets.c        |  1 +
>   arch/s390/kernel/early.c              |  2 +-
>   arch/s390/kernel/machine_kexec_file.c | 35 +++++++++++++------------
>   7 files changed, 39 insertions(+), 50 deletions(-)
>
Paolo Pisati March 7, 2022, 12:04 p.m. UTC | #3
On Thu, Feb 17, 2022 at 08:02:45PM +0100, frank.heimes@canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1960580