From patchwork Wed Feb 16 15:29:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Lane X-Patchwork-Id: 1593784 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=uHdoXZ/r; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JzMMY0w3Gz9sCD for ; Thu, 17 Feb 2022 02:29:44 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1nKMFL-0003Z9-DB; Wed, 16 Feb 2022 15:29:35 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1nKMFK-0003Z2-IU for kernel-team@lists.ubuntu.com; Wed, 16 Feb 2022 15:29:34 +0000 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 39D5A4060A for ; Wed, 16 Feb 2022 15:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645025374; bh=LT71FItDrJUPrzRstGlq2F4UZQ3oh2RLMUbVwZCJCFU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=uHdoXZ/rT76g5noFRQ/1t4dZNBgXhp5v56Flm0B5fgeVuXDz46nZ6i4MMPC1Gy6QP 9DN1/svEZvlhJVQQxQZL33kwgDmg87jHOWDGmRPdo0nMjx/16dkAx+puTOT4T0M8mp +KwS8CB1uhK6jdSmXuCOFnoQLaEA5/Aj+aBv48aFi5GSiYZmWecMjW6T5L3NBctqoG Y+J91IgAfP32Sm/6odag7byLkN2T5+yLVu08gNWfSP7DZCiRjjlxkD1c3oe0Kg8r9R MVgJd/fa5zcaZqBGRZzyd/+NEtbBpyTfdFFYp7dyzsvkdsEOUXoT5PMpT1VZQX8Pmg DOZLaxvdReszg== Received: by mail-qv1-f69.google.com with SMTP id a12-20020a056214062c00b0042c2f3fca04so2022389qvx.21 for ; Wed, 16 Feb 2022 07:29:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=LT71FItDrJUPrzRstGlq2F4UZQ3oh2RLMUbVwZCJCFU=; b=zK5RArWSQECcUfb23iNvkG96O4yMpjHQu6W37pensY15UOma/5TQZI7UtV9121Nmr8 gcn/RLb2SaKZ+UuqeCTEvMs7H0gJt2pgiwZfLGvgRkENTsDh85MReVh/iUFOkE3YN2+g IbBvxpBKd7K0wxnQqDhczX5G8dGVJdsUGrxO8bnV0kebGEkM9vA/wWwtt9TrpON4y3Y3 3RV9+06/9Hu1DKYQRYCDddQ/bIPeJod0PSmkJU+BrCtGgv5miSYiGPxJxFTDSuc4FEe+ i0DV1PrcJ8mhiy40ba/EcsDx+7wXALPXnw/AWpuM1bXxBx47DRwAt9SUzvDbIvYdPrKf LjUw== X-Gm-Message-State: AOAM533NXniffvygmN6Xh0bvJZQB1IseJ5PgwZqU8lW8MJuD3xjU3BeS b2D2zSPH3B14bhEczytW4NxlmpPG8vAgiDz5ecewwnEtZ4lSHwDodky0GNh7wvwhXh7385CzW7g L75Y/Qjj4YSmwVUX2/JjkKmtzYN484OpBmTFyovvFWA== X-Received: by 2002:ad4:5bc3:0:b0:42d:7513:e520 with SMTP id t3-20020ad45bc3000000b0042d7513e520mr2267053qvt.40.1645025372730; Wed, 16 Feb 2022 07:29:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhGUjn4HOR/elPUtO63JjRI9LeGM5QmnOjZ3UFrd0HIACPGjXHKBr7pWCON6k/WL4mAC0jUg== X-Received: by 2002:ad4:5bc3:0:b0:42d:7513:e520 with SMTP id t3-20020ad45bc3000000b0042d7513e520mr2267030qvt.40.1645025372320; Wed, 16 Feb 2022 07:29:32 -0800 (PST) Received: from localhost.localdomain ([71.217.161.186]) by smtp.gmail.com with ESMTPSA id de43sm18286342qkb.4.2022.02.16.07.29.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 07:29:31 -0800 (PST) From: Jeff Lane To: kernel-team@lists.ubuntu.com Subject: [SRU][I][PATCH 0/1] PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU Date: Wed, 16 Feb 2022 10:29:28 -0500 Message-Id: <20220216152929.2145997-1-jeffrey.lane@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1937295 [Impact] A hardware partner discovered they were unable to install Ubuntu on some servers using VROC setups. They point to this issue involving DMAR that is blocking discovery of the VROC RAID devices: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2565e5b69c44b4e42469afea3cc5a97e74d1ed45 `git bisect` points to this offending commit ee81ee84f873 ("PCI: vmd: Disable MSI-X remapping when possible"), which disables VMD MSI remapping. The IOMMU hardware blocks the compatibility format interrupt request because Interrupt Remapping Enable Status (IRES) and Extended Interrupt Mode Enable (EIME) are enabled. Please refer to section "5.1.4 Interrupt-Remapping Hardware Operation" in Intel VT-d spec. To fix the issue, VMD driver still enables the interrupt remapping irrespective of VMD_FEAT_CAN_BYPASS_MSI_REMAP if the IOMMU subsystem enables the interrupt remapping. [Fix] 2565e5b69c44 PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU This is a simple patch that picks cleanly from 5.16 [Test Plan] 1. Boot into VRoC controller in uEFI Setup and create a raid10 disk. 2. Install affected Ubuntu release on the RAID10. 3. The system hangs at "Partitions formatting 33%". [Where problems could occur] The fix itself is a very small change to drivers/pci/controller/vmd.c and problems should not occur. The root cause was discovered by the hardware partner's engineers, who tested and submitted it upstream where it was accepted and landed in 5.16. That said, I doubt this will fix 18.04.6 as it would require a respin to get the patched kernel onto the ISO. 20.04 should pick it up in ISO in 20.04.5, so there could still be the initial issue since those ISOs would be lacking the patched kernel. [Other Info] As noted, this would need to not only land in the kernel but land in the kernel in the ISO to resolve the issue in the installation process. I'll bring this back as far as Focal with the expectation that while 20.04.4 is too late, it will be present using the GA kernel in 20.04.5 later on. Adrian Huang (1): PCI: vmd: Do not disable MSI-X remapping if interrupt remapping is enabled by IOMMU drivers/pci/controller/vmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Tim Gardner Acked-by: Krzysztof Kozlowski