| Message ID | 20220126185812.300679-1-krzysztof.kozlowski@canonical.com |
|---|---|
| Headers | show |
| Series | Add rtla to realtime | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> Would this tool have sufficient utility to warrant inclusion in the master branch ? rtg On 1/26/22 11:57 AM, Krzysztof Kozlowski wrote: > BugLink: https://bugs.launchpad.net/bugs/1959130 > > Backport rtla from v5.17-rc1 and include it in realtime kernel. > > Why? Because it is a usefull tool for debugging and analyzing realtime > characteristics or issues of the kernel. > > Best regards, > Krzysztof > > > Daniel Bristot de Oliveira (14): > rtla: Real-Time Linux Analysis tool > rtla: Helper functions for rtla > rtla: Add osnoise tool > rtla/osnoise: Add osnoise top mode > rtla/osnoise: Add the hist mode > rtla: Add timerlat tool and timelart top mode > rtla/timerlat: Add timerlat hist mode > rtla: Add Documentation > rtla: Add rtla osnoise man page > rtla: Add rtla osnoise top documentation > rtla: Add rtla osnoise hist documentation > rtla: Add rtla timerlat documentation > rtla: Add rtla timerlat top documentation > rtla: Add rtla timerlat hist documentation > > Krzysztof Kozlowski (1): > UBUNTU: [Packaging] realtime: include rtla in tools package > > Documentation/tools/rtla/Makefile | 41 + > Documentation/tools/rtla/common_appendix.rst | 12 + > .../tools/rtla/common_hist_options.rst | 23 + > Documentation/tools/rtla/common_options.rst | 28 + > .../tools/rtla/common_osnoise_description.rst | 8 + > .../tools/rtla/common_osnoise_options.rst | 17 + > .../rtla/common_timerlat_description.rst | 10 + > .../tools/rtla/common_timerlat_options.rst | 16 + > .../tools/rtla/common_top_options.rst | 3 + > .../tools/rtla/rtla-osnoise-hist.rst | 66 ++ > Documentation/tools/rtla/rtla-osnoise-top.rst | 61 ++ > Documentation/tools/rtla/rtla-osnoise.rst | 59 ++ > .../tools/rtla/rtla-timerlat-hist.rst | 106 +++ > .../tools/rtla/rtla-timerlat-top.rst | 145 +++ > Documentation/tools/rtla/rtla-timerlat.rst | 57 ++ > Documentation/tools/rtla/rtla.rst | 48 + > debian.realtime/control.stub.in | 5 +- > debian/rules.d/2-binary-arch.mk | 4 + > debian/rules.d/3-binary-indep.mk | 1 + > tools/tracing/rtla/Makefile | 102 ++ > tools/tracing/rtla/README.txt | 36 + > tools/tracing/rtla/src/osnoise.c | 875 ++++++++++++++++++ > tools/tracing/rtla/src/osnoise.h | 91 ++ > tools/tracing/rtla/src/osnoise_hist.c | 801 ++++++++++++++++ > tools/tracing/rtla/src/osnoise_top.c | 579 ++++++++++++ > tools/tracing/rtla/src/rtla.c | 87 ++ > tools/tracing/rtla/src/timerlat.c | 72 ++ > tools/tracing/rtla/src/timerlat.h | 4 + > tools/tracing/rtla/src/timerlat_hist.c | 822 ++++++++++++++++ > tools/tracing/rtla/src/timerlat_top.c | 618 +++++++++++++ > tools/tracing/rtla/src/trace.c | 192 ++++ > tools/tracing/rtla/src/trace.h | 27 + > tools/tracing/rtla/src/utils.c | 433 +++++++++ > tools/tracing/rtla/src/utils.h | 56 ++ > 34 files changed, 5504 insertions(+), 1 deletion(-) > create mode 100644 Documentation/tools/rtla/Makefile > create mode 100644 Documentation/tools/rtla/common_appendix.rst > create mode 100644 Documentation/tools/rtla/common_hist_options.rst > create mode 100644 Documentation/tools/rtla/common_options.rst > create mode 100644 Documentation/tools/rtla/common_osnoise_description.rst > create mode 100644 Documentation/tools/rtla/common_osnoise_options.rst > create mode 100644 Documentation/tools/rtla/common_timerlat_description.rst > create mode 100644 Documentation/tools/rtla/common_timerlat_options.rst > create mode 100644 Documentation/tools/rtla/common_top_options.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise-hist.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise-top.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat-hist.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat-top.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat.rst > create mode 100644 Documentation/tools/rtla/rtla.rst > create mode 100644 tools/tracing/rtla/Makefile > create mode 100644 tools/tracing/rtla/README.txt > create mode 100644 tools/tracing/rtla/src/osnoise.c > create mode 100644 tools/tracing/rtla/src/osnoise.h > create mode 100644 tools/tracing/rtla/src/osnoise_hist.c > create mode 100644 tools/tracing/rtla/src/osnoise_top.c > create mode 100644 tools/tracing/rtla/src/rtla.c > create mode 100644 tools/tracing/rtla/src/timerlat.c > create mode 100644 tools/tracing/rtla/src/timerlat.h > create mode 100644 tools/tracing/rtla/src/timerlat_hist.c > create mode 100644 tools/tracing/rtla/src/timerlat_top.c > create mode 100644 tools/tracing/rtla/src/trace.c > create mode 100644 tools/tracing/rtla/src/trace.h > create mode 100644 tools/tracing/rtla/src/utils.c > create mode 100644 tools/tracing/rtla/src/utils.h >
On 27/01/2022 14:04, Tim Gardner wrote: > Acked-by: Tim Gardner <tim.gardner@canonical.com> > > Would this tool have sufficient utility to warrant inclusion in the > master branch ? It would, but I forgot to mention in the cover letter that it depends on development version of libtracefs library. The latest released libtracefs is v1.2.5 but the "rtla" requires features from current Git repo, coming to v1.3.0 at some point. I don't think the tool is useful enough to bump libtracefs package to a git/intermediate version. > > rtg > > On 1/26/22 11:57 AM, Krzysztof Kozlowski wrote: >> BugLink: https://bugs.launchpad.net/bugs/1959130 >> >> Backport rtla from v5.17-rc1 and include it in realtime kernel. >> >> Why? Because it is a usefull tool for debugging and analyzing realtime >> characteristics or issues of the kernel. >> Best regards, Krzysztof
On 1/26/22 13:57, Krzysztof Kozlowski wrote: > BugLink: https://bugs.launchpad.net/bugs/1959130 > > Backport rtla from v5.17-rc1 and include it in realtime kernel. > > Why? Because it is a usefull tool for debugging and analyzing realtime > characteristics or issues of the kernel. > > Best regards, > Krzysztof > > > Daniel Bristot de Oliveira (14): > rtla: Real-Time Linux Analysis tool > rtla: Helper functions for rtla > rtla: Add osnoise tool > rtla/osnoise: Add osnoise top mode > rtla/osnoise: Add the hist mode > rtla: Add timerlat tool and timelart top mode > rtla/timerlat: Add timerlat hist mode > rtla: Add Documentation > rtla: Add rtla osnoise man page > rtla: Add rtla osnoise top documentation > rtla: Add rtla osnoise hist documentation > rtla: Add rtla timerlat documentation > rtla: Add rtla timerlat top documentation > rtla: Add rtla timerlat hist documentation > > Krzysztof Kozlowski (1): > UBUNTU: [Packaging] realtime: include rtla in tools package > > Documentation/tools/rtla/Makefile | 41 + > Documentation/tools/rtla/common_appendix.rst | 12 + > .../tools/rtla/common_hist_options.rst | 23 + > Documentation/tools/rtla/common_options.rst | 28 + > .../tools/rtla/common_osnoise_description.rst | 8 + > .../tools/rtla/common_osnoise_options.rst | 17 + > .../rtla/common_timerlat_description.rst | 10 + > .../tools/rtla/common_timerlat_options.rst | 16 + > .../tools/rtla/common_top_options.rst | 3 + > .../tools/rtla/rtla-osnoise-hist.rst | 66 ++ > Documentation/tools/rtla/rtla-osnoise-top.rst | 61 ++ > Documentation/tools/rtla/rtla-osnoise.rst | 59 ++ > .../tools/rtla/rtla-timerlat-hist.rst | 106 +++ > .../tools/rtla/rtla-timerlat-top.rst | 145 +++ > Documentation/tools/rtla/rtla-timerlat.rst | 57 ++ > Documentation/tools/rtla/rtla.rst | 48 + > debian.realtime/control.stub.in | 5 +- > debian/rules.d/2-binary-arch.mk | 4 + > debian/rules.d/3-binary-indep.mk | 1 + > tools/tracing/rtla/Makefile | 102 ++ > tools/tracing/rtla/README.txt | 36 + > tools/tracing/rtla/src/osnoise.c | 875 ++++++++++++++++++ > tools/tracing/rtla/src/osnoise.h | 91 ++ > tools/tracing/rtla/src/osnoise_hist.c | 801 ++++++++++++++++ > tools/tracing/rtla/src/osnoise_top.c | 579 ++++++++++++ > tools/tracing/rtla/src/rtla.c | 87 ++ > tools/tracing/rtla/src/timerlat.c | 72 ++ > tools/tracing/rtla/src/timerlat.h | 4 + > tools/tracing/rtla/src/timerlat_hist.c | 822 ++++++++++++++++ > tools/tracing/rtla/src/timerlat_top.c | 618 +++++++++++++ > tools/tracing/rtla/src/trace.c | 192 ++++ > tools/tracing/rtla/src/trace.h | 27 + > tools/tracing/rtla/src/utils.c | 433 +++++++++ > tools/tracing/rtla/src/utils.h | 56 ++ > 34 files changed, 5504 insertions(+), 1 deletion(-) > create mode 100644 Documentation/tools/rtla/Makefile > create mode 100644 Documentation/tools/rtla/common_appendix.rst > create mode 100644 Documentation/tools/rtla/common_hist_options.rst > create mode 100644 Documentation/tools/rtla/common_options.rst > create mode 100644 Documentation/tools/rtla/common_osnoise_description.rst > create mode 100644 Documentation/tools/rtla/common_osnoise_options.rst > create mode 100644 Documentation/tools/rtla/common_timerlat_description.rst > create mode 100644 Documentation/tools/rtla/common_timerlat_options.rst > create mode 100644 Documentation/tools/rtla/common_top_options.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise-hist.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise-top.rst > create mode 100644 Documentation/tools/rtla/rtla-osnoise.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat-hist.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat-top.rst > create mode 100644 Documentation/tools/rtla/rtla-timerlat.rst > create mode 100644 Documentation/tools/rtla/rtla.rst > create mode 100644 tools/tracing/rtla/Makefile > create mode 100644 tools/tracing/rtla/README.txt > create mode 100644 tools/tracing/rtla/src/osnoise.c > create mode 100644 tools/tracing/rtla/src/osnoise.h > create mode 100644 tools/tracing/rtla/src/osnoise_hist.c > create mode 100644 tools/tracing/rtla/src/osnoise_top.c > create mode 100644 tools/tracing/rtla/src/rtla.c > create mode 100644 tools/tracing/rtla/src/timerlat.c > create mode 100644 tools/tracing/rtla/src/timerlat.h > create mode 100644 tools/tracing/rtla/src/timerlat_hist.c > create mode 100644 tools/tracing/rtla/src/timerlat_top.c > create mode 100644 tools/tracing/rtla/src/trace.c > create mode 100644 tools/tracing/rtla/src/trace.h > create mode 100644 tools/tracing/rtla/src/utils.c > create mode 100644 tools/tracing/rtla/src/utils.h > Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com>
On 1/27/22 10:29, Krzysztof Kozlowski wrote: > On 27/01/2022 14:04, Tim Gardner wrote: >> Acked-by: Tim Gardner<tim.gardner@canonical.com> >> >> Would this tool have sufficient utility to warrant inclusion in the >> master branch ? > It would, but I forgot to mention in the cover letter that it depends on > development version of libtracefs library. The latest released > libtracefs is v1.2.5 but the "rtla" requires features from current Git > repo, coming to v1.3.0 at some point. > > I don't think the tool is useful enough to bump libtracefs package to a > git/intermediate version. libtracefs-1.3 was released, so hopefully this will increase the possibility of merging Krzysztof's RTLA patches. > >> rtg >> >> On 1/26/22 11:57 AM, Krzysztof Kozlowski wrote: >>> BugLink:https://bugs.launchpad.net/bugs/1959130 >>> >>> Backport rtla from v5.17-rc1 and include it in realtime kernel. >>> >>> Why? Because it is a usefull tool for debugging and analyzing realtime >>> characteristics or issues of the kernel. >>> > Best regards, > Krzysztof >
I did not add an ACK to the subject line, so I will do that now. The RTLA tool will be helpful to debug existing issues currently reported against the realtime kernel. Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com> On 1/31/22 18:11, Joseph Salisbury wrote: > > > On 1/26/22 13:57, Krzysztof Kozlowski wrote: >> BugLink: https://bugs.launchpad.net/bugs/1959130 >> >> Backport rtla from v5.17-rc1 and include it in realtime kernel. >> >> Why? Because it is a usefull tool for debugging and analyzing realtime >> characteristics or issues of the kernel. >> >> Best regards, >> Krzysztof >> >> >> Daniel Bristot de Oliveira (14): >> rtla: Real-Time Linux Analysis tool >> rtla: Helper functions for rtla >> rtla: Add osnoise tool >> rtla/osnoise: Add osnoise top mode >> rtla/osnoise: Add the hist mode >> rtla: Add timerlat tool and timelart top mode >> rtla/timerlat: Add timerlat hist mode >> rtla: Add Documentation >> rtla: Add rtla osnoise man page >> rtla: Add rtla osnoise top documentation >> rtla: Add rtla osnoise hist documentation >> rtla: Add rtla timerlat documentation >> rtla: Add rtla timerlat top documentation >> rtla: Add rtla timerlat hist documentation >> >> Krzysztof Kozlowski (1): >> UBUNTU: [Packaging] realtime: include rtla in tools package >> >> Documentation/tools/rtla/Makefile | 41 + >> Documentation/tools/rtla/common_appendix.rst | 12 + >> .../tools/rtla/common_hist_options.rst | 23 + >> Documentation/tools/rtla/common_options.rst | 28 + >> .../tools/rtla/common_osnoise_description.rst | 8 + >> .../tools/rtla/common_osnoise_options.rst | 17 + >> .../rtla/common_timerlat_description.rst | 10 + >> .../tools/rtla/common_timerlat_options.rst | 16 + >> .../tools/rtla/common_top_options.rst | 3 + >> .../tools/rtla/rtla-osnoise-hist.rst | 66 ++ >> Documentation/tools/rtla/rtla-osnoise-top.rst | 61 ++ >> Documentation/tools/rtla/rtla-osnoise.rst | 59 ++ >> .../tools/rtla/rtla-timerlat-hist.rst | 106 +++ >> .../tools/rtla/rtla-timerlat-top.rst | 145 +++ >> Documentation/tools/rtla/rtla-timerlat.rst | 57 ++ >> Documentation/tools/rtla/rtla.rst | 48 + >> debian.realtime/control.stub.in | 5 +- >> debian/rules.d/2-binary-arch.mk | 4 + >> debian/rules.d/3-binary-indep.mk | 1 + >> tools/tracing/rtla/Makefile | 102 ++ >> tools/tracing/rtla/README.txt | 36 + >> tools/tracing/rtla/src/osnoise.c | 875 ++++++++++++++++++ >> tools/tracing/rtla/src/osnoise.h | 91 ++ >> tools/tracing/rtla/src/osnoise_hist.c | 801 ++++++++++++++++ >> tools/tracing/rtla/src/osnoise_top.c | 579 ++++++++++++ >> tools/tracing/rtla/src/rtla.c | 87 ++ >> tools/tracing/rtla/src/timerlat.c | 72 ++ >> tools/tracing/rtla/src/timerlat.h | 4 + >> tools/tracing/rtla/src/timerlat_hist.c | 822 ++++++++++++++++ >> tools/tracing/rtla/src/timerlat_top.c | 618 +++++++++++++ >> tools/tracing/rtla/src/trace.c | 192 ++++ >> tools/tracing/rtla/src/trace.h | 27 + >> tools/tracing/rtla/src/utils.c | 433 +++++++++ >> tools/tracing/rtla/src/utils.h | 56 ++ >> 34 files changed, 5504 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/tools/rtla/Makefile >> create mode 100644 Documentation/tools/rtla/common_appendix.rst >> create mode 100644 Documentation/tools/rtla/common_hist_options.rst >> create mode 100644 Documentation/tools/rtla/common_options.rst >> create mode 100644 >> Documentation/tools/rtla/common_osnoise_description.rst >> create mode 100644 Documentation/tools/rtla/common_osnoise_options.rst >> create mode 100644 >> Documentation/tools/rtla/common_timerlat_description.rst >> create mode 100644 >> Documentation/tools/rtla/common_timerlat_options.rst >> create mode 100644 Documentation/tools/rtla/common_top_options.rst >> create mode 100644 Documentation/tools/rtla/rtla-osnoise-hist.rst >> create mode 100644 Documentation/tools/rtla/rtla-osnoise-top.rst >> create mode 100644 Documentation/tools/rtla/rtla-osnoise.rst >> create mode 100644 Documentation/tools/rtla/rtla-timerlat-hist.rst >> create mode 100644 Documentation/tools/rtla/rtla-timerlat-top.rst >> create mode 100644 Documentation/tools/rtla/rtla-timerlat.rst >> create mode 100644 Documentation/tools/rtla/rtla.rst >> create mode 100644 tools/tracing/rtla/Makefile >> create mode 100644 tools/tracing/rtla/README.txt >> create mode 100644 tools/tracing/rtla/src/osnoise.c >> create mode 100644 tools/tracing/rtla/src/osnoise.h >> create mode 100644 tools/tracing/rtla/src/osnoise_hist.c >> create mode 100644 tools/tracing/rtla/src/osnoise_top.c >> create mode 100644 tools/tracing/rtla/src/rtla.c >> create mode 100644 tools/tracing/rtla/src/timerlat.c >> create mode 100644 tools/tracing/rtla/src/timerlat.h >> create mode 100644 tools/tracing/rtla/src/timerlat_hist.c >> create mode 100644 tools/tracing/rtla/src/timerlat_top.c >> create mode 100644 tools/tracing/rtla/src/trace.c >> create mode 100644 tools/tracing/rtla/src/trace.h >> create mode 100644 tools/tracing/rtla/src/utils.c >> create mode 100644 tools/tracing/rtla/src/utils.h >> > Acked-by: Joseph Salisbury <joseph.salisbury@canonical.com> >