mbox series

[U/J/I/OEM-5.14,0/1] audio mute/ mic mute are not working on a HP machine

Message ID 20211224031731.9376-1-jeremy.szu@canonical.com
Headers show
Series audio mute/ mic mute are not working on a HP machine | expand

Message

Jeremy Szu Dec. 24, 2021, 3:17 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1955691

[Impact]
The mic mute/audio mute LEDS are not working on a HP platform

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Jeremy Szu (1):
  ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrea Righi Jan. 4, 2022, 9:06 a.m. UTC | #1 
On Fri, Dec 24, 2021 at 11:17:30AM +0800, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955691
> 
> [Impact]
> The mic mute/audio mute LEDS are not working on a HP platform
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Already applied to jammy:linux.

-Andrea
Timo Aaltonen Jan. 4, 2022, 10:05 a.m. UTC | #2 
On 24.12.2021 5.17, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955691
> 
> [Impact]
> The mic mute/audio mute LEDS are not working on a HP platform
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
> 
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 

applied to oem-5.14, thanks
Tim Gardner Jan. 4, 2022, 1:59 p.m. UTC | #3 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 12/23/21 8:17 PM, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955691
> 
> [Impact]
> The mic mute/audio mute LEDS are not working on a HP platform
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
> 
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
>
Kleber Sacilotto de Souza Jan. 4, 2022, 2:36 p.m. UTC | #4 
On 24.12.21 04:17, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955691
>
> [Impact]
> The mic mute/audio mute LEDS are not working on a HP platform
>
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
>
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
>
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
>
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
>
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Kleber Sacilotto de Souza Jan. 4, 2022, 4:35 p.m. UTC | #5 
On 24.12.21 04:17, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1955691
>
> [Impact]
> The mic mute/audio mute LEDS are not working on a HP platform
>
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
>
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
>
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
>
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
>
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
>

Applied to impish:linux.

Thanks,
Kleber