mbox series

[SRU,Unstable/OEM-5.14,0/1] Fix runtime power management on USB controller with XHCI_RESET_ON_RESUME flag

Message ID 20211210053801.101559-1-kai.heng.feng@canonical.com
Headers show
Series Fix runtime power management on USB controller with XHCI_RESET_ON_RESUME flag | expand

Message

Kai-Heng Feng Dec. 10, 2021, 5:38 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1954369

[Impact]
xHCI driver's runtime resume routine tries to reset USB controller with
XHCI_RESET_ON_RESUME flag. That causes USB devices connect to the xHCI
fail to work.

[Fix]
Disable runtime power management regardless of
CONFIG_USB_DEFAULT_PERSIST option.

[Test]
USB devices which connect to the xHCI controller can work normally.

[Where problems could occur]
USB_DEFAULT_PERSIST is a config for system-wide PM to speed up resume
time, so it shouldn't be applied to runtime PM at first place.

Kai-Heng Feng (1):
  xhci: Remove CONFIG_USB_DEFAULT_PERSIST to prevent xHCI from runtime
    suspending

 drivers/usb/host/xhci.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andrea Righi Dec. 15, 2021, 2:54 p.m. UTC | #1 
On Fri, Dec 10, 2021 at 01:38:00PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1954369
> 
> [Impact]
> xHCI driver's runtime resume routine tries to reset USB controller with
> XHCI_RESET_ON_RESUME flag. That causes USB devices connect to the xHCI
> fail to work.
> 
> [Fix]
> Disable runtime power management regardless of
> CONFIG_USB_DEFAULT_PERSIST option.
> 
> [Test]
> USB devices which connect to the xHCI controller can work normally.
> 
> [Where problems could occur]
> USB_DEFAULT_PERSIST is a config for system-wide PM to speed up resume
> time, so it shouldn't be applied to runtime PM at first place.

Applied to jammy:linux.

Thanks,
-Andrea