mbox series

[SRU,H,I,0/1,v2] cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline

Message ID 20211117194435.175399-1-philip.cox@canonical.com
Headers show
Series cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline | expand

Message

Philip Cox Nov. 17, 2021, 7:44 p.m. UTC
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

BugLink: https://bugs.launchpad.net/bugs/1950584

[Impact]

"Commit a365ab6b9dfb ("cpufreq: intel_pstate: Implement the
 ->adjust_perf() callback") caused intel_pstate to use nonzero HWP
 desired values in certain usage scenarios, but it did not prevent
 them from being leaked into the confugirations in which HWP desired
 is expected to be 0"

I believe I'm seeing this issue on my laptop during suspend/resume. The upstream fix is:

commit dbea75fe18f60e364de6d994fc938a24ba249d81
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Wed Nov 3 19:43:47 2021 +0100

    cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline

[Fix]

dbea75fe18f60e364de6d994fc938a24ba249d81 cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline


Changes from v1:
- v1 was a backport into hirsute, and impish as separate patches. v2 is
  a clean cherry-pick that merges and builds clean in both hirsute, and
  impish.

Comments

Tim Gardner Nov. 17, 2021, 7:49 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 11/17/21 12:44 PM, Philip Cox wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1950584
> 
> [Impact]
> 
> "Commit a365ab6b9dfb ("cpufreq: intel_pstate: Implement the
>   ->adjust_perf() callback") caused intel_pstate to use nonzero HWP
>   desired values in certain usage scenarios, but it did not prevent
>   them from being leaked into the confugirations in which HWP desired
>   is expected to be 0"
> 
> I believe I'm seeing this issue on my laptop during suspend/resume. The upstream fix is:
> 
> commit dbea75fe18f60e364de6d994fc938a24ba249d81
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Wed Nov 3 19:43:47 2021 +0100
> 
>      cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> [Fix]
> 
> dbea75fe18f60e364de6d994fc938a24ba249d81 cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> 
> Changes from v1:
> - v1 was a backport into hirsute, and impish as separate patches. v2 is
>    a clean cherry-pick that merges and builds clean in both hirsute, and
>    impish.
>
Stefan Bader Nov. 22, 2021, 5:04 p.m. UTC | #2
On 17.11.21 20:44, Philip Cox wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1950584
> 
> [Impact]
> 
> "Commit a365ab6b9dfb ("cpufreq: intel_pstate: Implement the
>   ->adjust_perf() callback") caused intel_pstate to use nonzero HWP
>   desired values in certain usage scenarios, but it did not prevent
>   them from being leaked into the confugirations in which HWP desired
>   is expected to be 0"
> 
> I believe I'm seeing this issue on my laptop during suspend/resume. The upstream fix is:
> 
> commit dbea75fe18f60e364de6d994fc938a24ba249d81
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date: Wed Nov 3 19:43:47 2021 +0100
> 
>      cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> [Fix]
> 
> dbea75fe18f60e364de6d994fc938a24ba249d81 cpufreq: intel_pstate: Clear HWP desired on suspend/shutdown and offline
> 
> 
> Changes from v1:
> - v1 was a backport into hirsute, and impish as separate patches. v2 is
>    a clean cherry-pick that merges and builds clean in both hirsute, and
>    impish.
> 

Applied to hirsute,impish:linux/master-next. Thanks.

-Stefan