From patchwork Tue Oct 19 15:27:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Righi X-Patchwork-Id: 1543419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=QGZyGnkZ; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HYd0Y5J3mz9sNH for ; Wed, 20 Oct 2021 02:27:41 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mcr1Z-0000fL-DE; Tue, 19 Oct 2021 15:27:33 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mcr1Y-0000fF-DB for kernel-team@lists.ubuntu.com; Tue, 19 Oct 2021 15:27:32 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3F7E23FFFE for ; Tue, 19 Oct 2021 15:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634657252; bh=9Z0PAMOjSa6Q5lr7gEZEIbnT4fnf1jEgSpXlA8R52xc=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=QGZyGnkZ0sDUVjE4secRxTlgWLnz5EODjGD+e4RZOAnEi2ZFzpnyCraSn5yXdH2aa Ee+en5MNoiaCNA0+jcLuY39LJG2um4VW9Yvs8i6aLtVaKaFJW8fLV8ep4ryJmJATJJ Q6q63OCu1wbw9yvNZt8INbvwOF+DsJQu8VKvgohxOiUrN53YkT2sJwvsWsKdRSmUAC 5sdnFKbfAfQ48YxWRPdoxJT4GnSSGh8/vIpJyEZLZ2KOvpib9PSjuK0StcANpxBDFf 36EJILyMucs6CJr5R9PT7UdA/4KkUgqSTScq0i0UBdL6PMsvLCol6rnRFiRTItVRV9 VDIfEmbALpwXw== Received: by mail-ed1-f72.google.com with SMTP id i7-20020a50d747000000b003db0225d219so13329246edj.0 for ; Tue, 19 Oct 2021 08:27:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=9Z0PAMOjSa6Q5lr7gEZEIbnT4fnf1jEgSpXlA8R52xc=; b=ih7K2X28fNboRh4Y0eOBRl0Ag0uhkkpvnK2NpFmVsILvUsrdL7Ft82BrBb9OjcROoF ahwLk4LbeG/4C4GceQU3MPbqXRS3YcByQfuHCJpXhYFYtqyv9bbFJbL33uF5WSs87eOb Xqe8k84Egy5A8mQrwE/JDgL/Dqt7PDTBa5NiEamSGm/n1UbRkWPbhCUp+eoIyyU0LmG7 zROJZ2yxMzK5jKBha74TGUH1QmRSJQlFu4wIBUeHm+u2x0q11wMj2oYgEXHGRDys6v4O dxDSP3eRlti0a9elMuNvNAHqvucGn3cmEs2l9+XYYgPEWVFtY/4C+C2ojSamhb2a8qLl ogjA== X-Gm-Message-State: AOAM530jM4DRTDxJaZKoyydlhHjTAzoE3dGArdT3Eka2fsHtaT+v8fcS f8ulzRSVCp4252tISjzeOIG3moYqLLzG9SMUGbJONAywlqhrOity6efepJqZPHTPfx4yl8tuct0 nTq1XrZ3tOOM0JhTuvJ2L60/uCKEXvIKSsK14IA6ceA== X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr38177714ejy.465.1634657252002; Tue, 19 Oct 2021 08:27:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxda/ZYxCHGZQlQrRv3T1OgeiBOPNQutpoJ2v3cREebU6o+6fRR3LhW3WqTGjLsGP/L6bpy/A== X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr38177694ejy.465.1634657251815; Tue, 19 Oct 2021 08:27:31 -0700 (PDT) Received: from arighi-desktop.homenet.telecomitalia.it ([2001:67c:1560:8007::aac:c1b6]) by smtp.gmail.com with ESMTPSA id z19sm10337732ejw.44.2021.10.19.08.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 08:27:31 -0700 (PDT) From: Andrea Righi To: kernel-team@lists.ubuntu.com Subject: [SRU][B][PATCH 0/2] Drop "UBUNTU: SAUCE: cachefiles: Page leaking in cachefiles_read_backing_file while vmscan is active" Date: Tue, 19 Oct 2021 17:27:26 +0200 Message-Id: <20211019152728.64481-1-andrea.righi@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1947709 [Impact] "UBUNTU: SAUCE: cachefiles: Page leaking in cachefiles_read_backing_file while vmscan is active" has been applied to fix a page leaking issue. However a slightly different fix has been applied upstream to address the same issue: 9a24ce5b66f9 ("cachefiles: Fix page leak in cachefiles_read_backing_file while vmscan is active") We should drop the SAUCE patch and rely on the upstream fix. [Test case] No test case or reproducer is available at the moment, this issue has been found simply by reviewing the code. [Fix] Drop the SAUCE patch and rely on the upstream fix. [Regression potential] If the analysis is not correct we may re-introduce a page leak in cachefiles (NFS for example), but it seems unlikely to happen, since the upstream fix is addressing the page leaking already. Acked-by: Kamal Mostafa Acked-by: Tim Gardner