mbox series

[SRU,I/H/F,v2,0/2] Fix speaker issues for a couple of Lenovo laptops

Message ID 20211013035023.9817-1-hui.wang@canonical.com
Headers show
Series [SRU,F,v2,1/2] ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion 7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops. | expand

Message

Hui Wang Oct. 13, 2021, 3:50 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1939052

In the V2, added one more patch to fix the 1st patch.

[Impact]
The speaker on a coule of Lenovo laptops can't output sound, need
to do special initialization.

[Fix]
Backport a upstream patch, the patch will initialize the speaker
amplifier with special verbs.

[Test]
Booting the patched kernel, output the sound to speaker, could
heaer the sound.

[Where problems could occur]
The patch set the quirk to some lenovo machines with subsystem id,
there is no regression risk for other machines.

Cameron Berkenpas (2):
  ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion
    7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops.
  ALSA: hda/realtek: Fix for quirk to enable speaker output on the
    Lenovo 13s Gen2

 sound/pci/hda/patch_realtek.c | 129 ++++++++++++++++++++++++++++++++++
 1 file changed, 129 insertions(+)

Comments

Tim Gardner Oct. 13, 2021, 12:11 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

The Focal backport looks good. Clean cherry-picks otherwise.

On 10/12/21 9:50 PM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939052
> 
> In the V2, added one more patch to fix the 1st patch.
> 
> [Impact]
> The speaker on a coule of Lenovo laptops can't output sound, need
> to do special initialization.
> 
> [Fix]
> Backport a upstream patch, the patch will initialize the speaker
> amplifier with special verbs.
> 
> [Test]
> Booting the patched kernel, output the sound to speaker, could
> heaer the sound.
> 
> [Where problems could occur]
> The patch set the quirk to some lenovo machines with subsystem id,
> there is no regression risk for other machines.
> 
> Cameron Berkenpas (2):
>    ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion
>      7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops.
>    ALSA: hda/realtek: Fix for quirk to enable speaker output on the
>      Lenovo 13s Gen2
> 
>   sound/pci/hda/patch_realtek.c | 129 ++++++++++++++++++++++++++++++++++
>   1 file changed, 129 insertions(+)
>
Kleber Sacilotto de Souza Oct. 14, 2021, 1:35 p.m. UTC | #2
On 13.10.21 05:50, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939052
> 
> In the V2, added one more patch to fix the 1st patch.
> 
> [Impact]
> The speaker on a coule of Lenovo laptops can't output sound, need
> to do special initialization.
> 
> [Fix]
> Backport a upstream patch, the patch will initialize the speaker
> amplifier with special verbs.
> 
> [Test]
> Booting the patched kernel, output the sound to speaker, could
> heaer the sound.
> 
> [Where problems could occur]
> The patch set the quirk to some lenovo machines with subsystem id,
> there is no regression risk for other machines.
> 
> Cameron Berkenpas (2):
>    ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion
>      7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops.
>    ALSA: hda/realtek: Fix for quirk to enable speaker output on the
>      Lenovo 13s Gen2
> 
>   sound/pci/hda/patch_realtek.c | 129 ++++++++++++++++++++++++++++++++++
>   1 file changed, 129 insertions(+)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Kleber Sacilotto de Souza Oct. 14, 2021, 3:15 p.m. UTC | #3
On 13.10.21 05:50, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939052
> 
> In the V2, added one more patch to fix the 1st patch.
> 
> [Impact]
> The speaker on a coule of Lenovo laptops can't output sound, need
> to do special initialization.
> 
> [Fix]
> Backport a upstream patch, the patch will initialize the speaker
> amplifier with special verbs.
> 
> [Test]
> Booting the patched kernel, output the sound to speaker, could
> heaer the sound.
> 
> [Where problems could occur]
> The patch set the quirk to some lenovo machines with subsystem id,
> there is no regression risk for other machines.
> 
> Cameron Berkenpas (2):
>    ALSA: hda/realtek: Quirks to enable speaker output for Lenovo Legion
>      7i 15IMHG05, Yoga 7i 14ITL5/15ITL5, and 13s Gen2 laptops.
>    ALSA: hda/realtek: Fix for quirk to enable speaker output on the
>      Lenovo 13s Gen2
> 
>   sound/pci/hda/patch_realtek.c | 129 ++++++++++++++++++++++++++++++++++
>   1 file changed, 129 insertions(+)
> 

Applied to {focal,hirsute,impish}:linux.

Thanks,
Kleber