From patchwork Mon Oct 11 04:16:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1539097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=A6RYnOkH; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HSQVG2P9Lz9sPf for ; Mon, 11 Oct 2021 15:16:53 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mZmjw-0003M6-8b; Mon, 11 Oct 2021 04:16:40 +0000 Received: from mail-pf1-f182.google.com ([209.85.210.182]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mZmju-0003Ly-Ex for kernel-team@lists.ubuntu.com; Mon, 11 Oct 2021 04:16:38 +0000 Received: by mail-pf1-f182.google.com with SMTP id g14so13741316pfm.1 for ; Sun, 10 Oct 2021 21:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=wbAb0QkDYM3xVOJUr4Eqppdnv3YCiP7fdif5okkxJfg=; b=A6RYnOkHCUYdHQifmx3stG9VrpC1ZWivKM96FgmV0XAEOaBCkkj42akRtq4lH83MFw jz6Tc3tkqZepiCX5SyjI1dgh8qX01EUEoKECTQKuhMpZf2NEvPKp9t7kLG6p687daG0o 3aAlsmF1XUenITGFt0MBAq/bFKukA/h1HhNTi7NvmiCyQqRUP+W1gJbYH4tujN+xYrmC aVob3g8Gaf43aGNXrTNDk5sGMMiaSCC0WiwBxr180TrG9jrwdEPVsXbzssjKgkU9Qi4n /+ObCObOfyVgWBInZevsI557r0m7hyBjzcKjunLTiOX1HAw0dh7YJZFFVYcCnvKr53V6 aJyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=wbAb0QkDYM3xVOJUr4Eqppdnv3YCiP7fdif5okkxJfg=; b=vHwGAOcx6wLWMZv97bXy9xBeo4Pr1y1ylJql0cgN3cuGY8anb6pBgknR78abIWEc0m eFuel+SA2b4p+3HPiFkZm+6aCQAkVLkRkTKKRkkf2MyYjJInkoVA0Chj2w2TbMPdLMov 1kb8AoB5coVo5A5ppJzOhWM2MxLa/9iedRcq7OlyR3a5OxEY0Z7oklQQTlfZfHWgfeT2 wgs+Q5Q0XXGVoS90UUT/R6cn7uc0L8pNqCh0LiQLO33IyYDvDq4klk2i9Mx3C/RMLvKs tD1VW70D1oM3sxiyEwRGrRKrWUWBr/vxwrv6nRkvw/wVOXJC8Jl92TmE85TFgoo/R2ao WhzA== X-Gm-Message-State: AOAM532sHQfO4a/OEEBgl24J2sdNKy7iOtkNyq9V/BLDjac8j1pufvuu hbO81lPNz/bgLlakbIA6LpDKD7bvdi0= X-Google-Smtp-Source: ABdhPJxvxsw/A0E2dUAHO3JBqm8NXHzFUiOleJ9Zdd5Bbb0mISz58cv7PyILp/bkqXpoHkcW3otrZA== X-Received: by 2002:a05:6a00:d63:b0:44d:186d:c4c0 with SMTP id n35-20020a056a000d6300b0044d186dc4c0mr4701583pfv.47.1633925795751; Sun, 10 Oct 2021 21:16:35 -0700 (PDT) Received: from localhost (220-135-95-34.hinet-ip.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id q18sm6358884pfj.46.2021.10.10.21.16.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Oct 2021 21:16:34 -0700 (PDT) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/3][SRU][[I][OEM-5.13][OEM-5.14][Unstable] Can only Date: Mon, 11 Oct 2021 12:16:23 +0800 Message-Id: <20211011041632.52463-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.210.182; envelope-from=acelan@gmail.com; helo=mail-pf1-f182.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "Chia-Lin Kao (AceLan)" BugLink: https://bugs.launchpad.net/bugs/1946433 [Impact] System only can reach PC3, and it affects power consumption alot. [Fix] Kaiheng implemented a dynamic ASPM for r8169, it not only fixes the PC state issue, but also fixes network speed issue. https://patchwork.ozlabs.org/project/linux-pci/cover/20211007161552.272771-1-kai.heng.feng@canonical.com/ [Test] Verified on 2 different systems which has PC state issue and has network speed issue, these patches fix both issues. [Where problems could occur] It toggles ASPM on and off depends on the network traffic during runtime, I don't think it'll lead to any regressions. Some potential issues have been addressed during the patch submitting. It's v6 now and accepted by upstream. Kai-Heng Feng (3): PCI/ASPM: Introduce a new helper to report ASPM capability r8169: Enable chip-specific ASPM regardless of PCIe ASPM status r8169: Implement dynamic ASPM mechanism drivers/net/ethernet/realtek/r8169_main.c | 69 ++++++++++++++++++++--- drivers/pci/pcie/aspm.c | 11 ++++ include/linux/pci.h | 2 + 3 files changed, 73 insertions(+), 9 deletions(-)