mbox series

[v2,0/3,SRU,I,OEM-5.13] It hangs while booting up with AMD W6800 [1002:73A3]

Message ID 20211001033604.787556-1-acelan.kao@canonical.com
Headers show
Series It hangs while booting up with AMD W6800 [1002:73A3] | expand

Message

AceLan Kao Oct. 1, 2021, 3:36 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1945553

[Impact]
It hangs when booting up with AMD W6800 [1002:73A3] graphics card.

[Fix]
Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)

[Test]
Verified the patch on a Dell workstation with AMD W6800 graphics card

[Where problems could occur]
The code flow doesn't change much, but with better return codes handling
and print out more meaningful messages. So it should not impact the already
working devices.

Andrey Grodzovsky (1):
  drm/amdgpu: Rename flag which prevents HW access

Luben Tuikov (2):
  drm/amd/pm: Fix a bug communicating with the SMU (v5)
  drm/amd/pm: Fix a bug in semaphore double-lock

 drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
 6 files changed, 250 insertions(+), 55 deletions(-)

Comments

Timo Aaltonen Oct. 1, 2021, 7:07 a.m. UTC | #1
On 1.10.2021 6.36, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1945553
> 
> [Impact]
> It hangs when booting up with AMD W6800 [1002:73A3] graphics card.
> 
> [Fix]
> Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
> 5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)
> 
> [Test]
> Verified the patch on a Dell workstation with AMD W6800 graphics card
> 
> [Where problems could occur]
> The code flow doesn't change much, but with better return codes handling
> and print out more meaningful messages. So it should not impact the already
> working devices.
> 
> Andrey Grodzovsky (1):
>    drm/amdgpu: Rename flag which prevents HW access
> 
> Luben Tuikov (2):
>    drm/amd/pm: Fix a bug communicating with the SMU (v5)
>    drm/amd/pm: Fix a bug in semaphore double-lock
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
>   drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
>   6 files changed, 250 insertions(+), 55 deletions(-)
> 

applied to oem-5.13, thanks

what about oem-5.14?
Timo Aaltonen Oct. 1, 2021, 7:09 a.m. UTC | #2
On 1.10.2021 10.07, Timo Aaltonen wrote:
> On 1.10.2021 6.36, AceLan Kao wrote:
>> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1945553
>>
>> [Impact]
>> It hangs when booting up with AMD W6800 [1002:73A3] graphics card.
>>
>> [Fix]
>> Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
>> 5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)
>>
>> [Test]
>> Verified the patch on a Dell workstation with AMD W6800 graphics card
>>
>> [Where problems could occur]
>> The code flow doesn't change much, but with better return codes handling
>> and print out more meaningful messages. So it should not impact the 
>> already
>> working devices.
>>
>> Andrey Grodzovsky (1):
>>    drm/amdgpu: Rename flag which prevents HW access
>>
>> Luben Tuikov (2):
>>    drm/amd/pm: Fix a bug communicating with the SMU (v5)
>>    drm/amd/pm: Fix a bug in semaphore double-lock
>>
>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
>>   drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
>>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
>>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
>>   6 files changed, 250 insertions(+), 55 deletions(-)
>>
> 
> applied to oem-5.13, thanks
> 
> what about oem-5.14?

nevermind, it has them already
Kleber Sacilotto de Souza Oct. 14, 2021, 11:07 a.m. UTC | #3
On 01.10.21 05:36, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1945553
> 
> [Impact]
> It hangs when booting up with AMD W6800 [1002:73A3] graphics card.
> 
> [Fix]
> Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
> 5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)
> 
> [Test]
> Verified the patch on a Dell workstation with AMD W6800 graphics card
> 
> [Where problems could occur]
> The code flow doesn't change much, but with better return codes handling
> and print out more meaningful messages. So it should not impact the already
> working devices.
> 
> Andrey Grodzovsky (1):
>    drm/amdgpu: Rename flag which prevents HW access
> 
> Luben Tuikov (2):
>    drm/amd/pm: Fix a bug communicating with the SMU (v5)
>    drm/amd/pm: Fix a bug in semaphore double-lock
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
>   drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
>   6 files changed, 250 insertions(+), 55 deletions(-)
> 

Clean cherry-picks, good test results. It seems this patchset still
needs to be applied to Impish, so:

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Kelsey Skunberg Oct. 14, 2021, 11:13 p.m. UTC | #4
Acked-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

On 2021-10-01 11:36:01 , AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1945553
> 
> [Impact]
> It hangs when booting up with AMD W6800 [1002:73A3] graphics card.
> 
> [Fix]
> Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
> 5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)
> 
> [Test]
> Verified the patch on a Dell workstation with AMD W6800 graphics card
> 
> [Where problems could occur]
> The code flow doesn't change much, but with better return codes handling
> and print out more meaningful messages. So it should not impact the already
> working devices.
> 
> Andrey Grodzovsky (1):
>   drm/amdgpu: Rename flag which prevents HW access
> 
> Luben Tuikov (2):
>   drm/amd/pm: Fix a bug communicating with the SMU (v5)
>   drm/amd/pm: Fix a bug in semaphore double-lock
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
>  6 files changed, 250 insertions(+), 55 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kelsey Skunberg Oct. 14, 2021, 11:20 p.m. UTC | #5
Applied to Impish master-next. thank you!

-Kelsey

On 2021-10-01 11:36:01 , AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1945553
> 
> [Impact]
> It hangs when booting up with AMD W6800 [1002:73A3] graphics card.
> 
> [Fix]
> Bisect the kernel and found below fix from v5.15-rc1 mainline kernel
> 5810323ba692 drm/amd/pm: Fix a bug communicating with the SMU (v5)
> 
> [Test]
> Verified the patch on a Dell workstation with AMD W6800 graphics card
> 
> [Where problems could occur]
> The code flow doesn't change much, but with better return codes handling
> and print out more meaningful messages. So it should not impact the already
> working devices.
> 
> Andrey Grodzovsky (1):
>   drm/amdgpu: Rename flag which prevents HW access
> 
> Luben Tuikov (2):
>   drm/amd/pm: Fix a bug communicating with the SMU (v5)
>   drm/amd/pm: Fix a bug in semaphore double-lock
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h        |   2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |   6 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c    |   4 +-
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c     |   2 +-
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c     | 288 +++++++++++++++++----
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h     |   3 +-
>  6 files changed, 250 insertions(+), 55 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team