| Message ID | 20210923101102.12562-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | Fix a keyboard issue for some medion laptops | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> Localized to one HW platform. On 9/23/21 4:11 AM, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. > > > Hui Wang (1): > ACPI: resources: Add DMI-based legacy IRQ override quirk > > drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 47 insertions(+), 2 deletions(-) >
On Thu, Sep 23, 2021 at 06:11:00PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. Applied to impish/linux 5.13. Thanks, -Andrea
On 23.09.21 12:11, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. What is unclear to me, does this require "ACPI: resources: Add checks for ACPI IRQ override" to be applied or reverted as pre-requisite? For H/F this got reverted. -Stefan > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. > > > Hui Wang (1): > ACPI: resources: Add DMI-based legacy IRQ override quirk > > drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 47 insertions(+), 2 deletions(-) >
On 10/5/21 4:34 PM, Stefan Bader wrote: > On 23.09.21 12:11, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1909814 >> >> [Impact] >> The keyboard of some medion laptops can't work under Linux. >> >> [Fix] >> Backport a upstream patch, after applying the patch, the keyboard >> will skip the irq override from the acpi resource layer, and the >> keyboard could work normally. > > What is unclear to me, does this require "ACPI: resources: Add checks > for ACPI IRQ override" to be applied or reverted as pre-requisite? For > H/F this got reverted. > It requires the "ACPI: resources: Add checks for ACPI IRQ override" to be reverted first, then apply the patch of this SRU. Thanks, Hui. > >> >> [Test] >> Booting the patched kernel, use the keyboard to do the input. >> >> [Where problems could occur] >> The patch will skip the irq override based on the DMI info, so >> if a medion laptop which has the same DMI info and the irq 1 >> needs to be overriden, this patch will introduce regression on >> the machine, but this possibility is very low. If this happens, >> we will consider to add more DMI match info in the table. >> >> >> Hui Wang (1): >> ACPI: resources: Add DMI-based legacy IRQ override quirk >> >> drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 47 insertions(+), 2 deletions(-) >> > >
On 23.09.21 12:11, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. > > > Hui Wang (1): > ACPI: resources: Add DMI-based legacy IRQ override quirk > > drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 47 insertions(+), 2 deletions(-) > Ok, so the other patch being already reverted in Hirsute and Focal it should be ok to pick this... Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 9/23/21 4:11 AM, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. > > > Hui Wang (1): > ACPI: resources: Add DMI-based legacy IRQ override quirk > > drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 47 insertions(+), 2 deletions(-) >
Applied to Focal master-next. Thank you! -Kelsey On 2021-09-23 18:11:00 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1909814 > > [Impact] > The keyboard of some medion laptops can't work under Linux. > > [Fix] > Backport a upstream patch, after applying the patch, the keyboard > will skip the irq override from the acpi resource layer, and the > keyboard could work normally. > > [Test] > Booting the patched kernel, use the keyboard to do the input. > > [Where problems could occur] > The patch will skip the irq override based on the DMI info, so > if a medion laptop which has the same DMI info and the irq 1 > needs to be overriden, this patch will introduce regression on > the machine, but this possibility is very low. If this happens, > we will consider to add more DMI match info in the table. > > > Hui Wang (1): > ACPI: resources: Add DMI-based legacy IRQ override quirk > > drivers/acpi/resource.c | 49 +++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 47 insertions(+), 2 deletions(-) > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team