From patchwork Thu Aug 26 16:27:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Reed X-Patchwork-Id: 1521195 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=nOtTKU7p; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GwStw5wsxz9sWc; Fri, 27 Aug 2021 02:27:51 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1mJIEC-00082h-Dt; Thu, 26 Aug 2021 16:27:44 +0000 Received: from smtp-relay-internal-1.internal ([10.131.114.114] helo=smtp-relay-internal-1.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1mJIE6-00081q-Rc for kernel-team@lists.ubuntu.com; Thu, 26 Aug 2021 16:27:38 +0000 Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 98D5B3F04D for ; Thu, 26 Aug 2021 16:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629995258; bh=fmKWkS/aUhxY/vQH7+I0PPKV9rtObWunYPlp3cDicMY=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=nOtTKU7pLMWTAM6I2Rbqf2m1em5EAS2tR4+uNY7DDkoc574Ls9k6coL5vR+Cxu1rr lWtwPbBGexpehEwHwdXQmbkCwNpQY+9y3I1IMeTp0AewkTrjeMTKNPLw8IKBvz5/Yk bLJEcFXz9GmgDbwMAjNvZkxP8Elz3lAIFvcIssz0G5vf1OuxV0rgAak2/Ci6ch3u3L RxoMrGEIJDcwaXRqmfAELcB6M70IyHWSWz3gGS+/AuLzxatPPYkrmSM4zMeXR8fazr cSJ1KEXep+qKVb6liax8srhoPruefpEx38gv3v2+Gm3VxqBVBfcsdoumq+Ncy1sip3 IjqmxGWWBLUVQ== Received: by mail-oi1-f198.google.com with SMTP id r25-20020a056808211900b00268b48af6baso1774124oiw.23 for ; Thu, 26 Aug 2021 09:27:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=fmKWkS/aUhxY/vQH7+I0PPKV9rtObWunYPlp3cDicMY=; b=RddLB0NUxD2KdXgFz4L3yQZ3sHJOcdanfMceYgM+A0nhJS/KsnyjfDUWfQrKkp/MNH uhd4Qr3d3LrxVYF5BE/mLVspiyz4n0Syk1cW/P6/Gv8qHoWHrIOaIoJTP0Gz0o/BmK/S AkG2hTcdx9u67TsAxruuQ2akvSJq86A6KW6sDBUg0dyx8ox4PDIjl7f5LAmEGZACEdMv xoT056GgETTfEmbilqj678cPt/0J8xEB2PIdnlLD4fh4SpE3r4AVwybsPpgrVBE1RGkd iGYW59CwkaIs9sOmOq8wVlV2EkNC9PCzsIrQbrpcOLHndvhqgzt7koWWY8+Xjb12EbQy 161Q== X-Gm-Message-State: AOAM530YSAFd2LSa8yqt4TlY4bkClxmyK0PoRAfA/7eiyzVbmiAs0y5E EzkJOi1a+MiKQZIKLRp4R6ljMMu9cSei8SP0dqHgetbbhy3TQ4D6IKZOwFUFL/iXO8x5iimWYAP /VHDzpqquoC/xJpf6tsZ9Qx9blxmXr7J2jNzqBp5hDQ== X-Received: by 2002:aca:34c4:: with SMTP id b187mr3124446oia.139.1629995257122; Thu, 26 Aug 2021 09:27:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYdMaGWEZ1WwRTptHajFT0LDP2dZNLUGGKbeit8z70mEQ9MURTY3yj9Szkc1zqMG1EOH+fFQ== X-Received: by 2002:aca:34c4:: with SMTP id b187mr3124417oia.139.1629995256804; Thu, 26 Aug 2021 09:27:36 -0700 (PDT) Received: from localhost ([2600:1700:1d0:5e50:3374:e6b3:3eb3:87e7]) by smtp.gmail.com with ESMTPSA id s24sm729788oic.34.2021.08.26.09.27.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 09:27:36 -0700 (PDT) From: Michael Reed To: kernel-team@lists.ubuntu.com Subject: [SRU][Focal][PATCH 0/1] ice: Fix bad register reads Date: Thu, 26 Aug 2021 11:27:32 -0500 Message-Id: <20210826162733.15486-1-michael.reed@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Michael Reed BugLink: https://launchpad.net/bugs/1939855 [Impact] When we run the command, ethtool -d with Intel cards (ice driver), the kernel crashes because of the ice driver. The same works fine with HWE kernel (5.11). Here, we do not see any crash. [FIXES] ice: Fix bad register reads The "ethtool -d" handler reads registers in the ice_regs_dump_list array and returns read values back to the userspace. commitID: 1fba4a8a92706c89716449b1aab1b6879f438d34 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/ethernet/intel/ice?id=1fba4a8a92706c89716449b1aab1b6879f438d34 [TESTING] Install Focal on a system with an E810 network device. Ensure the network device has an IP address and has connectivity Run ethtool -d Expected result: Prints a register dump for the specified network device [REGRESSION RISK] The regression risk is low [OTHER INFO] I have added the fix, built the kernel and tested the fix. https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/e810_ethtool_fix_next Anirudh Venkataramanan (1): ice: Fix bad register reads drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 --- drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 3 --- 2 files changed, 6 deletions(-) Acked-by: Tim Gardner