mbox series

[SRU,H/I/unstable,v2,0/2] Dell XPS 17 (9710) PCI/internal sound card not detected

Message ID 20210813081240.12248-1-hui.wang@canonical.com
Headers show
Series Dell XPS 17 (9710) PCI/internal sound card not detected | expand

Message

Hui Wang Aug. 13, 2021, 8:12 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1935850

V2:
Cherry-pick one more patch to fix the build failure. And I already
appiled the 2 patches to master-next branch of hirsute kernel and
built the kernel successfully.

And these 2 kernel patches could be applied to the master-next branch
of hirsute kernel, but couldn't directly applied to Impish and
unstable kernel, need to cherry-pick these 2 commits under Impish and
unstable, there is no conflict when cherry-picking in Impish and
unstable.

V1:

This patch is for soundwire audio, and only ubuntu 5.11-generic
and later kernels support soundwire audio driver, so this patch is not
sent to groovy and focal kernels.

For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
project, it is not urgent to merge this patch to OEM kenrels, after
the patch is in the hirsute and impish kernels, the oem kernels will
have this patch when syncing with generic kernels.

[Impact]
On the Dell XPS 17 (9710) machine, the audio card is not detected when
booting hirsute or impish kernels. So the audio doesn't work on this
machine with ubuntu linux 21.04 or 21.10.

[Fix]
Backport a upstream patch, this will set the correct codec config
for this machine: rt711 for headset, dual rt1308 for spks and rt715
for internal mic.

[Test]
Booting up with the patched kernel, the audio card is detected, test
internal speaker and internal mic, all work well, plug a headset,
the headphone and external mic work well too.


[Where problems could occur]
This change only applis to the Dell machines with the 
DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
regression, it will make the audio (speaker, internal mic and headset)
can't work anymore on the Dell machine with that PRODUCT_SKU, but this
possibility is very low, and we tested the patch on the machine, so
far no regression is found.

Bard Liao (1):
  ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode

Pierre-Louis Bossart (1):
  ASoC: Intel: sof_sdw: add quirk for Dell XPS 9710

 sound/soc/intel/boards/sof_sdw.c        | 35 +++++++++++++++++--------
 sound/soc/intel/boards/sof_sdw_common.h |  5 ----
 2 files changed, 24 insertions(+), 16 deletions(-)

Comments

Tim Gardner Aug. 13, 2021, 11:27 a.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 8/13/21 2:12 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
> 
> V2:
> Cherry-pick one more patch to fix the build failure. And I already
> appiled the 2 patches to master-next branch of hirsute kernel and
> built the kernel successfully.
> 
> And these 2 kernel patches could be applied to the master-next branch
> of hirsute kernel, but couldn't directly applied to Impish and
> unstable kernel, need to cherry-pick these 2 commits under Impish and
> unstable, there is no conflict when cherry-picking in Impish and
> unstable.
> 
> V1:
> 
> This patch is for soundwire audio, and only ubuntu 5.11-generic
> and later kernels support soundwire audio driver, so this patch is not
> sent to groovy and focal kernels.
> 
> For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
> project, it is not urgent to merge this patch to OEM kenrels, after
> the patch is in the hirsute and impish kernels, the oem kernels will
> have this patch when syncing with generic kernels.
> 
> [Impact]
> On the Dell XPS 17 (9710) machine, the audio card is not detected when
> booting hirsute or impish kernels. So the audio doesn't work on this
> machine with ubuntu linux 21.04 or 21.10.
> 
> [Fix]
> Backport a upstream patch, this will set the correct codec config
> for this machine: rt711 for headset, dual rt1308 for spks and rt715
> for internal mic.
> 
> [Test]
> Booting up with the patched kernel, the audio card is detected, test
> internal speaker and internal mic, all work well, plug a headset,
> the headphone and external mic work well too.
> 
> 
> [Where problems could occur]
> This change only applis to the Dell machines with the
> DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
> regression, it will make the audio (speaker, internal mic and headset)
> can't work anymore on the Dell machine with that PRODUCT_SKU, but this
> possibility is very low, and we tested the patch on the machine, so
> far no regression is found.
> 
> Bard Liao (1):
>    ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode
> 
> Pierre-Louis Bossart (1):
>    ASoC: Intel: sof_sdw: add quirk for Dell XPS 9710
> 
>   sound/soc/intel/boards/sof_sdw.c        | 35 +++++++++++++++++--------
>   sound/soc/intel/boards/sof_sdw_common.h |  5 ----
>   2 files changed, 24 insertions(+), 16 deletions(-)
>
Andrea Righi Aug. 17, 2021, 7:09 a.m. UTC | #2
On Fri, Aug 13, 2021 at 04:12:38PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
> 
> V2:
> Cherry-pick one more patch to fix the build failure. And I already
> appiled the 2 patches to master-next branch of hirsute kernel and
> built the kernel successfully.
> 
> And these 2 kernel patches could be applied to the master-next branch
> of hirsute kernel, but couldn't directly applied to Impish and
> unstable kernel, need to cherry-pick these 2 commits under Impish and
> unstable, there is no conflict when cherry-picking in Impish and
> unstable.
> 
> V1:
> 
> This patch is for soundwire audio, and only ubuntu 5.11-generic
> and later kernels support soundwire audio driver, so this patch is not
> sent to groovy and focal kernels.
> 
> For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
> project, it is not urgent to merge this patch to OEM kenrels, after
> the patch is in the hirsute and impish kernels, the oem kernels will
> have this patch when syncing with generic kernels.
> 
> [Impact]
> On the Dell XPS 17 (9710) machine, the audio card is not detected when
> booting hirsute or impish kernels. So the audio doesn't work on this
> machine with ubuntu linux 21.04 or 21.10.
> 
> [Fix]
> Backport a upstream patch, this will set the correct codec config
> for this machine: rt711 for headset, dual rt1308 for spks and rt715
> for internal mic.
> 
> [Test]
> Booting up with the patched kernel, the audio card is detected, test
> internal speaker and internal mic, all work well, plug a headset,
> the headphone and external mic work well too.
> 
> 
> [Where problems could occur]
> This change only applis to the Dell machines with the 
> DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
> regression, it will make the audio (speaker, internal mic and headset)
> can't work anymore on the Dell machine with that PRODUCT_SKU, but this
> possibility is very low, and we tested the patch on the machine, so
> far no regression is found.

Applied to impish:linux (5.13).

Thanks,
-Andrea
Paolo Pisati Aug. 17, 2021, 3:39 p.m. UTC | #3
On Fri, Aug 13, 2021 at 04:12:38PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
Stefan Bader Aug. 31, 2021, 1:12 p.m. UTC | #4
On 13.08.21 10:12, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
> 
> V2:
> Cherry-pick one more patch to fix the build failure. And I already
> appiled the 2 patches to master-next branch of hirsute kernel and
> built the kernel successfully.
> 
> And these 2 kernel patches could be applied to the master-next branch
> of hirsute kernel, but couldn't directly applied to Impish and
> unstable kernel, need to cherry-pick these 2 commits under Impish and
> unstable, there is no conflict when cherry-picking in Impish and
> unstable.
> 
> V1:
> 
> This patch is for soundwire audio, and only ubuntu 5.11-generic
> and later kernels support soundwire audio driver, so this patch is not
> sent to groovy and focal kernels.
> 
> For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
> project, it is not urgent to merge this patch to OEM kenrels, after
> the patch is in the hirsute and impish kernels, the oem kernels will
> have this patch when syncing with generic kernels.
> 
> [Impact]
> On the Dell XPS 17 (9710) machine, the audio card is not detected when
> booting hirsute or impish kernels. So the audio doesn't work on this
> machine with ubuntu linux 21.04 or 21.10.
> 
> [Fix]
> Backport a upstream patch, this will set the correct codec config
> for this machine: rt711 for headset, dual rt1308 for spks and rt715
> for internal mic.
> 
> [Test]
> Booting up with the patched kernel, the audio card is detected, test
> internal speaker and internal mic, all work well, plug a headset,
> the headphone and external mic work well too.
> 
> 
> [Where problems could occur]
> This change only applis to the Dell machines with the
> DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
> regression, it will make the audio (speaker, internal mic and headset)
> can't work anymore on the Dell machine with that PRODUCT_SKU, but this
> possibility is very low, and we tested the patch on the machine, so
> far no regression is found.
> 
> Bard Liao (1):
>    ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode
> 
> Pierre-Louis Bossart (1):
>    ASoC: Intel: sof_sdw: add quirk for Dell XPS 9710
> 
>   sound/soc/intel/boards/sof_sdw.c        | 35 +++++++++++++++++--------
>   sound/soc/intel/boards/sof_sdw_common.h |  5 ----
>   2 files changed, 24 insertions(+), 16 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Aug. 31, 2021, 1:13 p.m. UTC | #5
On 13.08.21 10:12, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
> 
> V2:
> Cherry-pick one more patch to fix the build failure. And I already
> appiled the 2 patches to master-next branch of hirsute kernel and
> built the kernel successfully.
> 
> And these 2 kernel patches could be applied to the master-next branch
> of hirsute kernel, but couldn't directly applied to Impish and
> unstable kernel, need to cherry-pick these 2 commits under Impish and
> unstable, there is no conflict when cherry-picking in Impish and
> unstable.
> 
> V1:
> 
> This patch is for soundwire audio, and only ubuntu 5.11-generic
> and later kernels support soundwire audio driver, so this patch is not
> sent to groovy and focal kernels.
> 
> For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
> project, it is not urgent to merge this patch to OEM kenrels, after
> the patch is in the hirsute and impish kernels, the oem kernels will
> have this patch when syncing with generic kernels.
> 
> [Impact]
> On the Dell XPS 17 (9710) machine, the audio card is not detected when
> booting hirsute or impish kernels. So the audio doesn't work on this
> machine with ubuntu linux 21.04 or 21.10.
> 
> [Fix]
> Backport a upstream patch, this will set the correct codec config
> for this machine: rt711 for headset, dual rt1308 for spks and rt715
> for internal mic.
> 
> [Test]
> Booting up with the patched kernel, the audio card is detected, test
> internal speaker and internal mic, all work well, plug a headset,
> the headphone and external mic work well too.
> 
> 
> [Where problems could occur]
> This change only applis to the Dell machines with the
> DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
> regression, it will make the audio (speaker, internal mic and headset)
> can't work anymore on the Dell machine with that PRODUCT_SKU, but this
> possibility is very low, and we tested the patch on the machine, so
> far no regression is found.
> 
> Bard Liao (1):
>    ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode
> 
> Pierre-Louis Bossart (1):
>    ASoC: Intel: sof_sdw: add quirk for Dell XPS 9710
> 
>   sound/soc/intel/boards/sof_sdw.c        | 35 +++++++++++++++++--------
>   sound/soc/intel/boards/sof_sdw_common.h |  5 ----
>   2 files changed, 24 insertions(+), 16 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
Kleber Sacilotto de Souza Aug. 31, 2021, 1:42 p.m. UTC | #6
On 13.08.21 10:12, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1935850
> 
> V2:
> Cherry-pick one more patch to fix the build failure. And I already
> appiled the 2 patches to master-next branch of hirsute kernel and
> built the kernel successfully.
> 
> And these 2 kernel patches could be applied to the master-next branch
> of hirsute kernel, but couldn't directly applied to Impish and
> unstable kernel, need to cherry-pick these 2 commits under Impish and
> unstable, there is no conflict when cherry-picking in Impish and
> unstable.
> 
> V1:
> 
> This patch is for soundwire audio, and only ubuntu 5.11-generic
> and later kernels support soundwire audio driver, so this patch is not
> sent to groovy and focal kernels.
> 
> For oem-5.10 and oem-5.13 kernels, since this bug is not from OEM
> project, it is not urgent to merge this patch to OEM kenrels, after
> the patch is in the hirsute and impish kernels, the oem kernels will
> have this patch when syncing with generic kernels.
> 
> [Impact]
> On the Dell XPS 17 (9710) machine, the audio card is not detected when
> booting hirsute or impish kernels. So the audio doesn't work on this
> machine with ubuntu linux 21.04 or 21.10.
> 
> [Fix]
> Backport a upstream patch, this will set the correct codec config
> for this machine: rt711 for headset, dual rt1308 for spks and rt715
> for internal mic.
> 
> [Test]
> Booting up with the patched kernel, the audio card is detected, test
> internal speaker and internal mic, all work well, plug a headset,
> the headphone and external mic work well too.
> 
> 
> [Where problems could occur]
> This change only applis to the Dell machines with the
> DMI_PRODUCT_SKU equals to "0A5D", if this could introduce the
> regression, it will make the audio (speaker, internal mic and headset)
> can't work anymore on the Dell machine with that PRODUCT_SKU, but this
> possibility is very low, and we tested the patch on the machine, so
> far no regression is found.
> 
> Bard Liao (1):
>    ASoC: Intel: sof_sdw: include rt711.h for RT711 JD mode
> 
> Pierre-Louis Bossart (1):
>    ASoC: Intel: sof_sdw: add quirk for Dell XPS 9710
> 
>   sound/soc/intel/boards/sof_sdw.c        | 35 +++++++++++++++++--------
>   sound/soc/intel/boards/sof_sdw_common.h |  5 ----
>   2 files changed, 24 insertions(+), 16 deletions(-)
> 

Applied to hirsute:linux.

Thanks,
Kleber