mbox series

[U/I/H/OEM-5.10/OEM-5.13,0/1] mute/micmute LEDs no function on HP EliteBook 830 G8 Notebook PC

Message ID 20210707033151.14842-1-jeremy.szu@canonical.com
Headers show
Series mute/micmute LEDs no function on HP EliteBook 830 G8 Notebook PC | expand

Message

Jeremy Szu July 7, 2021, 3:31 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1934239

[Impact]
The mic mute/audio mute LEDS are not work on HP EliteBook 830 G8 Notebook PC

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Jeremy Szu (1):
  ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 830 G8
    Notebook PC

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

AceLan Kao July 7, 2021, 6:18 a.m. UTC | #1
applied to oem-5.10, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Tim Gardner July 7, 2021, 12:18 p.m. UTC | #2
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 7/6/21 9:31 PM, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934239
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on HP EliteBook 830 G8 Notebook PC
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 830 G8
>      Notebook PC
> 
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
>
Kleber Sacilotto de Souza July 9, 2021, 8:23 a.m. UTC | #3
On 07.07.21 05:31, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1934239
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on HP EliteBook 830 G8 Notebook PC
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Jeremy Szu (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 830 G8
>      Notebook PC
> 
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 

The bug report is nominated against the linux package in Focal, Groovy,
Hirsute and Impish, but this submission includes only H and I. Is this
also needed for F and G?


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks
AceLan Kao July 14, 2021, 9:58 a.m. UTC | #4
applied to oem-5.13, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>
AceLan Kao July 14, 2021, 10:04 a.m. UTC | #5
applied to oem-5.13, thanks
Acked-By: AceLan Kao <acelan.kao@canonical.com>