mbox series

[0/4,SRU,H,Unstable] Add support for selective build of special drivers

Message ID 20210611100131.15133-1-acelan.kao@canonical.com
Headers show
Series Add support for selective build of special drivers | expand

Message

AceLan Kao June 11, 2021, 10:01 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1912789

[SRU Justification]

= Impact =

We want to add some driver code which exists in the primary kernel source
but will not get included unless specifically asked for. As long as there
are no drivers using this, there is no user-visible change.

= Impact =

This will be done by adding a new config option which gets turned on via
build setup rules. The default will be off.

= Testcase =

As long as there are no consumers changes can only be seen by inspecting
the build logs (if even that).

= Regression Potential =

This prepares for future consumers. At this stage either the build will
fail completely or pass and in that case the produced kernel binaries are
the same as they were before.

Chia-Lin Kao (AceLan) (1):
  UBUNTU: [Packaging] Fix ODM DRIVERS Kconfig

Stefan Bader (3):
  UBUNTU: [Packaging] Add support for ODM drivers
  UBUNTU: [Packaging] Turn on ODM support for amd64
  UBUNTU: [Packaging] Fix ODM support in actual build

 debian.master/config/config.common.ubuntu   |  1 +
 debian.master/rules.d/amd64.mk              |  1 +
 debian/rules.d/0-common-vars.mk             |  4 +++
 debian/rules.d/1-maintainer.mk              |  1 +
 debian/rules.d/2-binary-arch.mk             |  3 +++
 debian/scripts/misc/arch-has-odm-enabled.sh | 30 +++++++++++++++++++++
 debian/scripts/misc/kernelconfig            |  2 +-
 ubuntu/Kconfig                              |  6 +++++
 8 files changed, 47 insertions(+), 1 deletion(-)
 create mode 100755 debian/scripts/misc/arch-has-odm-enabled.sh

Comments

Stefan Bader June 14, 2021, 7:14 a.m. UTC | #1
On 11.06.21 12:01, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1912789
> 
> [SRU Justification]
> 
> = Impact =
> 
> We want to add some driver code which exists in the primary kernel source
> but will not get included unless specifically asked for. As long as there
> are no drivers using this, there is no user-visible change.
> 
> = Impact =
> 
> This will be done by adding a new config option which gets turned on via
> build setup rules. The default will be off.
> 
> = Testcase =
> 
> As long as there are no consumers changes can only be seen by inspecting
> the build logs (if even that).
> 
> = Regression Potential =
> 
> This prepares for future consumers. At this stage either the build will
> fail completely or pass and in that case the produced kernel binaries are
> the same as they were before.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Packaging] Fix ODM DRIVERS Kconfig
> 
> Stefan Bader (3):
>    UBUNTU: [Packaging] Add support for ODM drivers
>    UBUNTU: [Packaging] Turn on ODM support for amd64
>    UBUNTU: [Packaging] Fix ODM support in actual build
> 
>   debian.master/config/config.common.ubuntu   |  1 +
>   debian.master/rules.d/amd64.mk              |  1 +
>   debian/rules.d/0-common-vars.mk             |  4 +++
>   debian/rules.d/1-maintainer.mk              |  1 +
>   debian/rules.d/2-binary-arch.mk             |  3 +++
>   debian/scripts/misc/arch-has-odm-enabled.sh | 30 +++++++++++++++++++++
>   debian/scripts/misc/kernelconfig            |  2 +-
>   ubuntu/Kconfig                              |  6 +++++
>   8 files changed, 47 insertions(+), 1 deletion(-)
>   create mode 100755 debian/scripts/misc/arch-has-odm-enabled.sh
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza June 18, 2021, 7:44 a.m. UTC | #2
On 11.06.21 12:01, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1912789
> 
> [SRU Justification]
> 
> = Impact =
> 
> We want to add some driver code which exists in the primary kernel source
> but will not get included unless specifically asked for. As long as there
> are no drivers using this, there is no user-visible change.
> 
> = Impact =
> 
> This will be done by adding a new config option which gets turned on via
> build setup rules. The default will be off.
> 
> = Testcase =
> 
> As long as there are no consumers changes can only be seen by inspecting
> the build logs (if even that).
> 
> = Regression Potential =
> 
> This prepares for future consumers. At this stage either the build will
> fail completely or pass and in that case the produced kernel binaries are
> the same as they were before.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks

> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Packaging] Fix ODM DRIVERS Kconfig
> 
> Stefan Bader (3):
>    UBUNTU: [Packaging] Add support for ODM drivers
>    UBUNTU: [Packaging] Turn on ODM support for amd64
>    UBUNTU: [Packaging] Fix ODM support in actual build
> 
>   debian.master/config/config.common.ubuntu   |  1 +
>   debian.master/rules.d/amd64.mk              |  1 +
>   debian/rules.d/0-common-vars.mk             |  4 +++
>   debian/rules.d/1-maintainer.mk              |  1 +
>   debian/rules.d/2-binary-arch.mk             |  3 +++
>   debian/scripts/misc/arch-has-odm-enabled.sh | 30 +++++++++++++++++++++
>   debian/scripts/misc/kernelconfig            |  2 +-
>   ubuntu/Kconfig                              |  6 +++++
>   8 files changed, 47 insertions(+), 1 deletion(-)
>   create mode 100755 debian/scripts/misc/arch-has-odm-enabled.sh
>
Andrea Righi June 18, 2021, 9:26 a.m. UTC | #3
On Fri, Jun 11, 2021 at 06:01:23PM +0800, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1912789
> 
> [SRU Justification]
> 
> = Impact =
> 
> We want to add some driver code which exists in the primary kernel source
> but will not get included unless specifically asked for. As long as there
> are no drivers using this, there is no user-visible change.
> 
> = Impact =
> 
> This will be done by adding a new config option which gets turned on via
> build setup rules. The default will be off.
> 
> = Testcase =
> 
> As long as there are no consumers changes can only be seen by inspecting
> the build logs (if even that).
> 
> = Regression Potential =
> 
> This prepares for future consumers. At this stage either the build will
> fail completely or pass and in that case the produced kernel binaries are
> the same as they were before.
> 
> Chia-Lin Kao (AceLan) (1):
>   UBUNTU: [Packaging] Fix ODM DRIVERS Kconfig
> 
> Stefan Bader (3):
>   UBUNTU: [Packaging] Add support for ODM drivers
>   UBUNTU: [Packaging] Turn on ODM support for amd64
>   UBUNTU: [Packaging] Fix ODM support in actual build
> 
>  debian.master/config/config.common.ubuntu   |  1 +
>  debian.master/rules.d/amd64.mk              |  1 +
>  debian/rules.d/0-common-vars.mk             |  4 +++
>  debian/rules.d/1-maintainer.mk              |  1 +
>  debian/rules.d/2-binary-arch.mk             |  3 +++
>  debian/scripts/misc/arch-has-odm-enabled.sh | 30 +++++++++++++++++++++
>  debian/scripts/misc/kernelconfig            |  2 +-
>  ubuntu/Kconfig                              |  6 +++++
>  8 files changed, 47 insertions(+), 1 deletion(-)
>  create mode 100755 debian/scripts/misc/arch-has-odm-enabled.sh

Applied to unstable/5.13.

Thanks,
-Andrea
Stefan Bader June 18, 2021, 9:37 a.m. UTC | #4
On 11.06.21 12:01, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1912789
> 
> [SRU Justification]
> 
> = Impact =
> 
> We want to add some driver code which exists in the primary kernel source
> but will not get included unless specifically asked for. As long as there
> are no drivers using this, there is no user-visible change.
> 
> = Impact =
> 
> This will be done by adding a new config option which gets turned on via
> build setup rules. The default will be off.
> 
> = Testcase =
> 
> As long as there are no consumers changes can only be seen by inspecting
> the build logs (if even that).
> 
> = Regression Potential =
> 
> This prepares for future consumers. At this stage either the build will
> fail completely or pass and in that case the produced kernel binaries are
> the same as they were before.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Packaging] Fix ODM DRIVERS Kconfig
> 
> Stefan Bader (3):
>    UBUNTU: [Packaging] Add support for ODM drivers
>    UBUNTU: [Packaging] Turn on ODM support for amd64
>    UBUNTU: [Packaging] Fix ODM support in actual build
> 
>   debian.master/config/config.common.ubuntu   |  1 +
>   debian.master/rules.d/amd64.mk              |  1 +
>   debian/rules.d/0-common-vars.mk             |  4 +++
>   debian/rules.d/1-maintainer.mk              |  1 +
>   debian/rules.d/2-binary-arch.mk             |  3 +++
>   debian/scripts/misc/arch-has-odm-enabled.sh | 30 +++++++++++++++++++++
>   debian/scripts/misc/kernelconfig            |  2 +-
>   ubuntu/Kconfig                              |  6 +++++
>   8 files changed, 47 insertions(+), 1 deletion(-)
>   create mode 100755 debian/scripts/misc/arch-has-odm-enabled.sh
> 
Applied to hirsute:linux. Thanks.

-Stefan