mbox series

[SRU,F,v4,0/1] ice: add additional E810 device id

Message ID 20210601155951.17970-1-michael.reed@canonical.com
Headers show
Series ice: add additional E810 device id | expand

Message

Michael Reed June 1, 2021, 3:59 p.m. UTC
From: Michael Reed <Michael.Reed@canonical.com>

Buglink: https://bugs.launchpad.net/bugs/1912511

SRU Justification:

[Impact]
The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via MAAS, or use these cards at all post-install when installing from an ISO.

The patch to resolve this landed in Groovy, so this should be a pretty straightforward pick to 5.4. The patch set is small.

[Test Case]

This is easily reproducible by simply trying to install Focal onto a system with an E810 NIC. The NIC is not recognized and thus is not configurable or usable.

[Where problems could occur]

All this patch does is add PCI ID information for E810 to the driver to enable a wider set of cards to be used. Problems should not involve regressions to existing supported hardware, if anything the biggest issue could be discovering that after adding the PCI IDs, further patches are necessary to fully enable support in the Ice driver.

[Other Info]

This was reported by a hardware partner and blocks certification for systems that use E810 based NICs as their primary network devices.
I finally got this to cherrypick properly.

Bruce Allan (1):
  ice: add additional E810 device id

 drivers/net/ethernet/intel/ice/ice_devids.h | 2 ++
 drivers/net/ethernet/intel/ice/ice_main.c   | 1 +
 2 files changed, 3 insertions(+)

Comments

Tim Gardner June 1, 2021, 4:27 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 6/1/21 9:59 AM, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
> 
> Buglink: https://bugs.launchpad.net/bugs/1912511
> 
> SRU Justification:
> 
> [Impact]
> The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via MAAS, or use these cards at all post-install when installing from an ISO.
> 
> The patch to resolve this landed in Groovy, so this should be a pretty straightforward pick to 5.4. The patch set is small.
> 
> [Test Case]
> 
> This is easily reproducible by simply trying to install Focal onto a system with an E810 NIC. The NIC is not recognized and thus is not configurable or usable.
> 
> [Where problems could occur]
> 
> All this patch does is add PCI ID information for E810 to the driver to enable a wider set of cards to be used. Problems should not involve regressions to existing supported hardware, if anything the biggest issue could be discovering that after adding the PCI IDs, further patches are necessary to fully enable support in the Ice driver.
> 
> [Other Info]
> 
> This was reported by a hardware partner and blocks certification for systems that use E810 based NICs as their primary network devices.
> I finally got this to cherrypick properly.
> 
> Bruce Allan (1):
>    ice: add additional E810 device id
> 
>   drivers/net/ethernet/intel/ice/ice_devids.h | 2 ++
>   drivers/net/ethernet/intel/ice/ice_main.c   | 1 +
>   2 files changed, 3 insertions(+)
>
Stefan Bader June 10, 2021, 8:59 a.m. UTC | #2
On 01.06.21 17:59, Michael Reed wrote:
> From: Michael Reed <Michael.Reed@canonical.com>
> 
> Buglink: https://bugs.launchpad.net/bugs/1912511
> 
> SRU Justification:
> 
> [Impact]
> The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via MAAS, or use these cards at all post-install when installing from an ISO.
> 
> The patch to resolve this landed in Groovy, so this should be a pretty straightforward pick to 5.4. The patch set is small.
> 
> [Test Case]
> 
> This is easily reproducible by simply trying to install Focal onto a system with an E810 NIC. The NIC is not recognized and thus is not configurable or usable.
> 
> [Where problems could occur]
> 
> All this patch does is add PCI ID information for E810 to the driver to enable a wider set of cards to be used. Problems should not involve regressions to existing supported hardware, if anything the biggest issue could be discovering that after adding the PCI IDs, further patches are necessary to fully enable support in the Ice driver.
> 
> [Other Info]
> 
> This was reported by a hardware partner and blocks certification for systems that use E810 based NICs as their primary network devices.
> I finally got this to cherrypick properly.
> 
> Bruce Allan (1):
>    ice: add additional E810 device id
> 
>   drivers/net/ethernet/intel/ice/ice_devids.h | 2 ++
>   drivers/net/ethernet/intel/ice/ice_main.c   | 1 +
>   2 files changed, 3 insertions(+)
> 

Applied to focal:linux/master-next and moved the BugLink to the top while doing 
so. Thanks.

-Stefan