mbox series

[0/6,SRU,G,H,Unstable] Add support for IO functions of AAEON devices

Message ID 20210525101720.522132-1-acelan.kao@canonical.com
Headers show
Series Add support for IO functions of AAEON devices | expand

Message

AceLan Kao May 25, 2021, 10:17 a.m. UTC 
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1929504

[Impact]
Require drivers to enable AAEON devices.

[Fix]
AAEON provides a series of patches to support its
GPIO/LED/Watchdog/HWMON devices.

[Test]
Verified on AAEON platform.

[Where problems could occur]
No, they are new drivers, should not introduce any regressions.

Chia-Lin Kao (AceLan) (1):
  UBUNTU: [Config] updateconfigs for AAEON

Kunyang_Fan (5):
  UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
  UBUNTU: ODM: gpio: add driver for AAEON devices
  UBUNTU: ODM: watchdog: add driver for AAEON devices
  UBUNTU: ODM: hwmon: add driver for AAEON devices
  UBUNTU: ODM: leds: add driver for AAEON devices

 MAINTAINERS                               |  12 +
 debian.master/config/config.common.ubuntu |   5 +
 drivers/gpio/Kconfig                      |  11 +
 drivers/gpio/Makefile                     |   1 +
 drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
 drivers/hwmon/Kconfig                     |  11 +
 drivers/hwmon/Makefile                    |   1 +
 drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
 drivers/leds/Kconfig                      |  11 +
 drivers/leds/Makefile                     |   1 +
 drivers/leds/leds-aaeon.c                 | 142 ++++++
 drivers/mfd/Kconfig                       |  12 +
 drivers/mfd/Makefile                      |   1 +
 drivers/mfd/mfd-aaeon.c                   |  77 +++
 drivers/watchdog/Kconfig                  |  12 +
 drivers/watchdog/Makefile                 |   1 +
 drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
 17 files changed, 1313 insertions(+)
 create mode 100644 drivers/gpio/gpio-aaeon.c
 create mode 100644 drivers/hwmon/hwmon-aaeon.c
 create mode 100644 drivers/leds/leds-aaeon.c
 create mode 100644 drivers/mfd/mfd-aaeon.c
 create mode 100644 drivers/watchdog/wdt_aaeon.c

Comments

Kleber Sacilotto de Souza May 27, 2021, 8:45 a.m. UTC | #1 
On 25.05.21 12:17, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for AAEON
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices

Note that some patches are using the tag "Review-by:", those need
to be replaced by "Reviewed-by:" when applying.


Kleber
Tim Gardner May 27, 2021, 12:23 p.m. UTC | #2 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

All of the changes to Kconfig and Makefile look reasonable. Chance of 
regression is low since each driver only completes loading if its on the 
right platform, e.g.,

+	if (!wmi_has_guid(AAEON_WMI_MGMT_GUID)) {
+		dev_info(&wdev->dev, "AAEON Management GUID not found\n");
+		return -ENODEV;
+	}

Fix the 'Review-by:' misspelling at apply time.

rtg

On 5/25/21 4:17 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for AAEON
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  11 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  11 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  11 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  12 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1313 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
>
Kleber Sacilotto de Souza May 27, 2021, 3:38 p.m. UTC | #3 
On 25.05.21 12:17, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.

LGTM.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Thanks

> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for AAEON
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 
>   MAINTAINERS                               |  12 +
>   debian.master/config/config.common.ubuntu |   5 +
>   drivers/gpio/Kconfig                      |  11 +
>   drivers/gpio/Makefile                     |   1 +
>   drivers/gpio/gpio-aaeon.c                 | 205 ++++++++
>   drivers/hwmon/Kconfig                     |  11 +
>   drivers/hwmon/Makefile                    |   1 +
>   drivers/hwmon/hwmon-aaeon.c               | 568 ++++++++++++++++++++++
>   drivers/leds/Kconfig                      |  11 +
>   drivers/leds/Makefile                     |   1 +
>   drivers/leds/leds-aaeon.c                 | 142 ++++++
>   drivers/mfd/Kconfig                       |  12 +
>   drivers/mfd/Makefile                      |   1 +
>   drivers/mfd/mfd-aaeon.c                   |  77 +++
>   drivers/watchdog/Kconfig                  |  12 +
>   drivers/watchdog/Makefile                 |   1 +
>   drivers/watchdog/wdt_aaeon.c              | 242 +++++++++
>   17 files changed, 1313 insertions(+)
>   create mode 100644 drivers/gpio/gpio-aaeon.c
>   create mode 100644 drivers/hwmon/hwmon-aaeon.c
>   create mode 100644 drivers/leds/leds-aaeon.c
>   create mode 100644 drivers/mfd/mfd-aaeon.c
>   create mode 100644 drivers/watchdog/wdt_aaeon.c
>
Kleber Sacilotto de Souza May 27, 2021, 4:02 p.m. UTC | #4 
On 25.05.21 12:17, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.


Applied to [groovy/hirsute]:linux.

Thanks,
Kleber
Kleber Sacilotto de Souza May 28, 2021, 2:31 p.m. UTC | #5 
On 25.05.21 12:17, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1929504
> 
> [Impact]
> Require drivers to enable AAEON devices.
> 
> [Fix]
> AAEON provides a series of patches to support its
> GPIO/LED/Watchdog/HWMON devices.
> 
> [Test]
> Verified on AAEON platform.
> 
> [Where problems could occur]
> No, they are new drivers, should not introduce any regressions.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for AAEON
> 
> Kunyang_Fan (5):
>    UBUNTU: ODM: mfd: Add support for IO functions of AAEON devices
>    UBUNTU: ODM: gpio: add driver for AAEON devices
>    UBUNTU: ODM: watchdog: add driver for AAEON devices
>    UBUNTU: ODM: hwmon: add driver for AAEON devices
>    UBUNTU: ODM: leds: add driver for AAEON devices
> 

Hi AceLan,

Groovy and Hirsute kernels don't have the ODM drivers support as Focal
does. This was implemented in Focal with the following commit:

https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/commit/?id=fd0ebc6ef71016a51d1d2a9bb60d64175e317053

Adding modules which depend on UBUNTU_ODM_DRIVERS will not have any
effect. Running 'fakeroot debian/rules updateconfigs' will remove all of
*AAEON* configs just added.

As those modules can't be enabled I have removed these patches
from groovy and hirsute.

Let's discuss offline how to solve this issue.


Thanks,
Kleber
Paolo Pisati May 31, 2021, 2:55 p.m. UTC | #6 
On Fri, May 28, 2021 at 04:31:57PM +0200, Kleber Souza wrote:

> Groovy and Hirsute kernels don't have the ODM drivers support as Focal
> does. This was implemented in Focal with the following commit:
> 
> https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal/commit/?id=fd0ebc6ef71016a51d1d2a9bb60d64175e317053
> 
> Adding modules which depend on UBUNTU_ODM_DRIVERS will not have any
> effect. Running 'fakeroot debian/rules updateconfigs' will remove all of
> *AAEON* configs just added.
> 
> As those modules can't be enabled I have removed these patches
> from groovy and hirsute.

I'll take this as a NAK and won't apply to Unstable.