From patchwork Fri May 7 07:39:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1475376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fc2RK5GyBz9t0T; Fri, 7 May 2021 17:40:13 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1lev5m-0006H3-Q6; Fri, 07 May 2021 07:40:10 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lev5k-0006Gq-Lk for kernel-team@lists.ubuntu.com; Fri, 07 May 2021 07:40:08 +0000 Received: from [123.112.70.57] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lev5j-0001Nm-KB for kernel-team@lists.ubuntu.com; Fri, 07 May 2021 07:40:08 +0000 From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][F][PATCH 0/1] alsa/sof: make sof driver work in the case of without i915 (focal kernel) Date: Fri, 7 May 2021 15:39:52 +0800 Message-Id: <20210507073953.15588-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1927672 The fix is already in the upstream from linux-5.6-rc, so only focal kernel need this patch. [Impact] When we boot the focal kernel on the cml or cfl machines without HDMI/DP codec, the sof driver fails to initialize, and the whole audio fails to work. [Fix] Refer to an upstream commit, we move the codec_probe_bus() ahead of creation of audio mach device. [Test] Tested the patched kernel on the cml and cfl machines, if they have hdmi/dp codec, the audio works as well as before, if they don't have hdmi/dp codec, the analog audio still work with sof driver. Also tested on TGL machines, the i915 driver in the focal kernel can't work on the TGL machines, this will make the i915 codec probe fail, with the patched kernel, the analog audio still work on the TGL machines. Without this patch, the whole audio will fail on the TGL machines with focal kernel. [Where problems could occur] this patch moves the codec probing ahead, it could make the codec probing fail, then the whole audio will fail no matter with or without i915 codec. But this possibility is very low, I tested the patched kernel on many machines, all worked well. Hui Wang (1): UBUNTU: SAUCE: ASoC: SOF: Intel: hda: move the probe_bus ahead of creation of mach device sound/soc/sof/intel/hda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Stefan Bader