| Message ID | 20210507073953.15588-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa/sof: make sof driver work in the case of without i915 (focal kernel) | expand |
On 07.05.21 09:39, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1927672 > > The fix is already in the upstream from linux-5.6-rc, so only focal > kernel need this patch. > > [Impact] > When we boot the focal kernel on the cml or cfl machines without > HDMI/DP codec, the sof driver fails to initialize, and the whole > audio fails to work. > > [Fix] > Refer to an upstream commit, we move the codec_probe_bus() ahead > of creation of audio mach device. > > [Test] > Tested the patched kernel on the cml and cfl machines, if > they have hdmi/dp codec, the audio works as well as before, if > they don't have hdmi/dp codec, the analog audio still work with > sof driver. > > Also tested on TGL machines, the i915 driver in the focal kernel > can't work on the TGL machines, this will make the i915 codec probe > fail, with the patched kernel, the analog audio still work on the > TGL machines. Without this patch, the whole audio will fail on > the TGL machines with focal kernel. > > > [Where problems could occur] > this patch moves the codec probing ahead, it could make the codec > probing fail, then the whole audio will fail no matter with or without > i915 codec. But this possibility is very low, I tested the patched > kernel on many machines, all worked well. > > > > Hui Wang (1): > UBUNTU: SAUCE: ASoC: SOF: Intel: hda: move the probe_bus ahead of > creation of mach device > > sound/soc/sof/intel/hda.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > SAUCE to avoid bigger backport, good test results. Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 07.05.21 09:39, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1927672 > > The fix is already in the upstream from linux-5.6-rc, so only focal > kernel need this patch. > > [Impact] > When we boot the focal kernel on the cml or cfl machines without > HDMI/DP codec, the sof driver fails to initialize, and the whole > audio fails to work. > > [Fix] > Refer to an upstream commit, we move the codec_probe_bus() ahead > of creation of audio mach device. > > [Test] > Tested the patched kernel on the cml and cfl machines, if > they have hdmi/dp codec, the audio works as well as before, if > they don't have hdmi/dp codec, the analog audio still work with > sof driver. > > Also tested on TGL machines, the i915 driver in the focal kernel > can't work on the TGL machines, this will make the i915 codec probe > fail, with the patched kernel, the analog audio still work on the > TGL machines. Without this patch, the whole audio will fail on > the TGL machines with focal kernel. > > > [Where problems could occur] > this patch moves the codec probing ahead, it could make the codec > probing fail, then the whole audio will fail no matter with or without > i915 codec. But this possibility is very low, I tested the patched > kernel on many machines, all worked well. > > > > Hui Wang (1): > UBUNTU: SAUCE: ASoC: SOF: Intel: hda: move the probe_bus ahead of > creation of mach device > > sound/soc/sof/intel/hda.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Applied to focal:linux. Thanks, Kleber
BugLink: https://bugs.launchpad.net/bugs/1927672 The fix is already in the upstream from linux-5.6-rc, so only focal kernel need this patch. [Impact] When we boot the focal kernel on the cml or cfl machines without HDMI/DP codec, the sof driver fails to initialize, and the whole audio fails to work. [Fix] Refer to an upstream commit, we move the codec_probe_bus() ahead of creation of audio mach device. [Test] Tested the patched kernel on the cml and cfl machines, if they have hdmi/dp codec, the audio works as well as before, if they don't have hdmi/dp codec, the analog audio still work with sof driver. Also tested on TGL machines, the i915 driver in the focal kernel can't work on the TGL machines, this will make the i915 codec probe fail, with the patched kernel, the analog audio still work on the TGL machines. Without this patch, the whole audio will fail on the TGL machines with focal kernel. [Where problems could occur] this patch moves the codec probing ahead, it could make the codec probing fail, then the whole audio will fail no matter with or without i915 codec. But this possibility is very low, I tested the patched kernel on many machines, all worked well. Hui Wang (1): UBUNTU: SAUCE: ASoC: SOF: Intel: hda: move the probe_bus ahead of creation of mach device sound/soc/sof/intel/hda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)