mbox series

[00/15,OEM-5.10] UBUNTU: SAUCE: add support of MSO panel

Message ID 20210326073009.515253-1-aaron.ma@canonical.com
Headers show
Series UBUNTU: SAUCE: add support of MSO panel | expand

Message

Aaron Ma March 26, 2021, 7:29 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1921318

[Impact]
New panel with MSO feature can't be light up.

[Fix]
This series enables eDP MSO on TGL+.
Patch set:
https://patchwork.freedesktop.org/series/86992/
https://patchwork.freedesktop.org/series/87536/
It depends on another patch set:
https://patchwork.freedesktop.org/series/83780/

[Test Case]
Verified on the target platform and other 2 laptops without MSO feature,
internal display good;
external monitor good;
external monitor good via dock;
no errors after GPU benchmark;

[Where problems could occur]
Intel GPU may lose the output.
Due to the concern of the big change, target to oem-5.10 only.

Jani Nikula (9):
  drm/dp: add MSO related DPCD registers
  drm/i915/edp: reject modes with dimensions other than fixed mode
  drm/i915/edp: always add fixed mode to probed modes in ->get_modes()
  drm/i915/edp: read sink MSO configuration for eDP 1.4+
  drm/i915/reg: add stream splitter configuration definitions
  drm/i915/mso: add splitter state readout for platforms that support it
  drm/i915/mso: add splitter state check
  drm/i915/edp: modify fixed and downclock modes for MSO
  drm/i915/edp: enable eDP MSO during link training

Maarten Lankhorst (1):
  drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

Manasi Navare (2):
  drm/i915: Move encoder->get_config to a new function
  drm/i915: Add a wrapper function around get_pipe_config

Ville Syrjälä (3):
  drm/i915: Move hw.active assignment into intel_crtc_get_pipe_config()
  drm/i915: s/intel_mode_from_pipe_config/intel_mode_from_crtc_timings/
  drm/i915: Introduce intel_crtc_readout_derived_state()

 drivers/gpu/drm/i915/display/intel_ddi.c      |  78 ++++++
 drivers/gpu/drm/i915/display/intel_display.c  | 224 ++++++++++++------
 drivers/gpu/drm/i915/display/intel_display.h  |   2 -
 .../drm/i915/display/intel_display_types.h    |  20 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 121 +++++++++-
 drivers/gpu/drm/i915/i915_drv.h               |   2 +
 drivers/gpu/drm/i915/i915_reg.h               |   3 +
 drivers/gpu/drm/i915/intel_pm.c               |  76 +++---
 include/drm/drm_dp_helper.h                   |   5 +
 9 files changed, 410 insertions(+), 121 deletions(-)

Comments

Aaron Ma March 26, 2021, 8:16 a.m. UTC | #1
BugLink: https://bugs.launchpad.net/bugs/1921318

[Impact]
New panel with MSO feature can't be light up.

[Fix]
This series enables eDP MSO on TGL+.
Patch set:
https://patchwork.freedesktop.org/series/86992/
https://patchwork.freedesktop.org/series/87536/
It depends on another patch set:
https://patchwork.freedesktop.org/series/83780/

[Test Case]
Verified on the target platform and other 2 laptops without MSO feature,
internal display good;
external monitor good;
external monitor good via dock;
no errors after GPU benchmark;

[Where problems could occur]
Intel GPU may lose the output.
Due to the concern of the big change, target to oem-5.10 only.

Jani Nikula (9):
  drm/dp: add MSO related DPCD registers
  drm/i915/edp: reject modes with dimensions other than fixed mode
  drm/i915/edp: always add fixed mode to probed modes in ->get_modes()
  drm/i915/edp: read sink MSO configuration for eDP 1.4+
  drm/i915/reg: add stream splitter configuration definitions
  drm/i915/mso: add splitter state readout for platforms that support it
  drm/i915/mso: add splitter state check
  drm/i915/edp: modify fixed and downclock modes for MSO
  drm/i915/edp: enable eDP MSO during link training

Maarten Lankhorst (1):
  drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

Manasi Navare (2):
  drm/i915: Move encoder->get_config to a new function
  drm/i915: Add a wrapper function around get_pipe_config

Ville Syrjälä (3):
  drm/i915: Move hw.active assignment into intel_crtc_get_pipe_config()
  drm/i915: s/intel_mode_from_pipe_config/intel_mode_from_crtc_timings/
  drm/i915: Introduce intel_crtc_readout_derived_state()

 drivers/gpu/drm/i915/display/intel_ddi.c      |  78 ++++++
 drivers/gpu/drm/i915/display/intel_display.c  | 224 ++++++++++++------
 drivers/gpu/drm/i915/display/intel_display.h  |   2 -
 .../drm/i915/display/intel_display_types.h    |  20 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 121 +++++++++-
 drivers/gpu/drm/i915/i915_drv.h               |   2 +
 drivers/gpu/drm/i915/i915_reg.h               |   3 +
 drivers/gpu/drm/i915/intel_pm.c               |  76 +++---
 include/drm/drm_dp_helper.h                   |   5 +
 9 files changed, 410 insertions(+), 121 deletions(-)
Aaron Ma March 26, 2021, 10:03 a.m. UTC | #2
BugLink: https://bugs.launchpad.net/bugs/1921318

[Impact]
New panel with MSO feature can't be light up.

[Fix]
This series enables eDP MSO on TGL+.
Patch set:
https://patchwork.freedesktop.org/series/86992/
https://patchwork.freedesktop.org/series/87536/
It depends on another patch set:
https://patchwork.freedesktop.org/series/83780/

[Test Case]
Verified on the target platform and other 2 laptops without MSO feature,
internal display good;
external monitor good;
external monitor good via dock;
no errors after GPU benchmark;

[Where problems could occur]
Intel GPU may lose the output.
Due to the concern of the big change, target to oem-5.10 only.

Jani Nikula (9):
  drm/dp: add MSO related DPCD registers
  drm/i915/edp: reject modes with dimensions other than fixed mode
  drm/i915/edp: always add fixed mode to probed modes in ->get_modes()
  drm/i915/edp: read sink MSO configuration for eDP 1.4+
  drm/i915/reg: add stream splitter configuration definitions
  drm/i915/mso: add splitter state readout for platforms that support it
  drm/i915/mso: add splitter state check
  drm/i915/edp: modify fixed and downclock modes for MSO
  drm/i915/edp: enable eDP MSO during link training

Maarten Lankhorst (1):
  drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

Manasi Navare (2):
  drm/i915: Move encoder->get_config to a new function
  drm/i915: Add a wrapper function around get_pipe_config

Ville Syrjälä (3):
  drm/i915: Move hw.active assignment into intel_crtc_get_pipe_config()
  drm/i915: s/intel_mode_from_pipe_config/intel_mode_from_crtc_timings/
  drm/i915: Introduce intel_crtc_readout_derived_state()

 drivers/gpu/drm/i915/display/intel_ddi.c      |  78 ++++++
 drivers/gpu/drm/i915/display/intel_display.c  | 224 ++++++++++++------
 drivers/gpu/drm/i915/display/intel_display.h  |   2 -
 .../drm/i915/display/intel_display_types.h    |  20 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 121 +++++++++-
 drivers/gpu/drm/i915/i915_drv.h               |   2 +
 drivers/gpu/drm/i915/i915_reg.h               |   3 +
 drivers/gpu/drm/i915/intel_pm.c               |  76 +++---
 include/drm/drm_dp_helper.h                   |   5 +
 9 files changed, 410 insertions(+), 121 deletions(-)
Paolo Pisati April 2, 2021, 11:19 a.m. UTC | #3
On Fri, Mar 26, 2021 at 06:03:04PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921318

Patches 1-7 are already part of 5.12-rc5/Unstable.
Patches 8-15 are in linux-next and i can cleanly cherry-pick all of them.

Shall i apply these patches to Unstable too?
Aaron Ma April 2, 2021, 11:48 a.m. UTC | #4
On 4/2/21 7:19 PM, Paolo Pisati wrote:
> On Fri, Mar 26, 2021 at 06:03:04PM +0800, Aaron Ma wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1921318
> Patches 1-7 are already part of 5.12-rc5/Unstable.
> Patches 8-15 are in linux-next and i can cleanly cherry-pick all of them.
>
> Shall i apply these patches to Unstable too?

I prefer to apply them to Unstable.

And I did test them on 5.12-rc5, all result are the same as I posted for 5.10-oem.

Thanks.
Aaron
Paolo Pisati April 2, 2021, 12:47 p.m. UTC | #5
On Fri, Apr 02, 2021 at 07:48:16PM +0800, Aaron Ma wrote:
> On 4/2/21 7:19 PM, Paolo Pisati wrote:
> > On Fri, Mar 26, 2021 at 06:03:04PM +0800, Aaron Ma wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1921318
> > Patches 1-7 are already part of 5.12-rc5/Unstable.
> > Patches 8-15 are in linux-next and i can cleanly cherry-pick all of them.
> > 
> > Shall i apply these patches to Unstable too?
> 
> I prefer to apply them to Unstable.
> 
> And I did test them on 5.12-rc5, all result are the same as I posted for 5.10-oem.
Timo Aaltonen April 20, 2021, 10:10 a.m. UTC | #6
On 26.3.2021 12.03, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1921318
> 
> [Impact]
> New panel with MSO feature can't be light up.
> 
> [Fix]
> This series enables eDP MSO on TGL+.
> Patch set:
> https://patchwork.freedesktop.org/series/86992/
> https://patchwork.freedesktop.org/series/87536/
> It depends on another patch set:
> https://patchwork.freedesktop.org/series/83780/
> 
> [Test Case]
> Verified on the target platform and other 2 laptops without MSO feature,
> internal display good;
> external monitor good;
> external monitor good via dock;
> no errors after GPU benchmark;
> 
> [Where problems could occur]
> Intel GPU may lose the output.
> Due to the concern of the big change, target to oem-5.10 only.
> 
> Jani Nikula (9):
>    drm/dp: add MSO related DPCD registers
>    drm/i915/edp: reject modes with dimensions other than fixed mode
>    drm/i915/edp: always add fixed mode to probed modes in ->get_modes()
>    drm/i915/edp: read sink MSO configuration for eDP 1.4+
>    drm/i915/reg: add stream splitter configuration definitions
>    drm/i915/mso: add splitter state readout for platforms that support it
>    drm/i915/mso: add splitter state check
>    drm/i915/edp: modify fixed and downclock modes for MSO
>    drm/i915/edp: enable eDP MSO during link training
> 
> Maarten Lankhorst (1):
>    drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split
> 
> Manasi Navare (2):
>    drm/i915: Move encoder->get_config to a new function
>    drm/i915: Add a wrapper function around get_pipe_config
> 
> Ville Syrjälä (3):
>    drm/i915: Move hw.active assignment into intel_crtc_get_pipe_config()
>    drm/i915: s/intel_mode_from_pipe_config/intel_mode_from_crtc_timings/
>    drm/i915: Introduce intel_crtc_readout_derived_state()
> 
>   drivers/gpu/drm/i915/display/intel_ddi.c      |  78 ++++++
>   drivers/gpu/drm/i915/display/intel_display.c  | 224 ++++++++++++------
>   drivers/gpu/drm/i915/display/intel_display.h  |   2 -
>   .../drm/i915/display/intel_display_types.h    |  20 +-
>   drivers/gpu/drm/i915/display/intel_dp.c       | 121 +++++++++-
>   drivers/gpu/drm/i915/i915_drv.h               |   2 +
>   drivers/gpu/drm/i915/i915_reg.h               |   3 +
>   drivers/gpu/drm/i915/intel_pm.c               |  76 +++---
>   include/drm/drm_dp_helper.h                   |   5 +
>   9 files changed, 410 insertions(+), 121 deletions(-)
>