mbox series

[SRU,F/G/H/OEM-5.10,0/3] Mute/Mic-mute LEDs are not work on HP 850/840/440 G8 Laptops

Message ID 20210318150956.8008-1-jeremy.szu@canonical.com
Headers show
Series Mute/Mic-mute LEDs are not work on HP 850/840/440 G8 Laptops | expand

Message

Jeremy Szu March 18, 2021, 3:09 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1920030

[Impact]
The Mute/Mic-mute LEDs are not work when muting audio-output/microphone on HP 850/840/440 G8 laptops.

[Fix]
Add three realtek quirks for them.

[Test]
After applying the quirks, the LEDs are functioned on HP 850/840/440 G8 laptops.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem IDs of audio codec which are using different GPIO pins (different layout), then the quirks will not work (LEDs will not function when muting audio-output or microphone.

Jeremy Szu (3):
  ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
  ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
  ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8

 sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Tim Gardner March 18, 2021, 3:35 p.m. UTC | #1 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 3/18/21 9:09 AM, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920030
> 
> [Impact]
> The Mute/Mic-mute LEDs are not work when muting audio-output/microphone on HP 850/840/440 G8 laptops.
> 
> [Fix]
> Add three realtek quirks for them.
> 
> [Test]
> After applying the quirks, the LEDs are functioned on HP 850/840/440 G8 laptops.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem IDs of audio codec which are using different GPIO pins (different layout), then the quirks will not work (LEDs will not function when muting audio-output or microphone.
> 
> Jeremy Szu (3):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8
> 
>   sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
Timo Aaltonen March 18, 2021, 7:30 p.m. UTC | #2 
On 18.3.2021 17.09, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920030
> 
> [Impact]
> The Mute/Mic-mute LEDs are not work when muting audio-output/microphone on HP 850/840/440 G8 laptops.
> 
> [Fix]
> Add three realtek quirks for them.
> 
> [Test]
> After applying the quirks, the LEDs are functioned on HP 850/840/440 G8 laptops.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem IDs of audio codec which are using different GPIO pins (different layout), then the quirks will not work (LEDs will not function when muting audio-output or microphone.
> 
> Jeremy Szu (3):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8
> 
>   sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 

applied to oem-5.10, though they had to be manually applied due to other 
stable updates
Timo Aaltonen March 18, 2021, 9:28 p.m. UTC | #3 
On 18.3.2021 21.30, Timo Aaltonen wrote:
> On 18.3.2021 17.09, Jeremy Szu wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1920030
>>
>> [Impact]
>> The Mute/Mic-mute LEDs are not work when muting 
>> audio-output/microphone on HP 850/840/440 G8 laptops.
>>
>> [Fix]
>> Add three realtek quirks for them.
>>
>> [Test]
>> After applying the quirks, the LEDs are functioned on HP 850/840/440 
>> G8 laptops.
>>
>> [Where problems could occur]
>> If HP ships the different system boards design with the same subsystem 
>> IDs of audio codec which are using different GPIO pins (different 
>> layout), then the quirks will not work (LEDs will not function when 
>> muting audio-output or microphone.
>>
>> Jeremy Szu (3):
>>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
>>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
>>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8
>>
>>   sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
> 
> applied to oem-5.10, though they had to be manually applied due to other 
> stable updates

And they are all missing the buglink..
Tim Gardner March 19, 2021, 8:46 p.m. UTC | #4 
These don't apply to f/g/h linux/master-next.

rtg

On 3/18/21 9:09 AM, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1920030
> 
> [Impact]
> The Mute/Mic-mute LEDs are not work when muting audio-output/microphone on HP 850/840/440 G8 laptops.
> 
> [Fix]
> Add three realtek quirks for them.
> 
> [Test]
> After applying the quirks, the LEDs are functioned on HP 850/840/440 G8 laptops.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem IDs of audio codec which are using different GPIO pins (different layout), then the quirks will not work (LEDs will not function when muting audio-output or microphone.
> 
> Jeremy Szu (3):
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8
>    ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8
> 
>   sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>